Skip to content

Commit

Permalink
Update all platforms to miniupnpc 2.2.2 and Windows to Python 3.9 (#6703
Browse files Browse the repository at this point in the history
)

* Update all platforms to miniupnpc 2.2.2 and Windows to Python 3.9

* Actually use python 3.9 in Windows
  • Loading branch information
hoffmang9 committed Jun 14, 2021
1 parent 2335bef commit dc78116
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-linux-arm64-installer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
echo "Emulating install.sh" && \
pip install --upgrade pip && \
pip install wheel && \
pip install --extra-index-url https://pypi.chia.net/simple/ miniupnpc==2.1 && \
pip install --extra-index-url https://pypi.chia.net/simple/ miniupnpc==2.2.2 && \
pip install . --extra-index-url https://pypi.chia.net/simple/ && \
ldd --version && \
cd build_scripts && \
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/build-windows-installer.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Windows Installer on Windows 10 and Python 3.7
name: Windows Installer on Windows 10 and Python 3.9

on:
push:
Expand All @@ -12,7 +12,7 @@ on:

jobs:
build:
name: Windows Installer on Windows 10 and Python 3.7
name: Windows Installer on Windows 10 and Python 3.9
runs-on: [windows-latest]
timeout-minutes: 40

Expand Down Expand Up @@ -57,9 +57,9 @@ jobs:
# We can't upgrade to Python 3.8 until we have a miniupnpc binary
- uses: actions/setup-python@v2
name: Install Python 3.7
name: Install Python 3.9
with:
python-version: "3.7"
python-version: "3.9"

- name: Test for secrets access
id: check_secrets
Expand Down
2 changes: 1 addition & 1 deletion azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ steps:
python -m pip install --upgrade pip
pip install wheel pep517 setuptools_scm
node -v
pip install -i https://pypi.chia.net/simple/ miniupnpc==2.1
pip install -i https://pypi.chia.net/simple/ miniupnpc==2.2.2
displayName: "Install dependencies"
- script: |
Expand Down
7 changes: 4 additions & 3 deletions build_scripts/build_windows.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@ git status
Write-Output " ---"
Write-Output "curl miniupnpc"
Write-Output " ---"
Invoke-WebRequest -Uri "https://pypi.chia.net/simple/miniupnpc/miniupnpc-2.1-cp37-cp37m-win_amd64.whl" -OutFile "miniupnpc-2.1-cp37-cp37m-win_amd64.whl"
Write-Output "Using win_amd64 python 3.7 wheel from https://github.com/miniupnp/miniupnp/pull/475 (2.2.0-RC1)"
Invoke-WebRequest -Uri "https://pypi.chia.net/simple/miniupnpc/miniupnpc-2.2.2-cp39-cp39-win_amd64.whl" -OutFile "miniupnpc-2.2.2-cp39-cp39-win_amd64.whl"
Write-Output "Using win_amd64 python 3.9 wheel from https://github.com/miniupnp/miniupnp/pull/475 (2.2.0-RC1)"
Write-Output "Actual build from https://github.com/miniupnp/miniupnp/commit/7783ac1545f70e3341da5866069bde88244dd848"
If ($LastExitCode -gt 0){
Throw "Failed to download miniupnpc!"
}
Expand All @@ -22,7 +23,7 @@ else
}

Write-Output " ---"
Write-Output "Create venv - python3.7 or 3.8 is required in PATH"
Write-Output "Create venv - python3.9 is required in PATH"
Write-Output " ---"
python -m venv venv
. .\venv\Scripts\Activate.ps1
Expand Down
2 changes: 1 addition & 1 deletion install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ python -m pip install --upgrade pip
python -m pip install wheel
#if [ "$INSTALL_PYTHON_VERSION" = "3.8" ]; then
# This remains in case there is a diversion of binary wheels
python -m pip install --extra-index-url https://pypi.chia.net/simple/ miniupnpc==2.1
python -m pip install --extra-index-url https://pypi.chia.net/simple/ miniupnpc==2.2.2
python -m pip install -e . --extra-index-url https://pypi.chia.net/simple/

echo ""
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
]

upnp_dependencies = [
"miniupnpc==2.1", # Allows users to open ports on their router
"miniupnpc==2.2.2", # Allows users to open ports on their router
]

dev_dependencies = [
Expand Down

0 comments on commit dc78116

Please sign in to comment.