Version 1.2.0 #16
Merged
Version 1.2.0 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major update
|
I'll test it later today 😉 I need 😴 💤 |
dymanoid
reviewed
Mar 6, 2020
DuplicateAssemblyScanner/DuplicateAssemblyScanner/Util/MemberValue.cs
Outdated
Show resolved
Hide resolved
DuplicateAssemblyScanner/DuplicateAssemblyScanner/Util/MemberValue.cs
Outdated
Show resolved
Hide resolved
|
As a general note regarding your git commits. Consider reading this great blog post about the git commit messages. I'd even recommend to publish a link to this in your contribution guide. The blog post explains how to make your git history readable and clean.
|
In `Release` builds, constant TRACE is not wanted. Replace it with RELEASE. References do not specify assembly version, public key, etc. Add that detail. The post-build script contains hard-coded paths and is somewhat opaque as to how the local C:SL folders are structured. Make use of macros and environment variables to generalise the script, and echo folder paths to build console as visual confirmation that the correct paths are being used.
dymanoid
reviewed
Mar 6, 2020
DuplicateAssemblyScanner/DuplicateAssemblyScanner/DuplicateAssemblyScanner.csproj
Show resolved
Hide resolved
dymanoid
reviewed
Mar 6, 2020
DuplicateAssemblyScanner/DuplicateAssemblyScanner/DuplicateAssemblyScanner.csproj
Outdated
Show resolved
Hide resolved
`MangedDLLPath` should be `ManagedDllPath`.
ModAssembly is a class, not a struct. The Structs folder is no longer required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major update:
Fixes #18 - log should show num occurrences of assembly
Fixes #14 - struct for mod + assembly info
Fixes #13 - refactoring folders + classes
Fixes #12 - log MD5 of assemblies
Fixes #11 - indicate if assembly is loaded, indicate if mod is enabled
Fixes #10 - show detailed results in mod options screen
Fixes #9 - scan mod folder if it's
PluginInfodoesn't list the assembly