Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Edit] CSS [Edit] CSS: Filter Functions .saturate() #4876

Merged
merged 9 commits into from
Jul 4, 2024
Merged

[Edit] CSS [Edit] CSS: Filter Functions .saturate() #4876

merged 9 commits into from
Jul 4, 2024

Conversation

chrisleond11
Copy link
Contributor

Description

  • Added output image to the example in .saturate() term from CSS: Filter Functions
  • Added the corresponding image to media folder

Minor Changes:

  • Edited the description for .saturate()
  • Edited the examples for <value> and its note

Issue Solved

Type of Change

  • Editing an existing entry (fixing a typo, bug, issues, etc)

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Jul 3, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mamtawardhani mamtawardhani self-assigned this Jul 3, 2024
@mamtawardhani mamtawardhani added enhancement New feature or request css CSS entries status: under review Issue or PR is currently being reviewed labels Jul 3, 2024
mamtawardhani
mamtawardhani requested changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to the Codecademy Docs @chrisleond11, the entry is nicely written! 😃

I've requested just one recheck with this entry, can you review and modify that at your earliest convenience? Thank you! 😄

content/css/concepts/filter-functions/terms/saturate/saturate.md Outdated
Comment on lines 27 to 28
- Number value: `0`, `0.5`, `1.0`, `1.5`
- Percentage value: `0%`, `50%`, `100%`, `150%`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you recheck this once, because I guess the saturate() can take any value and is not limited to these 4 values only?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankyou for the feedback! I've revised the explanation for the saturate() value. Please check it out, and let me know if there's anything else.

@mamtawardhani
Copy link
Collaborator

Hey @chrisleond11, it seems like the content/postgresql/concepts/operators/operators.md is on the same branch as the saturate.md file. Could you please remove the operators.md file from this branch?

@chrisleond11
Copy link
Contributor Author

Hey @chrisleond11, it seems like the content/postgresql/concepts/operators/operators.md is on the same branch as the saturate.md file. Could you please remove the operators.md file from this branch?

Sorry about that, not sure where did I go wrong. I have removed operators.md. Please check it again.

mamtawardhani
mamtawardhani approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for a second round of review! 🚀

Thank you @chrisleond11 for your contribution! 😃

@mamtawardhani
Copy link
Collaborator

@Sriparno08 assigning it to, could you please review this? I was slightly unsure about the values used in the entry, but now that the author has reframed those, it makes sense. You can review and provide feedback (if any). Thank you!

@Sriparno08
Copy link
Collaborator

Sure, @mamtawardhani! I'll take a look.

Sriparno08
Sriparno08 approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @chrisleond11! 👍

@Sriparno08 Sriparno08 merged commit 6f0c4ff into Codecademy:main Jul 4, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

👋 @chrisleond11
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/css/filter-functions/saturate

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

@Sriparno08 Sriparno08 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Jul 4, 2024
@chrisleond11
Copy link
Contributor Author

Thankyou @mamtawardhani and @Sriparno08, for assisting me on my first issue!

If it's okay, could I please request feedback on my work. I'd appreciate any insights on things that could be improved, or mistakes to avoid in my future work.

Thankyou in advance!

@Sriparno08
Copy link
Collaborator

Sriparno08 commented Jul 5, 2024 •
edited
Loading

Hey @chrisleond11, you did a good job. In my opinion:

  1. Go through the modifications that were made to the entry
  2. Ensure that you follow the term entry template, content standards, and markdown style guide when working on a PR in the future.

Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamtawardhani mamtawardhani mamtawardhani approved these changes

@Sriparno08 Sriparno08 Sriparno08 approved these changes

Assignees

@mamtawardhani mamtawardhani

@Sriparno08 Sriparno08

Labels
css CSS entries enhancement New feature or request status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Edit] CSS [Edit] CSS: Filter Functions saturate
4 participants
@chrisleond11 @CLAassistant @mamtawardhani @Sriparno08