Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items.update() missing from latest PyPI build #37

Closed
jakewalker-codes opened this issue Feb 17, 2023 · 3 comments
Closed

Items.update() missing from latest PyPI build #37

jakewalker-codes opened this issue Feb 17, 2023 · 3 comments

Comments

@jakewalker-codes
Copy link

Hi

The Items() class is missing the update() method in the

image

I had a look at the OSRSBytes library thats installed in my virtual environment and it's missing the update method:

image

The Items.py file in the main and dev branch all have this method though and adding the snippet from the repo to the Items.py file in my virtual environment fixed this issue.

I installed the OSRSBytes library by running the pip install command

upgrading, uninstalling and reinstalling using pip did not fix the issue

I am running version 1.3.0 of OSRSBytes

Thanks,

@Coffee-fueled-deadlines
Copy link
Owner

Correct. I believe at some point Dev got merged into Master unintentionally. Update() will be added in the 1.3.1 release. In addition, an easy work around would be to just initialize Items() again as such:

i = Items()

# do some stuff
i.isMembers("rune dagger")

# update items again
i = Items()

@jakewalker-codes
Copy link
Author

Thanks for your speedy response! :)

@Coffee-fueled-deadlines
Copy link
Owner

Not a problem, thank you for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants