Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single-precision support is broken #5

Open
KGHustad opened this issue Feb 19, 2020 · 0 comments
Open

Single-precision support is broken #5

KGHustad opened this issue Feb 19, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@KGHustad
Copy link
Contributor

The support for using single-precision floating-point numbers is not working correctly in C, C++, CUDA, and OpenCL.

Single-precision variants of mathematical functions are not used

In C/C++, exp, log, sqrt are used instead of expf, logf, sqrtf.

Double-precision literals can sneak into the code, causing implicit casts to double-precision.

Double-precision floating-point literals can sneak into the code from modelparameters.

This issue is probably hard to fix without a major rewrite of gotran or applying some very ugly fixes to the final code.

@KGHustad KGHustad added the bug Something isn't working label Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant