Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display improvements #195

Open
1 of 2 tasks
DOBEN opened this issue Dec 13, 2022 · 1 comment
Open
1 of 2 tasks

Display improvements #195

DOBEN opened this issue Dec 13, 2022 · 1 comment
Labels
good first issue Good for newcomers [Type] Bug Something isn't working

Comments

@DOBEN
Copy link
Member

DOBEN commented Dec 13, 2022

Description

  • Singular use if only one event is found, e.g.
    ./concordium-client transaction status b6cd9cb0c281d90cd5e9e82f1171b7b6ca7ec6bab12e2b9d48d4224e91434faf (testnet)

  • Add dot after the expression since all other expressions also have a dot, e.g.
    ./concordium-client transaction status fcdfd6fbcb2e1b47d22918edf8f701805a92b84cdb647d4061480cf765a8c381 (testnet)
    Screenshot from 2022-12-13 14-23-57
    Screenshot from 2022-12-13 14-46-40

@DOBEN DOBEN added the [Type] Change Request Some visible functionality should be change. label Dec 13, 2022
@abizjak abizjak added good first issue Good for newcomers [Type] Bug Something isn't working and removed [Type] Change Request Some visible functionality should be change. labels Dec 13, 2022
@DOBEN DOBEN mentioned this issue Apr 11, 2024
@DOBEN
Copy link
Member Author

DOBEN commented Sep 18, 2024

Regarding the second bulletpoint, there is a function that might help streamline expressions/punctuation but the initial investigation seems there is more work to do to make the expressions/punctuation consistent.

-- | Ensure that a string is printable as a sentence by converting the first letter to upper case
--  and, unless it already ends with "standard" punctuation, appending the provided punctionation.
prettyMsg :: String -> String -> String
prettyMsg punctuation = \case
    "" -> ""
    (x : xs) ->
        let s =
                if null xs || last xs `elem` p
                    then xs
                    else xs ++ punctuation
        in  (C.toUpper x) : s
  where
    p = ".,:;?!{}" :: String

@rasmus-kirk rasmus-kirk removed their assignment Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants