Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update GKR references and write GKR specification #1280

Open
ivokub opened this issue Sep 17, 2024 · 0 comments
Open

docs: update GKR references and write GKR specification #1280

ivokub opened this issue Sep 17, 2024 · 0 comments
Labels
consolidate strengthen an existing feature doc

Comments

@ivokub
Copy link
Collaborator

ivokub commented Sep 17, 2024

From the audit report suggestions 1 and 2:

The academic reference to the GKR implementation should include correct and precise information. Our team identified the following instances within the reference paper [BSB22] that need updating:

  • In Figure 15 (p. 15): V_O(\rho) is not defined.
  • In Figure 15 (p. 15): The claim register claims is only defined in a comment. Type definition could be made more direct.
  • Definition B.2 (p. 14): The batch assignment should be defined for the specific cases of input and output gates.
  • In Figure 15 (p. 15): The call to miniProtocol2 should be on (v, claim').
  • Remark B.3 (p. 14): For the defining equation for B(v)(x) over K^n, the summation should be over the hypercube {0,1}^n.

Mitigation: We recommend updating the paper.

While an academic reference is a useful resource that developers and auditors can refer to, it does not serve the same purpose as a specification, which could contain more information about the extension field tower and be a necessary addition to this complex protocol.

Mitigation: We recommend considering writing a specification for Linea GKR.

@ivokub ivokub added consolidate strengthen an existing feature doc labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consolidate strengthen an existing feature doc
Projects
None yet
Development

No branches or pull requests

1 participant