Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: BSB22 commitment in Groth16 is not overloaded when running only the solver #504

Closed
ivokub opened this issue Mar 1, 2023 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@ivokub
Copy link
Collaborator

ivokub commented Mar 1, 2023

So the commitment hint uses proving key which the solver doesn't have access to. When we run the prover then the prover overloads the hint with a function which has access to the proving key and then the solver has access to it to generate the full witness.

However, when we only run solver (in fuzzer/assertions etc.), then we do not overload and because the dummy commitment panics, the solver returns error. But actually the circuit may be solvable.

@Tabaie, @gbotrel

@ivokub ivokub added the bug Something isn't working label Mar 1, 2023
@ivokub ivokub added this to the v0.9.0 milestone Mar 1, 2023
@ivokub ivokub changed the title bug: BSB22 commitment is not overloaded when running only the solver bug: BSB22 commitment in Groth16 is not overloaded when running only the solver Mar 1, 2023
@ivokub ivokub closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant