You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In test TestSolverConsistency for circuit commitCircuit we get test failures when checking commitment != 0. But when we use the small field (modulus 47), then the probability of commitment being randomly 0 is high and we hit it with high probability (and in practice as inputs are fixed).
We could build the commitment in test engine such that we avoid 0 outputs, but that would be cheating. I would rather omit running consistency test for this circuit. But the consistency test uses all integration tests, so we need to have some option to avoid running some of the tests for some circuits. This is also useful for some other edge cases (imo there was also some issue with some other circuits where we have hardcoded which ones do avoid).
The text was updated successfully, but these errors were encountered:
Description
In test TestSolverConsistency for circuit commitCircuit we get test failures when checking
commitment != 0
. But when we use the small field (modulus 47), then the probability of commitment being randomly 0 is high and we hit it with high probability (and in practice as inputs are fixed).Expected Behavior
TestSolverConsistency/commit succeeds
Actual Behavior
It doesnt:
Possible Fix
We could build the commitment in test engine such that we avoid 0 outputs, but that would be cheating. I would rather omit running consistency test for this circuit. But the consistency test uses all integration tests, so we need to have some option to avoid running some of the tests for some circuits. This is also useful for some other edge cases (imo there was also some issue with some other circuits where we have hardcoded which ones do avoid).
The text was updated successfully, but these errors were encountered: