Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: GUI STOP button should immediately abort transfer #761

Closed
Tracked by #776
ND2W opened this issue Aug 8, 2024 · 5 comments · Fixed by #776
Closed
Tracked by #776

[Feature Request]: GUI STOP button should immediately abort transfer #761

ND2W opened this issue Aug 8, 2024 · 5 comments · Fixed by #776
Assignees
Labels

Comments

@ND2W
Copy link

ND2W commented Aug 8, 2024

Problem Description

The STOP button in the GUI does not end the transfer right away. Instead FD tries to inform the other station that the transfer was stopped by the sending stations operator. FD will continue sending and sometimes it appears as if FD and the radio get stuck in transmit mode which could potentially damage the radio. The only way to stop it is to shut down the FD server.

This behavior can be problematic when one has to shut down the rig immediately. Also, if the path disappeared it will be impossible to let the other station know that the transfer was aborted.

Proposed Solution

As soon as the STOP button is pressed, FD should immediately stop sending. The other station will eventually timeout and no longer wait for new packets. The timeout period on the receiving stations end could be reduced to a reasonable amount (e.g. 20 seconds).

In addition, the STOP button should show a pop-up that asks the user if they really want to abort the transfer. This will prevent a user from accidentially aborting their transfer if they happen to click on the STOP button by mistake.

Alternatives Considered

N/A

Additional Information

No response

@DJ2LS
Copy link
Owner

DJ2LS commented Aug 10, 2024

Suggestion:
The button opens a popup, requesting additional check, then stopping transmission

@DJ2LS
Copy link
Owner

DJ2LS commented Aug 10, 2024

@LA3QMA @deejdeej @Mashintime @dk5sm your opinion regarding to this?

@LA3QMA
Copy link
Collaborator

LA3QMA commented Aug 10, 2024

I see the need to stop a transmission. Either to stop occupy the frequency or if there are an issue with the radio/swr etc.

So if its not much extra work adding a popup to verify that you want to terminate I would say this should be implemented.

But i would suggest that FD transmit ONE package if the channel is free before going QRT to the remote station telling it that we have stopped transmission. Then if the receiving station get this it would also stop. If not its just going to send retries.

So yes to a popup to verify the STOP but send one "STOP" packet to the remote station.

@deejdeej
Copy link
Collaborator

"As soon as the STOP button is pressed, FD should immediately stop sending" Yes, definitely. I would not have a popup at all, just stop transmission immediately. If I'm pressing the stop button, it is very likely because there is an issue like a high SWR and I want the radio to stop NOW, not wait for a pop-up, and not send another transmission. I consider "stop" to be essentially "emergency stop".

@DJ2LS DJ2LS added the approved label Aug 10, 2024
@DJ2LS
Copy link
Owner

DJ2LS commented Aug 10, 2024

I implemented a first version in develop. At least it's a bit tricky, as we need two ways of stopping - one immediately and one with closing procedure.

We might add a popup for informing the user, the "stop button" has been clicked, also informing then about a possible delay before a connection the same station can be established again as it has to timeout first.

@DJ2LS DJ2LS mentioned this issue Aug 23, 2024
6 tasks
@DJ2LS DJ2LS linked a pull request Aug 31, 2024 that will close this issue
6 tasks
@DJ2LS DJ2LS self-assigned this Sep 8, 2024
@DJ2LS DJ2LS closed this as completed in #776 Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants