Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finished ORex MapCam Implementation #13

Closed
1 of 3 tasks
jlaura opened this issue Feb 6, 2018 · 4 comments
Closed
1 of 3 tasks

Finished ORex MapCam Implementation #13

jlaura opened this issue Feb 6, 2018 · 4 comments
Assignees

Comments

@jlaura
Copy link
Collaborator

jlaura commented Feb 6, 2018

  • Determine if the MapCam can utilize the generic framer
  • Implement if necessary
  • Generate tests
@jessemapel jessemapel self-assigned this Feb 23, 2018
@jessemapel
Copy link
Contributor

Based on the ISIS3 camera model, there is nothing unusual about the mapcam. The generic framing camera model should work if we can generate an ISD for it.

@jessemapel
Copy link
Contributor

jessemapel commented Feb 23, 2018

Nevermind, current framer implementation uses x, y polynomial distortion. ORex MapCam and PolyCam define their distortion radially. We also have to account for differences between camera boresight and distortion center. See the end of this IK
https://naif.jpl.nasa.gov/pub/naif/ORX/kernels/ik/orx_ocams_v06.ti

@jessemapel
Copy link
Contributor

It's also going to require a new system for computing distorted coordinates from undistorted coordinates. Computing the jacobian of radial distortion is clunky and odd. It makes more sense to work purely along the radii. See https://github.com/USGS-Astrogeology/ISIS3/blob/dev/isis/src/osirisrex/objs/OsirisRexOcamsCamera/OsirisRexOcamsCamera.cpp

@jlaura jlaura added this to To do in CSM via automation Jun 29, 2018
@jlaura jlaura moved this from To do to Backlog in CSM Jun 29, 2018
@jlaura
Copy link
Collaborator Author

jlaura commented Sep 5, 2018

This will be covered by #24

@jlaura jlaura closed this as completed Sep 5, 2018
CSM automation moved this from Backlog to Done Sep 5, 2018
@emartinez-usgs emartinez-usgs removed this from Done in CSM Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants