Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run a linter over the code / normalize coding standards #304

Open
kberryUSGS opened this issue Jul 22, 2020 · 3 comments
Open

Run a linter over the code / normalize coding standards #304

kberryUSGS opened this issue Jul 22, 2020 · 3 comments
Assignees

Comments

@kberryUSGS
Copy link
Contributor

kberryUSGS commented Jul 22, 2020

Different numbers of spaces are used for indents, different curly-brace placements are used, snake_case vs. camelCase, etc... throughout the code.

@kberryUSGS
Copy link
Contributor Author

Also, for exception error message variable names, we seem to alternate between msg, message, aMessage, etc... might as well use the same name.

@kberryUSGS
Copy link
Contributor Author

Still needed: say in the README or contributing that we use the google style guide.

@oleg-alexandrov
Copy link
Collaborator

If linter checks are enabled, also a program should be provided to fix linter errors, such as clang-format-8, with a hook at commit time (the user installs the program separately and the git hook calls it). Or else developing code can be a very annoying affair, with sometimes hundreds of trivial things to fix manually for each commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants