Skip to content

Commit

Permalink
[PATCH] rcu: add rcu_sync torture type to rcutorture
Browse files Browse the repository at this point in the history
Use the newly-generic synchronous deferred free function to implement torture
testing for RCU using synchronize_rcu rather than the asynchronous call_rcu.

Signed-off-by: Josh Triplett <josh@freedesktop.org>
Acked-by: Paul E. McKenney <paulmck@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Josh Triplett authored and Linus Torvalds committed Oct 4, 2006
1 parent e303373 commit 20d2e42
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 5 deletions.
7 changes: 4 additions & 3 deletions Documentation/RCU/torture.txt
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,10 @@ test_no_idle_hz Whether or not to test the ability of RCU to operate in
a kernel that disables the scheduling-clock interrupt to
idle CPUs. Boolean parameter, "1" to test, "0" otherwise.

torture_type The type of RCU to test: "rcu" for the rcu_read_lock()
API, "rcu_bh" for the rcu_read_lock_bh() API, and "srcu"
for the "srcu_read_lock()" API.
torture_type The type of RCU to test: "rcu" for the rcu_read_lock() API,
"rcu_sync" for rcu_read_lock() with synchronous reclamation,
"rcu_bh" for the rcu_read_lock_bh() API, and "srcu" for the
"srcu_read_lock()" API.

verbose Enable debug printk()s. Default is disabled.

Expand Down
17 changes: 15 additions & 2 deletions kernel/rcutorture.c
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ static int stat_interval; /* Interval between stats, in seconds. */
static int verbose; /* Print more debug info. */
static int test_no_idle_hz; /* Test RCU's support for tickless idle CPUs. */
static int shuffle_interval = 5; /* Interval between shuffles (in sec)*/
static char *torture_type = "rcu"; /* What to torture: rcu, rcu_bh, srcu. */
static char *torture_type = "rcu"; /* What RCU implementation to torture. */

module_param(nreaders, int, 0);
MODULE_PARM_DESC(nreaders, "Number of RCU reader threads");
Expand Down Expand Up @@ -297,6 +297,19 @@ static void rcu_sync_torture_init(void)
INIT_LIST_HEAD(&rcu_torture_removed);
}

static struct rcu_torture_ops rcu_sync_ops = {
.init = rcu_sync_torture_init,
.cleanup = NULL,
.readlock = rcu_torture_read_lock,
.readdelay = rcu_read_delay,
.readunlock = rcu_torture_read_unlock,
.completed = rcu_torture_completed,
.deferredfree = rcu_sync_torture_deferred_free,
.sync = synchronize_rcu,
.stats = NULL,
.name = "rcu_sync"
};

/*
* Definitions for rcu_bh torture testing.
*/
Expand Down Expand Up @@ -439,7 +452,7 @@ static struct rcu_torture_ops srcu_ops = {
};

static struct rcu_torture_ops *torture_ops[] =
{ &rcu_ops, &rcu_bh_ops, &srcu_ops, NULL };
{ &rcu_ops, &rcu_sync_ops, &rcu_bh_ops, &srcu_ops, NULL };

/*
* RCU torture writer kthread. Repeatedly substitutes a new structure
Expand Down

0 comments on commit 20d2e42

Please sign in to comment.