Skip to content

Commit

Permalink
NFC: nci: rename nci_prop_ops to nci_driver_ops
Browse files Browse the repository at this point in the history
Initially it was used to create hooks in the driver for
proprietary operations. Currently it is being used for hooks
for both proprietary and generic operations.

Signed-off-by: Robert Dolca <robert.dolca@intel.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
  • Loading branch information
Robert Dolca authored and Samuel Ortiz committed Oct 25, 2015
1 parent 0a97a3c commit 22e4bd0
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 15 deletions.
4 changes: 2 additions & 2 deletions drivers/nfc/s3fwrn5/nci.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ static int s3fwrn5_nci_prop_rsp(struct nci_dev *ndev, struct sk_buff *skb)
return 0;
}

static struct nci_prop_ops s3fwrn5_nci_prop_ops[] = {
static struct nci_driver_ops s3fwrn5_nci_prop_ops[] = {
{
.opcode = nci_opcode_pack(NCI_GID_PROPRIETARY,
NCI_PROP_AGAIN),
Expand Down Expand Up @@ -79,7 +79,7 @@ static struct nci_prop_ops s3fwrn5_nci_prop_ops[] = {
},
};

void s3fwrn5_nci_get_prop_ops(struct nci_prop_ops **ops, size_t *n)
void s3fwrn5_nci_get_prop_ops(struct nci_driver_ops **ops, size_t *n)
{
*ops = s3fwrn5_nci_prop_ops;
*n = ARRAY_SIZE(s3fwrn5_nci_prop_ops);
Expand Down
2 changes: 1 addition & 1 deletion drivers/nfc/s3fwrn5/nci.h
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ struct nci_prop_fw_cfg_rsp {

#define NCI_PROP_WR_RESET 0x2f

void s3fwrn5_nci_get_prop_ops(struct nci_prop_ops **ops, size_t *n);
void s3fwrn5_nci_get_prop_ops(struct nci_driver_ops **ops, size_t *n);
int s3fwrn5_nci_rf_configure(struct s3fwrn5_info *info, const char *fw_name);

#endif /* __LOCAL_S3FWRN5_NCI_H_ */
2 changes: 1 addition & 1 deletion drivers/nfc/st-nci/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ static int st_nci_prop_rsp_packet(struct nci_dev *ndev,
return 0;
}

static struct nci_prop_ops st_nci_prop_ops[] = {
static struct nci_driver_ops st_nci_prop_ops[] = {
{
.opcode = nci_opcode_pack(NCI_GID_PROPRIETARY,
ST_NCI_CORE_PROP),
Expand Down
6 changes: 3 additions & 3 deletions include/net/nfc/nci_core.h
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ enum nci_state {

struct nci_dev;

struct nci_prop_ops {
struct nci_driver_ops {
__u16 opcode;
int (*rsp)(struct nci_dev *dev, struct sk_buff *skb);
int (*ntf)(struct nci_dev *dev, struct sk_buff *skb);
Expand All @@ -94,10 +94,10 @@ struct nci_ops {
void (*hci_cmd_received)(struct nci_dev *ndev, u8 pipe, u8 cmd,
struct sk_buff *skb);

struct nci_prop_ops *prop_ops;
struct nci_driver_ops *prop_ops;
size_t n_prop_ops;

struct nci_prop_ops *core_ops;
struct nci_driver_ops *core_ops;
size_t n_core_ops;
};

Expand Down
16 changes: 8 additions & 8 deletions net/nfc/nci/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1242,12 +1242,12 @@ int nci_send_cmd(struct nci_dev *ndev, __u16 opcode, __u8 plen, void *payload)
}

/* Proprietary commands API */
static struct nci_prop_ops *ops_cmd_lookup(struct nci_prop_ops *ops,
size_t n_ops,
__u16 opcode)
static struct nci_driver_ops *ops_cmd_lookup(struct nci_driver_ops *ops,
size_t n_ops,
__u16 opcode)
{
size_t i;
struct nci_prop_ops *op;
struct nci_driver_ops *op;

if (!ops || !n_ops)
return NULL;
Expand All @@ -1262,10 +1262,10 @@ static struct nci_prop_ops *ops_cmd_lookup(struct nci_prop_ops *ops,
}

static int nci_op_rsp_packet(struct nci_dev *ndev, __u16 rsp_opcode,
struct sk_buff *skb, struct nci_prop_ops *ops,
struct sk_buff *skb, struct nci_driver_ops *ops,
size_t n_ops)
{
struct nci_prop_ops *op;
struct nci_driver_ops *op;

op = ops_cmd_lookup(ops, n_ops, rsp_opcode);
if (!op || !op->rsp)
Expand All @@ -1275,10 +1275,10 @@ static int nci_op_rsp_packet(struct nci_dev *ndev, __u16 rsp_opcode,
}

static int nci_op_ntf_packet(struct nci_dev *ndev, __u16 ntf_opcode,
struct sk_buff *skb, struct nci_prop_ops *ops,
struct sk_buff *skb, struct nci_driver_ops *ops,
size_t n_ops)
{
struct nci_prop_ops *op;
struct nci_driver_ops *op;

op = ops_cmd_lookup(ops, n_ops, ntf_opcode);
if (!op || !op->ntf)
Expand Down

0 comments on commit 22e4bd0

Please sign in to comment.