Skip to content

Commit

Permalink
NFS: Writeback optimisation
Browse files Browse the repository at this point in the history
Schedule writes using WB_SYNC_NONE first, then come back for a second pass
using WB_SYNC_ALL.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
  • Loading branch information
Trond Myklebust authored and Trond Myklebust committed Oct 9, 2007
1 parent ed90ef5 commit 34901f7
Showing 1 changed file with 22 additions and 10 deletions.
32 changes: 22 additions & 10 deletions fs/nfs/write.c
Original file line number Diff line number Diff line change
Expand Up @@ -1325,21 +1325,14 @@ long nfs_sync_mapping_wait(struct address_space *mapping, struct writeback_contr
return ret;
}

static int nfs_write_mapping(struct address_space *mapping, int how)
static int __nfs_write_mapping(struct address_space *mapping, struct writeback_control *wbc, int how)
{
struct writeback_control wbc = {
.bdi = mapping->backing_dev_info,
.sync_mode = WB_SYNC_ALL,
.nr_to_write = LONG_MAX,
.for_writepages = 1,
.range_cyclic = 1,
};
int ret;

ret = nfs_writepages(mapping, &wbc);
ret = nfs_writepages(mapping, wbc);
if (ret < 0)
goto out;
ret = nfs_sync_mapping_wait(mapping, &wbc, how);
ret = nfs_sync_mapping_wait(mapping, wbc, how);
if (ret < 0)
goto out;
return 0;
Expand All @@ -1348,6 +1341,25 @@ static int nfs_write_mapping(struct address_space *mapping, int how)
return ret;
}

/* Two pass sync: first using WB_SYNC_NONE, then WB_SYNC_ALL */
static int nfs_write_mapping(struct address_space *mapping, int how)
{
struct writeback_control wbc = {
.bdi = mapping->backing_dev_info,
.sync_mode = WB_SYNC_NONE,
.nr_to_write = LONG_MAX,
.for_writepages = 1,
.range_cyclic = 1,
};
int ret;

ret = __nfs_write_mapping(mapping, &wbc, how);
if (ret < 0)
return ret;
wbc.sync_mode = WB_SYNC_ALL;
return __nfs_write_mapping(mapping, &wbc, how);
}

/*
* flush the inode to disk.
*/
Expand Down

0 comments on commit 34901f7

Please sign in to comment.