Skip to content

Commit

Permalink
aio: fix misleading comments
Browse files Browse the repository at this point in the history
The FIXME comments are inaccurate.
The locking comment over lookup_ioctx() is wrong.

Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Zach Brown <zach.brown@oracle.com>
Signed-off-by: Shen Feng <shen@cn.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
JeffMoyer authored and torvalds committed Apr 29, 2008
1 parent 68ab3d8 commit 39fa003
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions fs/aio.c
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ static struct kioctx *ioctx_alloc(unsigned nr_events)
if (ctx->max_reqs == 0)
goto out_cleanup;

/* now link into global list. kludge. FIXME */
/* now link into global list. */
write_lock(&mm->ioctx_list_lock);
ctx->next = mm->ioctx_list;
mm->ioctx_list = ctx;
Expand Down Expand Up @@ -553,9 +553,6 @@ int aio_put_req(struct kiocb *req)
return ret;
}

/* Lookup an ioctx id. ioctx_list is lockless for reads.
* FIXME: this is O(n) and is only suitable for development.
*/
static struct kioctx *lookup_ioctx(unsigned long ctx_id)
{
struct kioctx *ioctx;
Expand Down

0 comments on commit 39fa003

Please sign in to comment.