Skip to content

Commit

Permalink
mfd: Add missing regmap_exit to free a previously allocated da9052 re…
Browse files Browse the repository at this point in the history
…gister map

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
  • Loading branch information
AxelLin authored and Samuel Ortiz committed Mar 6, 2012
1 parent d48f411 commit 4d75dd6
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
7 changes: 5 additions & 2 deletions drivers/mfd/da9052-i2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,16 @@ static int __devinit da9052_i2c_probe(struct i2c_client *client,

ret = da9052_i2c_enable_multiwrite(da9052);
if (ret < 0)
goto err;
goto err_regmap;

ret = da9052_device_init(da9052, id->driver_data);
if (ret != 0)
goto err;
goto err_regmap;

return 0;

err_regmap:
regmap_exit(da9052->regmap);
err:
kfree(da9052);
return ret;
Expand All @@ -92,6 +94,7 @@ static int da9052_i2c_remove(struct i2c_client *client)
struct da9052 *da9052 = i2c_get_clientdata(client);

da9052_device_exit(da9052);
regmap_exit(da9052->regmap);
kfree(da9052);

return 0;
Expand Down
5 changes: 4 additions & 1 deletion drivers/mfd/da9052-spi.c
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,12 @@ static int da9052_spi_probe(struct spi_device *spi)

ret = da9052_device_init(da9052, id->driver_data);
if (ret != 0)
goto err;
goto err_regmap;

return 0;

err_regmap:
regmap_exit(da9052->regmap);
err:
kfree(da9052);
return ret;
Expand All @@ -66,6 +68,7 @@ static int da9052_spi_remove(struct spi_device *spi)
struct da9052 *da9052 = dev_get_drvdata(&spi->dev);

da9052_device_exit(da9052);
regmap_exit(da9052->regmap);
kfree(da9052);

return 0;
Expand Down

0 comments on commit 4d75dd6

Please sign in to comment.