Skip to content

Commit

Permalink
[CONNECTOR]: Fix warning in cn_queue.c
Browse files Browse the repository at this point in the history
cn_queue.c:130: warning: value computed is not used

There is no point in testing the atomic value if the result is thrown
away.

From Evgeniy:

It was created to put implicit smp barrier, but it is not needed there.

Signed-off-by: Andreas Schwab <schwab@suse.de>
Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
andreas-schwab authored and David S. Miller committed Jun 18, 2006
1 parent f86502b commit cec6f7f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/connector/cn_queue.c
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ void cn_queue_del_callback(struct cn_queue_dev *dev, struct cb_id *id)

if (found) {
cn_queue_free_callback(cbq);
atomic_dec_and_test(&dev->refcnt);
atomic_dec(&dev->refcnt);
}
}

Expand Down

0 comments on commit cec6f7f

Please sign in to comment.