Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API_HOST should be manipulated as an URL and not as a string #411

Closed
octplane opened this issue Jun 25, 2019 · 1 comment · Fixed by #419
Closed

API_HOST should be manipulated as an URL and not as a string #411

octplane opened this issue Jun 25, 2019 · 1 comment · Fixed by #419

Comments

@octplane
Copy link
Contributor

This creates errors when changing the host to something with a trailing /

datadogpy/datadog/api/api_client.py

Line 121 in 7fb486f

url = "{api_host}/api/{api_version}/{path}".format(

@dabcoder
Copy link
Contributor

dabcoder commented Jul 29, 2019 •
edited
Loading

Example if api_host is set to api.datadoghq.com/, it will result in a double //: api.datadoghq.com//api/....

@dabcoder dabcoder mentioned this issue Aug 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Treat API_HOST as URL dabcoder/datadogpy
2 participants
@octplane @dabcoder