From 501bd8f463dd9cd808630f31179e8290b44a3f7d Mon Sep 17 00:00:00 2001 From: Lucille Delisle Date: Tue, 1 Nov 2022 23:02:09 +0100 Subject: [PATCH 1/4] remove deprecated set-output syntax --- .github/workflows/ci.yaml | 8 ++++---- .github/workflows/pr.yaml | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 78202ae9b66..f9c6aaa0d76 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -37,12 +37,12 @@ jobs: id: get-fork-branch run: | TMP="${{ github.event.client_payload.slash_command.args.named.fork }}" - echo "::set-output name=fork::${TMP:-$GALAXY_FORK}" + echo "fork=${TMP:-$GALAXY_FORK}" >> $GITHUB_OUTPUT TMP="${{ github.event.client_payload.slash_command.args.named.branch }}" - echo "::set-output name=branch::${TMP:-$GALAXY_BRANCH}" + echo "branch=${TMP:-$GALAXY_BRANCH}" >> $GITHUB_OUTPUT - name: Determine latest commit in the Galaxy repo id: get-galaxy-sha - run: echo "::set-output name=galaxy-head-sha::$(git ls-remote https://github.com/${{ steps.get-fork-branch.outputs.fork }}/galaxy refs/heads/${{ steps.get-fork-branch.outputs.branch }} | cut -f1)" + run: echo "galaxy-head-sha=$(git ls-remote https://github.com/${{ steps.get-fork-branch.outputs.fork }}/galaxy refs/heads/${{ steps.get-fork-branch.outputs.branch }} | cut -f1)" >> $GITHUB_OUTPUT - uses: actions/setup-python@v4 with: python-version: ${{ matrix.python-version }} @@ -169,7 +169,7 @@ jobs: - name: Create URL to the run output if: ${{ github.event.client_payload.slash_command.command == 'run-all-tool-tests' }} id: vars - run: echo "::set-output name=run-url::https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID" + run: echo "run-url=https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID" >> $GITHUB_OUTPUT - name: Create comment if: ${{ github.event.client_payload.slash_command.command == 'run-all-tool-tests' }} diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index 39bfff52d22..be48eceab08 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -43,7 +43,7 @@ jobs: echo 'event.after: ${{ github.event.after }}' - name: Determine latest commit in the Galaxy repo id: get-galaxy-sha - run: echo "::set-output name=galaxy-head-sha::$(git ls-remote https://github.com/${{ env.GALAXY_FORK }}/galaxy refs/heads/${{ env.GALAXY_BRANCH }} | cut -f1)" + run: echo "galaxy-head-sha=$(git ls-remote https://github.com/${{ env.GALAXY_FORK }}/galaxy refs/heads/${{ env.GALAXY_BRANCH }} | cut -f1)" >> $GITHUB_OUTPUT - uses: actions/setup-python@v4 with: python-version: ${{ matrix.python-version }} From 2e06a1e5e0ff0fe46c0391eb8953bb0cdd8f2d7b Mon Sep 17 00:00:00 2001 From: Lucille Delisle Date: Tue, 1 Nov 2022 23:18:38 +0100 Subject: [PATCH 2/4] use last version of create-or-update-comment to avoid deprecation warning about node version --- .github/workflows/ci.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index f9c6aaa0d76..8bccc1c1aca 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -27,7 +27,7 @@ jobs: steps: - name: Add reaction if: ${{ github.event.client_payload.slash_command.command == 'run-all-tool-tests' }} - uses: peter-evans/create-or-update-comment@v1 + uses: peter-evans/create-or-update-comment@v2.1.0 with: token: ${{ secrets.PAT }} repository: ${{ github.event.client_payload.github.payload.repository.full_name }} @@ -173,7 +173,7 @@ jobs: - name: Create comment if: ${{ github.event.client_payload.slash_command.command == 'run-all-tool-tests' }} - uses: peter-evans/create-or-update-comment@v1 + uses: peter-evans/create-or-update-comment@v2.1.0 with: token: ${{ secrets.PAT }} repository: ${{ github.event.client_payload.github.payload.repository.full_name }} From 37ca312df4831ad52f953f5c5d767b024f0662de Mon Sep 17 00:00:00 2001 From: Lucille Delisle Date: Tue, 1 Nov 2022 23:36:13 +0100 Subject: [PATCH 3/4] upgrade slash-command-dispatch --- .github/workflows/slash.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/slash.yaml b/.github/workflows/slash.yaml index 664d53916cd..cdf25e26f6a 100644 --- a/.github/workflows/slash.yaml +++ b/.github/workflows/slash.yaml @@ -8,7 +8,7 @@ jobs: steps: - name: Slash Command Dispatch if: github.repository_owner == 'galaxyproject' - uses: peter-evans/slash-command-dispatch@v2 + uses: peter-evans/slash-command-dispatch@v3.0.1 with: token: ${{ secrets.PAT }} commands: | From b0bb5703b373f6ab06fc4649b6258d6ff532ef9b Mon Sep 17 00:00:00 2001 From: Lucille Delisle Date: Wed, 2 Nov 2022 12:52:24 +0100 Subject: [PATCH 4/4] Do not use subversions in github actions Co-authored-by: Nicola Soranzo --- .github/workflows/ci.yaml | 4 ++-- .github/workflows/slash.yaml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 8bccc1c1aca..cd46f200773 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -27,7 +27,7 @@ jobs: steps: - name: Add reaction if: ${{ github.event.client_payload.slash_command.command == 'run-all-tool-tests' }} - uses: peter-evans/create-or-update-comment@v2.1.0 + uses: peter-evans/create-or-update-comment@v2 with: token: ${{ secrets.PAT }} repository: ${{ github.event.client_payload.github.payload.repository.full_name }} @@ -173,7 +173,7 @@ jobs: - name: Create comment if: ${{ github.event.client_payload.slash_command.command == 'run-all-tool-tests' }} - uses: peter-evans/create-or-update-comment@v2.1.0 + uses: peter-evans/create-or-update-comment@v2 with: token: ${{ secrets.PAT }} repository: ${{ github.event.client_payload.github.payload.repository.full_name }} diff --git a/.github/workflows/slash.yaml b/.github/workflows/slash.yaml index cdf25e26f6a..838257cbb0c 100644 --- a/.github/workflows/slash.yaml +++ b/.github/workflows/slash.yaml @@ -8,7 +8,7 @@ jobs: steps: - name: Slash Command Dispatch if: github.repository_owner == 'galaxyproject' - uses: peter-evans/slash-command-dispatch@v3.0.1 + uses: peter-evans/slash-command-dispatch@v3 with: token: ${{ secrets.PAT }} commands: |