forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
/
root_view_unittest.cc
789 lines (643 loc) · 29.1 KB
/
root_view_unittest.cc
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ui/views/widget/root_view.h"
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "build/build_config.h"
#include "ui/events/event_utils.h"
#include "ui/events/keycodes/dom/dom_code.h"
#include "ui/views/context_menu_controller.h"
#include "ui/views/test/views_test_base.h"
#include "ui/views/view_targeter.h"
#include "ui/views/widget/root_view.h"
#include "ui/views/widget/widget_deletion_observer.h"
#include "ui/views/window/dialog_delegate.h"
namespace views {
namespace test {
using RootViewTest = ViewsTestBase;
class DeleteOnKeyEventView : public View {
public:
explicit DeleteOnKeyEventView(bool* set_on_key) : set_on_key_(set_on_key) {}
~DeleteOnKeyEventView() override = default;
bool OnKeyPressed(const ui::KeyEvent& event) override {
*set_on_key_ = true;
delete this;
return true;
}
private:
// Set to true in OnKeyPressed().
bool* set_on_key_;
DISALLOW_COPY_AND_ASSIGN(DeleteOnKeyEventView);
};
// Verifies deleting a View in OnKeyPressed() doesn't crash and that the
// target is marked as destroyed in the returned EventDispatchDetails.
TEST_F(RootViewTest, DeleteViewDuringKeyEventDispatch) {
Widget widget;
Widget::InitParams init_params =
CreateParams(Widget::InitParams::TYPE_WINDOW_FRAMELESS);
init_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
widget.Init(init_params);
widget.Show();
bool got_key_event = false;
View* content = new View;
widget.SetContentsView(content);
View* child = new DeleteOnKeyEventView(&got_key_event);
content->AddChildView(child);
// Give focus to |child| so that it will be the target of the key event.
child->SetFocusBehavior(View::FocusBehavior::ALWAYS);
child->RequestFocus();
internal::RootView* root_view =
static_cast<internal::RootView*>(widget.GetRootView());
ViewTargeter* view_targeter = new ViewTargeter(root_view);
root_view->SetEventTargeter(base::WrapUnique(view_targeter));
ui::KeyEvent key_event(ui::ET_KEY_PRESSED, ui::VKEY_ESCAPE, ui::EF_NONE);
ui::EventDispatchDetails details = root_view->OnEventFromSource(&key_event);
EXPECT_TRUE(details.target_destroyed);
EXPECT_FALSE(details.dispatcher_destroyed);
EXPECT_TRUE(got_key_event);
}
// Tracks whether a context menu is shown.
class TestContextMenuController : public ContextMenuController {
public:
TestContextMenuController() = default;
~TestContextMenuController() override = default;
int show_context_menu_calls() const { return show_context_menu_calls_; }
View* menu_source_view() const { return menu_source_view_; }
ui::MenuSourceType menu_source_type() const { return menu_source_type_; }
void Reset() {
show_context_menu_calls_ = 0;
menu_source_view_ = nullptr;
menu_source_type_ = ui::MENU_SOURCE_NONE;
}
// ContextMenuController:
void ShowContextMenuForViewImpl(View* source,
const gfx::Point& point,
ui::MenuSourceType source_type) override {
show_context_menu_calls_++;
menu_source_view_ = source;
menu_source_type_ = source_type;
}
private:
int show_context_menu_calls_ = 0;
View* menu_source_view_ = nullptr;
ui::MenuSourceType menu_source_type_ = ui::MENU_SOURCE_NONE;
DISALLOW_COPY_AND_ASSIGN(TestContextMenuController);
};
// Tests that context menus are shown for certain key events (Shift+F10
// and VKEY_APPS) by the pre-target handler installed on RootView.
TEST_F(RootViewTest, ContextMenuFromKeyEvent) {
#if defined(OS_MACOSX)
// This behavior is intentionally unsupported on macOS.
return;
#endif
Widget widget;
Widget::InitParams init_params =
CreateParams(Widget::InitParams::TYPE_WINDOW_FRAMELESS);
init_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
widget.Init(init_params);
widget.Show();
internal::RootView* root_view =
static_cast<internal::RootView*>(widget.GetRootView());
TestContextMenuController controller;
View* focused_view = new View;
focused_view->set_context_menu_controller(&controller);
widget.SetContentsView(focused_view);
focused_view->SetFocusBehavior(View::FocusBehavior::ALWAYS);
focused_view->RequestFocus();
// No context menu should be shown for a keypress of 'A'.
ui::KeyEvent nomenu_key_event('a', ui::VKEY_A, ui::DomCode::NONE,
ui::EF_NONE);
ui::EventDispatchDetails details =
root_view->OnEventFromSource(&nomenu_key_event);
EXPECT_FALSE(details.target_destroyed);
EXPECT_FALSE(details.dispatcher_destroyed);
EXPECT_EQ(0, controller.show_context_menu_calls());
EXPECT_EQ(nullptr, controller.menu_source_view());
EXPECT_EQ(ui::MENU_SOURCE_NONE, controller.menu_source_type());
controller.Reset();
// A context menu should be shown for a keypress of Shift+F10.
ui::KeyEvent menu_key_event(
ui::ET_KEY_PRESSED, ui::VKEY_F10, ui::EF_SHIFT_DOWN);
details = root_view->OnEventFromSource(&menu_key_event);
EXPECT_FALSE(details.target_destroyed);
EXPECT_FALSE(details.dispatcher_destroyed);
EXPECT_EQ(1, controller.show_context_menu_calls());
EXPECT_EQ(focused_view, controller.menu_source_view());
EXPECT_EQ(ui::MENU_SOURCE_KEYBOARD, controller.menu_source_type());
controller.Reset();
// A context menu should be shown for a keypress of VKEY_APPS.
ui::KeyEvent menu_key_event2(ui::ET_KEY_PRESSED, ui::VKEY_APPS, ui::EF_NONE);
details = root_view->OnEventFromSource(&menu_key_event2);
EXPECT_FALSE(details.target_destroyed);
EXPECT_FALSE(details.dispatcher_destroyed);
EXPECT_EQ(1, controller.show_context_menu_calls());
EXPECT_EQ(focused_view, controller.menu_source_view());
EXPECT_EQ(ui::MENU_SOURCE_KEYBOARD, controller.menu_source_type());
controller.Reset();
}
// View which handles all gesture events.
class GestureHandlingView : public View {
public:
GestureHandlingView() = default;
~GestureHandlingView() override = default;
void OnGestureEvent(ui::GestureEvent* event) override { event->SetHandled(); }
private:
DISALLOW_COPY_AND_ASSIGN(GestureHandlingView);
};
// Tests that context menus are shown for long press by the post-target handler
// installed on the RootView only if the event is targetted at a view which can
// show a context menu.
TEST_F(RootViewTest, ContextMenuFromLongPress) {
Widget widget;
Widget::InitParams init_params =
CreateParams(Widget::InitParams::TYPE_POPUP);
init_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
init_params.bounds = gfx::Rect(100, 100);
widget.Init(init_params);
internal::RootView* root_view =
static_cast<internal::RootView*>(widget.GetRootView());
// Create a view capable of showing the context menu with two children one of
// which handles all gesture events (e.g. a button).
TestContextMenuController controller;
View* parent_view = new View;
parent_view->set_context_menu_controller(&controller);
widget.SetContentsView(parent_view);
View* gesture_handling_child_view = new GestureHandlingView;
gesture_handling_child_view->SetBoundsRect(gfx::Rect(10, 10));
parent_view->AddChildView(gesture_handling_child_view);
View* other_child_view = new View;
other_child_view->SetBoundsRect(gfx::Rect(20, 0, 10, 10));
parent_view->AddChildView(other_child_view);
// |parent_view| should not show a context menu as a result of a long press on
// |gesture_handling_child_view|.
ui::GestureEvent long_press1(
5, 5, 0, base::TimeTicks(),
ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS));
ui::EventDispatchDetails details = root_view->OnEventFromSource(&long_press1);
ui::GestureEvent end1(5, 5, 0, base::TimeTicks(),
ui::GestureEventDetails(ui::ET_GESTURE_END));
details = root_view->OnEventFromSource(&end1);
EXPECT_FALSE(details.target_destroyed);
EXPECT_FALSE(details.dispatcher_destroyed);
EXPECT_EQ(0, controller.show_context_menu_calls());
controller.Reset();
// |parent_view| should show a context menu as a result of a long press on
// |other_child_view|.
ui::GestureEvent long_press2(
25, 5, 0, base::TimeTicks(),
ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS));
details = root_view->OnEventFromSource(&long_press2);
ui::GestureEvent end2(25, 5, 0, base::TimeTicks(),
ui::GestureEventDetails(ui::ET_GESTURE_END));
details = root_view->OnEventFromSource(&end2);
EXPECT_FALSE(details.target_destroyed);
EXPECT_FALSE(details.dispatcher_destroyed);
EXPECT_EQ(1, controller.show_context_menu_calls());
controller.Reset();
// |parent_view| should show a context menu as a result of a long press on
// itself.
ui::GestureEvent long_press3(
50, 50, 0, base::TimeTicks(),
ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS));
details = root_view->OnEventFromSource(&long_press3);
ui::GestureEvent end3(25, 5, 0, base::TimeTicks(),
ui::GestureEventDetails(ui::ET_GESTURE_END));
details = root_view->OnEventFromSource(&end3);
EXPECT_FALSE(details.target_destroyed);
EXPECT_FALSE(details.dispatcher_destroyed);
EXPECT_EQ(1, controller.show_context_menu_calls());
}
// Tests that context menus are not shown for disabled views on a long press.
TEST_F(RootViewTest, ContextMenuFromLongPressOnDisabledView) {
Widget widget;
Widget::InitParams init_params =
CreateParams(Widget::InitParams::TYPE_POPUP);
init_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
init_params.bounds = gfx::Rect(100, 100);
widget.Init(init_params);
internal::RootView* root_view =
static_cast<internal::RootView*>(widget.GetRootView());
// Create a view capable of showing the context menu with two children one of
// which handles all gesture events (e.g. a button). Also mark this view
// as disabled.
TestContextMenuController controller;
View* parent_view = new View;
parent_view->set_context_menu_controller(&controller);
parent_view->SetEnabled(false);
widget.SetContentsView(parent_view);
View* gesture_handling_child_view = new GestureHandlingView;
gesture_handling_child_view->SetBoundsRect(gfx::Rect(10, 10));
parent_view->AddChildView(gesture_handling_child_view);
View* other_child_view = new View;
other_child_view->SetBoundsRect(gfx::Rect(20, 0, 10, 10));
parent_view->AddChildView(other_child_view);
// |parent_view| should not show a context menu as a result of a long press on
// |gesture_handling_child_view|.
ui::GestureEvent long_press1(
5, 5, 0, base::TimeTicks(),
ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS));
ui::EventDispatchDetails details = root_view->OnEventFromSource(&long_press1);
ui::GestureEvent end1(5, 5, 0, base::TimeTicks(),
ui::GestureEventDetails(ui::ET_GESTURE_END));
details = root_view->OnEventFromSource(&end1);
EXPECT_FALSE(details.target_destroyed);
EXPECT_FALSE(details.dispatcher_destroyed);
EXPECT_EQ(0, controller.show_context_menu_calls());
controller.Reset();
// |parent_view| should not show a context menu as a result of a long press on
// |other_child_view|.
ui::GestureEvent long_press2(
25, 5, 0, base::TimeTicks(),
ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS));
details = root_view->OnEventFromSource(&long_press2);
ui::GestureEvent end2(25, 5, 0, base::TimeTicks(),
ui::GestureEventDetails(ui::ET_GESTURE_END));
details = root_view->OnEventFromSource(&end2);
EXPECT_FALSE(details.target_destroyed);
EXPECT_FALSE(details.dispatcher_destroyed);
EXPECT_EQ(0, controller.show_context_menu_calls());
controller.Reset();
// |parent_view| should not show a context menu as a result of a long press on
// itself.
ui::GestureEvent long_press3(
50, 50, 0, base::TimeTicks(),
ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS));
details = root_view->OnEventFromSource(&long_press3);
ui::GestureEvent end3(25, 5, 0, base::TimeTicks(),
ui::GestureEventDetails(ui::ET_GESTURE_END));
details = root_view->OnEventFromSource(&end3);
EXPECT_FALSE(details.target_destroyed);
EXPECT_FALSE(details.dispatcher_destroyed);
EXPECT_EQ(0, controller.show_context_menu_calls());
}
namespace {
// View class which destroys itself when it gets an event of type
// |delete_event_type|.
class DeleteViewOnEvent : public View {
public:
DeleteViewOnEvent(ui::EventType delete_event_type, bool* was_destroyed)
: delete_event_type_(delete_event_type), was_destroyed_(was_destroyed) {}
~DeleteViewOnEvent() override {
*was_destroyed_ = true;
}
void OnEvent(ui::Event* event) override {
if (event->type() == delete_event_type_)
delete this;
}
private:
// The event type which causes the view to destroy itself.
ui::EventType delete_event_type_;
// Tracks whether the view was destroyed.
bool* was_destroyed_;
DISALLOW_COPY_AND_ASSIGN(DeleteViewOnEvent);
};
// View class which remove itself when it gets an event of type
// |remove_event_type|.
class RemoveViewOnEvent : public View {
public:
explicit RemoveViewOnEvent(ui::EventType remove_event_type)
: remove_event_type_(remove_event_type) {}
void OnEvent(ui::Event* event) override {
if (event->type() == remove_event_type_)
parent()->RemoveChildView(this);
}
private:
// The event type which causes the view to remove itself.
ui::EventType remove_event_type_;
DISALLOW_COPY_AND_ASSIGN(RemoveViewOnEvent);
};
// View class which generates a nested event the first time it gets an event of
// type |nested_event_type|. This is used to simulate nested event loops which
// can cause |RootView::mouse_event_handler_| to get reset.
class NestedEventOnEvent : public View {
public:
NestedEventOnEvent(ui::EventType nested_event_type, View* root_view)
: nested_event_type_(nested_event_type), root_view_(root_view) {}
void OnEvent(ui::Event* event) override {
if (event->type() == nested_event_type_) {
ui::MouseEvent exit_event(ui::ET_MOUSE_EXITED, gfx::Point(), gfx::Point(),
ui::EventTimeForNow(), ui::EF_NONE,
ui::EF_NONE);
// Avoid infinite recursion if |nested_event_type_| == ET_MOUSE_EXITED.
nested_event_type_ = ui::ET_UNKNOWN;
root_view_->OnMouseExited(exit_event);
}
}
private:
// The event type which causes the view to generate a nested event.
ui::EventType nested_event_type_;
// root view of this view; owned by widget.
View* root_view_;
DISALLOW_COPY_AND_ASSIGN(NestedEventOnEvent);
};
} // namespace
// Verifies deleting a View in OnMouseExited() doesn't crash.
TEST_F(RootViewTest, DeleteViewOnMouseExitDispatch) {
Widget widget;
Widget::InitParams init_params =
CreateParams(Widget::InitParams::TYPE_POPUP);
init_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
widget.Init(init_params);
widget.SetBounds(gfx::Rect(10, 10, 500, 500));
View* content = new View;
widget.SetContentsView(content);
bool view_destroyed = false;
View* child = new DeleteViewOnEvent(ui::ET_MOUSE_EXITED, &view_destroyed);
content->AddChildView(child);
child->SetBounds(10, 10, 500, 500);
internal::RootView* root_view =
static_cast<internal::RootView*>(widget.GetRootView());
// Generate a mouse move event which ensures that |mouse_moved_handler_|
// is set in the RootView class.
ui::MouseEvent moved_event(ui::ET_MOUSE_MOVED, gfx::Point(15, 15),
gfx::Point(15, 15), ui::EventTimeForNow(), 0,
0);
root_view->OnMouseMoved(moved_event);
ASSERT_FALSE(view_destroyed);
// Generate a mouse exit event which in turn will delete the child view which
// was the target of the mouse move event above. This should not crash when
// the mouse exit handler returns from the child.
ui::MouseEvent exit_event(ui::ET_MOUSE_EXITED, gfx::Point(), gfx::Point(),
ui::EventTimeForNow(), 0, 0);
root_view->OnMouseExited(exit_event);
EXPECT_TRUE(view_destroyed);
EXPECT_TRUE(content->children().empty());
}
// Verifies deleting a View in OnMouseEntered() doesn't crash.
TEST_F(RootViewTest, DeleteViewOnMouseEnterDispatch) {
Widget widget;
Widget::InitParams init_params =
CreateParams(Widget::InitParams::TYPE_POPUP);
init_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
widget.Init(init_params);
widget.SetBounds(gfx::Rect(10, 10, 500, 500));
View* content = new View;
widget.SetContentsView(content);
bool view_destroyed = false;
View* child = new DeleteViewOnEvent(ui::ET_MOUSE_ENTERED, &view_destroyed);
content->AddChildView(child);
// Make |child| smaller than the containing Widget and RootView.
child->SetBounds(100, 100, 100, 100);
internal::RootView* root_view =
static_cast<internal::RootView*>(widget.GetRootView());
// Move the mouse within |widget| but outside of |child|.
ui::MouseEvent moved_event(ui::ET_MOUSE_MOVED, gfx::Point(15, 15),
gfx::Point(15, 15), ui::EventTimeForNow(), 0,
0);
root_view->OnMouseMoved(moved_event);
ASSERT_FALSE(view_destroyed);
// Move the mouse within |child|, which should dispatch a mouse enter event to
// |child| and destroy the view. This should not crash when the mouse enter
// handler returns from the child.
ui::MouseEvent moved_event2(ui::ET_MOUSE_MOVED, gfx::Point(115, 115),
gfx::Point(115, 115), ui::EventTimeForNow(), 0,
0);
root_view->OnMouseMoved(moved_event2);
EXPECT_TRUE(view_destroyed);
EXPECT_TRUE(content->children().empty());
}
// Verifies removing a View in OnMouseEntered() doesn't crash.
TEST_F(RootViewTest, RemoveViewOnMouseEnterDispatch) {
Widget widget;
Widget::InitParams init_params = CreateParams(Widget::InitParams::TYPE_POPUP);
init_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
widget.Init(init_params);
widget.SetBounds(gfx::Rect(10, 10, 500, 500));
View* content = new View;
widget.SetContentsView(content);
// |child| gets removed without being deleted, so make it a local
// to prevent test memory leak.
RemoveViewOnEvent child(ui::ET_MOUSE_ENTERED);
content->AddChildView(&child);
// Make |child| smaller than the containing Widget and RootView.
child.SetBounds(100, 100, 100, 100);
internal::RootView* root_view =
static_cast<internal::RootView*>(widget.GetRootView());
// Move the mouse within |widget| but outside of |child|.
ui::MouseEvent moved_event(ui::ET_MOUSE_MOVED, gfx::Point(15, 15),
gfx::Point(15, 15), ui::EventTimeForNow(), 0, 0);
root_view->OnMouseMoved(moved_event);
// Move the mouse within |child|, which should dispatch a mouse enter event to
// |child| and remove the view. This should not crash when the mouse enter
// handler returns.
ui::MouseEvent moved_event2(ui::ET_MOUSE_MOVED, gfx::Point(115, 115),
gfx::Point(115, 115), ui::EventTimeForNow(), 0,
0);
root_view->OnMouseMoved(moved_event2);
EXPECT_TRUE(content->children().empty());
}
// Verifies clearing the root view's |mouse_move_handler_| in OnMouseExited()
// doesn't crash.
TEST_F(RootViewTest, ClearMouseMoveHandlerOnMouseExitDispatch) {
Widget widget;
Widget::InitParams init_params = CreateParams(Widget::InitParams::TYPE_POPUP);
init_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
widget.Init(init_params);
widget.SetBounds(gfx::Rect(10, 10, 500, 500));
View* content = new View;
widget.SetContentsView(content);
View* root_view = widget.GetRootView();
View* child = new NestedEventOnEvent(ui::ET_MOUSE_EXITED, root_view);
content->AddChildView(child);
root_view->AddChildView(content);
// Make |child| smaller than the containing Widget and RootView.
child->SetBounds(100, 100, 100, 100);
// Generate a mouse move event which ensures that |mouse_moved_handler_|
// is set to the child view in the RootView class.
ui::MouseEvent moved_event(ui::ET_MOUSE_MOVED, gfx::Point(110, 110),
gfx::Point(110, 110), ui::EventTimeForNow(), 0, 0);
root_view->OnMouseMoved(moved_event);
// Move the mouse outside of |child| which causes a mouse exit event to be
// dispatched to |child|, which will in turn generate a nested event that
// clears |mouse_move_handler_|. This should not crash
// RootView::OnMouseMoved.
ui::MouseEvent move_event2(ui::ET_MOUSE_MOVED, gfx::Point(15, 15),
gfx::Point(15, 15), ui::EventTimeForNow(), 0, 0);
root_view->OnMouseMoved(move_event2);
}
// Verifies clearing the root view's |mouse_move_handler_| in OnMouseExited()
// doesn't crash, in the case where the root view is targeted, because
// it's the first enabled view encountered walking up the target tree.
TEST_F(RootViewTest,
ClearMouseMoveHandlerOnMouseExitDispatchWithContentViewDisabled) {
Widget widget;
Widget::InitParams init_params = CreateParams(Widget::InitParams::TYPE_POPUP);
init_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
widget.Init(init_params);
widget.SetBounds(gfx::Rect(10, 10, 500, 500));
View* content = new View;
widget.SetContentsView(content);
View* root_view = widget.GetRootView();
View* child = new NestedEventOnEvent(ui::ET_MOUSE_EXITED, root_view);
content->AddChildView(child);
// Make |child| smaller than the containing Widget and RootView.
child->SetBounds(100, 100, 100, 100);
// Generate a mouse move event which ensures that the |mouse_moved_handler_|
// member is set to the child view in the RootView class.
ui::MouseEvent moved_event(ui::ET_MOUSE_MOVED, gfx::Point(110, 110),
gfx::Point(110, 110), ui::EventTimeForNow(), 0, 0);
root_view->OnMouseMoved(moved_event);
// This will make RootView::OnMouseMoved skip the content view when looking
// for a handler for the mouse event, and instead use the root view.
content->SetEnabled(false);
// Move the mouse outside of |child| which should dispatch a mouse exit event
// to |mouse_move_handler_| (currently |child|), which will in turn generate a
// nested event that clears |mouse_move_handler_|. This should not crash
// RootView::OnMouseMoved.
ui::MouseEvent move_event2(ui::ET_MOUSE_MOVED, gfx::Point(200, 200),
gfx::Point(200, 200), ui::EventTimeForNow(), 0, 0);
root_view->OnMouseMoved(move_event2);
}
// Verifies clearing the root view's |mouse_move_handler_| in OnMouseEntered()
// doesn't crash.
TEST_F(RootViewTest, ClearMouseMoveHandlerOnMouseEnterDispatch) {
Widget widget;
Widget::InitParams init_params = CreateParams(Widget::InitParams::TYPE_POPUP);
init_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
widget.Init(init_params);
widget.SetBounds(gfx::Rect(10, 10, 500, 500));
View* content = new View;
widget.SetContentsView(content);
View* root_view = widget.GetRootView();
View* child = new NestedEventOnEvent(ui::ET_MOUSE_ENTERED, root_view);
content->AddChildView(child);
// Make |child| smaller than the containing Widget and RootView.
child->SetBounds(100, 100, 100, 100);
// Move the mouse within |widget| but outside of |child|.
ui::MouseEvent moved_event(ui::ET_MOUSE_MOVED, gfx::Point(15, 15),
gfx::Point(15, 15), ui::EventTimeForNow(), 0, 0);
root_view->OnMouseMoved(moved_event);
// Move the mouse within |child|, which dispatches a mouse enter event to
// |child| and resets the root view's |mouse_move_handler_|. This should not
// crash when the mouse enter handler generates an ET_MOUSE_ENTERED event.
ui::MouseEvent moved_event2(ui::ET_MOUSE_MOVED, gfx::Point(115, 115),
gfx::Point(115, 115), ui::EventTimeForNow(), 0,
0);
root_view->OnMouseMoved(moved_event2);
}
namespace {
// View class which deletes its owning Widget when it gets a mouse exit event.
class DeleteWidgetOnMouseExit : public View {
public:
explicit DeleteWidgetOnMouseExit(Widget* widget)
: widget_(widget) {
}
~DeleteWidgetOnMouseExit() override = default;
void OnMouseExited(const ui::MouseEvent& event) override {
delete widget_;
}
private:
Widget* widget_;
DISALLOW_COPY_AND_ASSIGN(DeleteWidgetOnMouseExit);
};
} // namespace
// Test that there is no crash if a View deletes its parent Widget in
// View::OnMouseExited().
TEST_F(RootViewTest, DeleteWidgetOnMouseExitDispatch) {
Widget* widget = new Widget;
Widget::InitParams init_params =
CreateParams(Widget::InitParams::TYPE_POPUP);
init_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
widget->Init(init_params);
widget->SetBounds(gfx::Rect(10, 10, 500, 500));
WidgetDeletionObserver widget_deletion_observer(widget);
View* content = new View();
View* child = new DeleteWidgetOnMouseExit(widget);
content->AddChildView(child);
widget->SetContentsView(content);
// Make |child| smaller than the containing Widget and RootView.
child->SetBounds(100, 100, 100, 100);
internal::RootView* root_view =
static_cast<internal::RootView*>(widget->GetRootView());
// Move the mouse within |child|.
ui::MouseEvent moved_event(ui::ET_MOUSE_MOVED, gfx::Point(115, 115),
gfx::Point(115, 115), ui::EventTimeForNow(), 0,
0);
root_view->OnMouseMoved(moved_event);
ASSERT_TRUE(widget_deletion_observer.IsWidgetAlive());
// Move the mouse outside of |child| which should dispatch a mouse exit event
// to |child| and destroy the widget. This should not crash when the mouse
// exit handler returns from the child.
ui::MouseEvent move_event2(ui::ET_MOUSE_MOVED, gfx::Point(15, 15),
gfx::Point(15, 15), ui::EventTimeForNow(), 0, 0);
root_view->OnMouseMoved(move_event2);
EXPECT_FALSE(widget_deletion_observer.IsWidgetAlive());
}
// Test that there is no crash if a View deletes its parent widget as a result
// of a mouse exited event which was propagated from one of its children.
TEST_F(RootViewTest, DeleteWidgetOnMouseExitDispatchFromChild) {
Widget* widget = new Widget;
Widget::InitParams init_params =
CreateParams(Widget::InitParams::TYPE_POPUP);
init_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
widget->Init(init_params);
widget->SetBounds(gfx::Rect(10, 10, 500, 500));
WidgetDeletionObserver widget_deletion_observer(widget);
View* content = new View();
View* child = new DeleteWidgetOnMouseExit(widget);
View* subchild = new View();
widget->SetContentsView(content);
content->AddChildView(child);
child->AddChildView(subchild);
// Make |child| and |subchild| smaller than the containing Widget and
// RootView.
child->SetBounds(100, 100, 100, 100);
subchild->SetBounds(0, 0, 100, 100);
// Make mouse enter and exit events get propagated from |subchild| to |child|.
child->set_notify_enter_exit_on_child(true);
internal::RootView* root_view =
static_cast<internal::RootView*>(widget->GetRootView());
// Move the mouse within |subchild| and |child|.
ui::MouseEvent moved_event(ui::ET_MOUSE_MOVED, gfx::Point(115, 115),
gfx::Point(115, 115), ui::EventTimeForNow(), 0, 0);
root_view->OnMouseMoved(moved_event);
ASSERT_TRUE(widget_deletion_observer.IsWidgetAlive());
// Move the mouse outside of |subchild| and |child| which should dispatch a
// mouse exit event to |subchild| and destroy the widget. This should not
// crash when the mouse exit handler returns from |subchild|.
ui::MouseEvent move_event2(ui::ET_MOUSE_MOVED, gfx::Point(15, 15),
gfx::Point(15, 15), ui::EventTimeForNow(), 0, 0);
root_view->OnMouseMoved(move_event2);
EXPECT_FALSE(widget_deletion_observer.IsWidgetAlive());
}
namespace {
class RootViewTestDialogDelegate : public DialogDelegateView {
public:
RootViewTestDialogDelegate() = default;
int layout_count() const { return layout_count_; }
// DialogDelegateView:
gfx::Size CalculatePreferredSize() const override { return preferred_size_; }
void Layout() override {
EXPECT_EQ(size(), preferred_size_);
++layout_count_;
}
int GetDialogButtons() const override {
return ui::DIALOG_BUTTON_NONE; // Ensure buttons do not influence size.
}
private:
const gfx::Size preferred_size_ = gfx::Size(111, 111);
int layout_count_ = 0;
DISALLOW_COPY_AND_ASSIGN(RootViewTestDialogDelegate);
};
} // namespace
// Ensure only one call to Layout() happens during Widget initialization, and
// ensure it happens at the ContentView's preferred size.
TEST_F(RootViewTest, SingleLayoutDuringInit) {
RootViewTestDialogDelegate* delegate = new RootViewTestDialogDelegate();
Widget* widget =
DialogDelegate::CreateDialogWidget(delegate, GetContext(), nullptr);
EXPECT_EQ(1, delegate->layout_count());
widget->CloseNow();
}
using RootViewDesktopNativeWidgetTest = ViewsTestWithDesktopNativeWidget;
// Also test Aura desktop Widget codepaths.
TEST_F(RootViewDesktopNativeWidgetTest, SingleLayoutDuringInit) {
RootViewTestDialogDelegate* delegate = new RootViewTestDialogDelegate();
Widget* widget =
DialogDelegate::CreateDialogWidget(delegate, GetContext(), nullptr);
EXPECT_EQ(1, delegate->layout_count());
widget->CloseNow();
}
} // namespace test
} // namespace views