forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
/
http_chunked_decoder_unittest.cc
427 lines (375 loc) · 11.6 KB
/
http_chunked_decoder_unittest.cc
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "net/http/http_chunked_decoder.h"
#include <memory>
#include <string>
#include <vector>
#include "base/format_macros.h"
#include "base/stl_util.h"
#include "base/strings/stringprintf.h"
#include "net/base/net_errors.h"
#include "net/test/gtest_util.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
using net::test::IsError;
using net::test::IsOk;
namespace net {
namespace {
typedef testing::Test HttpChunkedDecoderTest;
void RunTest(const char* const inputs[],
size_t num_inputs,
const char* expected_output,
bool expected_eof,
int bytes_after_eof) {
HttpChunkedDecoder decoder;
EXPECT_FALSE(decoder.reached_eof());
std::string result;
for (size_t i = 0; i < num_inputs; ++i) {
std::string input = inputs[i];
int n = decoder.FilterBuf(&input[0], static_cast<int>(input.size()));
EXPECT_GE(n, 0);
if (n > 0)
result.append(input.data(), n);
}
EXPECT_EQ(expected_output, result);
EXPECT_EQ(expected_eof, decoder.reached_eof());
EXPECT_EQ(bytes_after_eof, decoder.bytes_after_eof());
}
// Feed the inputs to the decoder, until it returns an error.
void RunTestUntilFailure(const char* const inputs[],
size_t num_inputs,
size_t fail_index) {
HttpChunkedDecoder decoder;
EXPECT_FALSE(decoder.reached_eof());
for (size_t i = 0; i < num_inputs; ++i) {
std::string input = inputs[i];
int n = decoder.FilterBuf(&input[0], static_cast<int>(input.size()));
if (n < 0) {
EXPECT_THAT(n, IsError(ERR_INVALID_CHUNKED_ENCODING));
EXPECT_EQ(fail_index, i);
return;
}
}
FAIL(); // We should have failed on the |fail_index| iteration of the loop.
}
TEST(HttpChunkedDecoderTest, Basic) {
const char* const inputs[] = {
"B\r\nhello hello\r\n0\r\n\r\n"
};
RunTest(inputs, base::size(inputs), "hello hello", true, 0);
}
TEST(HttpChunkedDecoderTest, OneChunk) {
const char* const inputs[] = {
"5\r\nhello\r\n"
};
RunTest(inputs, base::size(inputs), "hello", false, 0);
}
TEST(HttpChunkedDecoderTest, Typical) {
const char* const inputs[] = {
"5\r\nhello\r\n",
"1\r\n \r\n",
"5\r\nworld\r\n",
"0\r\n\r\n"
};
RunTest(inputs, base::size(inputs), "hello world", true, 0);
}
TEST(HttpChunkedDecoderTest, Incremental) {
const char* const inputs[] = {
"5",
"\r",
"\n",
"hello",
"\r",
"\n",
"0",
"\r",
"\n",
"\r",
"\n"
};
RunTest(inputs, base::size(inputs), "hello", true, 0);
}
// Same as above, but group carriage returns with previous input.
TEST(HttpChunkedDecoderTest, Incremental2) {
const char* const inputs[] = {
"5\r",
"\n",
"hello\r",
"\n",
"0\r",
"\n\r",
"\n"
};
RunTest(inputs, base::size(inputs), "hello", true, 0);
}
TEST(HttpChunkedDecoderTest, LF_InsteadOf_CRLF) {
// Compatibility: [RFC 7230 - Invalid]
// {Firefox3} - Valid
// {IE7, Safari3.1, Opera9.51} - Invalid
const char* const inputs[] = {
"5\nhello\n",
"1\n \n",
"5\nworld\n",
"0\n\n"
};
RunTest(inputs, base::size(inputs), "hello world", true, 0);
}
TEST(HttpChunkedDecoderTest, Extensions) {
const char* const inputs[] = {
"5;x=0\r\nhello\r\n",
"0;y=\"2 \"\r\n\r\n"
};
RunTest(inputs, base::size(inputs), "hello", true, 0);
}
TEST(HttpChunkedDecoderTest, Trailers) {
const char* const inputs[] = {
"5\r\nhello\r\n",
"0\r\n",
"Foo: 1\r\n",
"Bar: 2\r\n",
"\r\n"
};
RunTest(inputs, base::size(inputs), "hello", true, 0);
}
TEST(HttpChunkedDecoderTest, TrailersUnfinished) {
const char* const inputs[] = {
"5\r\nhello\r\n",
"0\r\n",
"Foo: 1\r\n"
};
RunTest(inputs, base::size(inputs), "hello", false, 0);
}
TEST(HttpChunkedDecoderTest, InvalidChunkSize_TooBig) {
const char* const inputs[] = {
// This chunked body is not terminated.
// However we will fail decoding because the chunk-size
// number is larger than we can handle.
"48469410265455838241\r\nhello\r\n",
"0\r\n\r\n"
};
RunTestUntilFailure(inputs, base::size(inputs), 0);
}
TEST(HttpChunkedDecoderTest, InvalidChunkSize_0X) {
const char* const inputs[] = {
// Compatibility [RFC 7230 - Invalid]:
// {Safari3.1, IE7} - Invalid
// {Firefox3, Opera 9.51} - Valid
"0x5\r\nhello\r\n",
"0\r\n\r\n"
};
RunTestUntilFailure(inputs, base::size(inputs), 0);
}
TEST(HttpChunkedDecoderTest, ChunkSize_TrailingSpace) {
const char* const inputs[] = {
// Compatibility [RFC 7230 - Invalid]:
// {IE7, Safari3.1, Firefox3, Opera 9.51} - Valid
//
// At least yahoo.com depends on this being valid.
"5 \r\nhello\r\n",
"0\r\n\r\n"
};
RunTest(inputs, base::size(inputs), "hello", true, 0);
}
TEST(HttpChunkedDecoderTest, InvalidChunkSize_TrailingTab) {
const char* const inputs[] = {
// Compatibility [RFC 7230 - Invalid]:
// {IE7, Safari3.1, Firefox3, Opera 9.51} - Valid
"5\t\r\nhello\r\n",
"0\r\n\r\n"
};
RunTestUntilFailure(inputs, base::size(inputs), 0);
}
TEST(HttpChunkedDecoderTest, InvalidChunkSize_TrailingFormFeed) {
const char* const inputs[] = {
// Compatibility [RFC 7230- Invalid]:
// {Safari3.1} - Invalid
// {IE7, Firefox3, Opera 9.51} - Valid
"5\f\r\nhello\r\n",
"0\r\n\r\n"
};
RunTestUntilFailure(inputs, base::size(inputs), 0);
}
TEST(HttpChunkedDecoderTest, InvalidChunkSize_TrailingVerticalTab) {
const char* const inputs[] = {
// Compatibility [RFC 7230 - Invalid]:
// {Safari 3.1} - Invalid
// {IE7, Firefox3, Opera 9.51} - Valid
"5\v\r\nhello\r\n",
"0\r\n\r\n"
};
RunTestUntilFailure(inputs, base::size(inputs), 0);
}
TEST(HttpChunkedDecoderTest, InvalidChunkSize_TrailingNonHexDigit) {
const char* const inputs[] = {
// Compatibility [RFC 7230 - Invalid]:
// {Safari 3.1} - Invalid
// {IE7, Firefox3, Opera 9.51} - Valid
"5H\r\nhello\r\n",
"0\r\n\r\n"
};
RunTestUntilFailure(inputs, base::size(inputs), 0);
}
TEST(HttpChunkedDecoderTest, InvalidChunkSize_LeadingSpace) {
const char* const inputs[] = {
// Compatibility [RFC 7230 - Invalid]:
// {IE7} - Invalid
// {Safari 3.1, Firefox3, Opera 9.51} - Valid
" 5\r\nhello\r\n",
"0\r\n\r\n"
};
RunTestUntilFailure(inputs, base::size(inputs), 0);
}
TEST(HttpChunkedDecoderTest, InvalidLeadingSeparator) {
const char* const inputs[] = {
"\r\n5\r\nhello\r\n",
"0\r\n\r\n"
};
RunTestUntilFailure(inputs, base::size(inputs), 0);
}
TEST(HttpChunkedDecoderTest, InvalidChunkSize_NoSeparator) {
const char* const inputs[] = {
"5\r\nhello",
"1\r\n \r\n",
"0\r\n\r\n"
};
RunTestUntilFailure(inputs, base::size(inputs), 1);
}
TEST(HttpChunkedDecoderTest, InvalidChunkSize_Negative) {
const char* const inputs[] = {
"8\r\n12345678\r\n-5\r\nhello\r\n",
"0\r\n\r\n"
};
RunTestUntilFailure(inputs, base::size(inputs), 0);
}
TEST(HttpChunkedDecoderTest, InvalidChunkSize_Plus) {
const char* const inputs[] = {
// Compatibility [RFC 7230 - Invalid]:
// {IE7, Safari 3.1} - Invalid
// {Firefox3, Opera 9.51} - Valid
"+5\r\nhello\r\n",
"0\r\n\r\n"
};
RunTestUntilFailure(inputs, base::size(inputs), 0);
}
TEST(HttpChunkedDecoderTest, InvalidConsecutiveCRLFs) {
const char* const inputs[] = {
"5\r\nhello\r\n",
"\r\n\r\n\r\n\r\n",
"0\r\n\r\n"
};
RunTestUntilFailure(inputs, base::size(inputs), 1);
}
TEST(HttpChunkedDecoderTest, ReallyBigChunks) {
// Number of bytes sent through the chunked decoder per loop iteration. To
// minimize runtime, should be the square root of the chunk lengths, below.
const int64_t kWrittenBytesPerIteration = 0x10000;
// Length of chunks to test. Must be multiples of kWrittenBytesPerIteration.
int64_t kChunkLengths[] = {
// Overflows when cast to a signed int32.
0x0c0000000,
// Overflows when cast to an unsigned int32.
0x100000000,
};
for (int64_t chunk_length : kChunkLengths) {
HttpChunkedDecoder decoder;
EXPECT_FALSE(decoder.reached_eof());
// Feed just the header to the decode.
std::string chunk_header =
base::StringPrintf("%" PRIx64 "\r\n", chunk_length);
std::vector<char> data(chunk_header.begin(), chunk_header.end());
EXPECT_EQ(OK, decoder.FilterBuf(data.data(), data.size()));
EXPECT_FALSE(decoder.reached_eof());
// Set |data| to be kWrittenBytesPerIteration long, and have a repeating
// pattern.
data.clear();
data.reserve(kWrittenBytesPerIteration);
for (size_t i = 0; i < kWrittenBytesPerIteration; i++) {
data.push_back(static_cast<char>(i));
}
// Repeatedly feed the data to the chunked decoder. Since the data doesn't
// include any chunk lengths, the decode will never have to move the data,
// and should run fairly quickly.
for (int64_t total_written = 0; total_written < chunk_length;
total_written += kWrittenBytesPerIteration) {
EXPECT_EQ(kWrittenBytesPerIteration,
decoder.FilterBuf(data.data(), kWrittenBytesPerIteration));
EXPECT_FALSE(decoder.reached_eof());
}
// Chunk terminator and the final chunk.
char final_chunk[] = "\r\n0\r\n\r\n";
EXPECT_EQ(OK, decoder.FilterBuf(final_chunk, base::size(final_chunk)));
EXPECT_TRUE(decoder.reached_eof());
// Since |data| never included any chunk headers, it should not have been
// modified.
for (size_t i = 0; i < kWrittenBytesPerIteration; i++) {
EXPECT_EQ(static_cast<char>(i), data[i]);
}
}
}
TEST(HttpChunkedDecoderTest, ExcessiveChunkLen) {
// Smallest number that can't be represented as a signed int64.
const char* const inputs[] = {"8000000000000000\r\nhello\r\n"};
RunTestUntilFailure(inputs, base::size(inputs), 0);
}
TEST(HttpChunkedDecoderTest, ExcessiveChunkLen2) {
// Smallest number that can't be represented as an unsigned int64.
const char* const inputs[] = {"10000000000000000\r\nhello\r\n"};
RunTestUntilFailure(inputs, base::size(inputs), 0);
}
TEST(HttpChunkedDecoderTest, BasicExtraData) {
const char* const inputs[] = {
"5\r\nhello\r\n0\r\n\r\nextra bytes"
};
RunTest(inputs, base::size(inputs), "hello", true, 11);
}
TEST(HttpChunkedDecoderTest, IncrementalExtraData) {
const char* const inputs[] = {
"5",
"\r",
"\n",
"hello",
"\r",
"\n",
"0",
"\r",
"\n",
"\r",
"\nextra bytes"
};
RunTest(inputs, base::size(inputs), "hello", true, 11);
}
TEST(HttpChunkedDecoderTest, MultipleExtraDataBlocks) {
const char* const inputs[] = {
"5\r\nhello\r\n0\r\n\r\nextra",
" bytes"
};
RunTest(inputs, base::size(inputs), "hello", true, 11);
}
// Test when the line with the chunk length is too long.
TEST(HttpChunkedDecoderTest, LongChunkLengthLine) {
int big_chunk_length = HttpChunkedDecoder::kMaxLineBufLen;
std::unique_ptr<char[]> big_chunk(new char[big_chunk_length + 1]);
memset(big_chunk.get(), '0', big_chunk_length);
big_chunk[big_chunk_length] = 0;
const char* const inputs[] = {
big_chunk.get(),
"5"
};
RunTestUntilFailure(inputs, base::size(inputs), 1);
}
// Test when the extension portion of the line with the chunk length is too
// long.
TEST(HttpChunkedDecoderTest, LongLengthLengthLine) {
int big_chunk_length = HttpChunkedDecoder::kMaxLineBufLen;
std::unique_ptr<char[]> big_chunk(new char[big_chunk_length + 1]);
memset(big_chunk.get(), '0', big_chunk_length);
big_chunk[big_chunk_length] = 0;
const char* const inputs[] = {
"5;",
big_chunk.get()
};
RunTestUntilFailure(inputs, base::size(inputs), 1);
}
} // namespace
} // namespace net