forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
/
bookmark_app_navigation_throttle_browsertest.cc
1672 lines (1433 loc) · 65.2 KB
/
bookmark_app_navigation_throttle_browsertest.cc
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/bind.h"
#include "base/strings/stringprintf.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "build/build_config.h"
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/extensions/bookmark_app_navigation_browsertest.h"
#include "chrome/browser/extensions/bookmark_app_navigation_throttle_utils.h"
#include "chrome/browser/extensions/launch_util.h"
#include "chrome/browser/prefs/session_startup_pref.h"
#include "chrome/browser/prerender/prerender_manager.h"
#include "chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/extensions/app_launch_params.h"
#include "chrome/browser/ui/extensions/application_launch.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/web_applications/components/web_app_helpers.h"
#include "chrome/browser/web_applications/extensions/bookmark_app_util.h"
#include "chrome/common/chrome_features.h"
#include "chrome/common/extensions/manifest_handlers/app_launch_info.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/browser/navigation_handle.h"
#include "content/public/browser/notification_details.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/common/context_menu_params.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/test_frame_navigation_observer.h"
#include "content/public/test/test_navigation_observer.h"
#include "content/public/test/test_utils.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/notification_types.h"
#include "extensions/common/constants.h"
#include "net/base/escape.h"
#include "net/http/http_request_headers.h"
#include "net/url_request/url_fetcher.h"
#include "services/network/public/cpp/resource_request_body.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace extensions {
namespace test {
enum class StartIn {
BROWSER,
APP,
};
enum class WindowAccessResult {
CAN_ACCESS,
CANNOT_ACCESS,
// Used for when there was an unexpected issue when accessing the other window
// e.g. there is no other window, or the other window's URL does not match the
// expected URL.
OTHER,
};
namespace {
const char kTextPlainEncType[] = "text/plain";
const char kQueryParam[] = "test=";
const char kQueryParamName[] = "test";
// On macOS the Meta key is used as a modifier instead of Control.
#if defined(OS_MACOSX)
constexpr int kCtrlOrMeta = blink::WebInputEvent::kMetaKey;
#else
constexpr int kCtrlOrMeta = blink::WebInputEvent::kControlKey;
#endif
// Subclass of TestNavigationObserver that saves extra information about the
// navigation and watches all navigations to |target_url|.
class BookmarkAppNavigationObserver : public content::TestNavigationObserver {
public:
// Creates an observer that watches navigations to |target_url| on all
// existing and newly added WebContents.
explicit BookmarkAppNavigationObserver(const GURL& target_url)
: content::TestNavigationObserver(target_url),
last_navigation_is_post_(false) {
WatchExistingWebContents();
StartWatchingNewWebContents();
}
bool last_navigation_is_post() const { return last_navigation_is_post_; }
const net::HttpRequestHeaders& last_request_headers() const {
return last_request_headers_;
}
const scoped_refptr<network::ResourceRequestBody>&
last_resource_request_body() const {
return last_resource_request_body_;
}
private:
void OnDidFinishNavigation(
content::NavigationHandle* navigation_handle) override {
last_navigation_is_post_ = navigation_handle->IsPost();
last_request_headers_ = navigation_handle->GetRequestHeaders();
last_resource_request_body_ = navigation_handle->GetResourceRequestBody();
content::TestNavigationObserver::OnDidFinishNavigation(navigation_handle);
}
// True if the last navigation was a post.
bool last_navigation_is_post_;
// The request headers of the last navigation.
net::HttpRequestHeaders last_request_headers_;
// The request body of the last navigation if it was a post request.
scoped_refptr<network::ResourceRequestBody> last_resource_request_body_;
};
void ExpectNavigationResultHistogramEquals(
const base::HistogramTester& histogram_tester,
const std::vector<std::pair<BookmarkAppNavigationThrottleResult,
base::HistogramBase::Count>>& expected_counts) {
std::vector<base::Bucket> expected_bucket_counts;
for (const auto& pair : expected_counts) {
expected_bucket_counts.push_back(base::Bucket(
static_cast<base::HistogramBase::Sample>(pair.first), pair.second));
}
EXPECT_THAT(
histogram_tester.GetAllSamples("Extensions.BookmarkApp.NavigationResult"),
testing::UnorderedElementsAreArray(expected_bucket_counts));
}
// When an app is launched, whether it's in response to a navigation or click
// in a launch surface e.g. App Shelf, the first navigation in the app is
// an AUTO_BOOKMARK navigation.
std::pair<BookmarkAppNavigationThrottleResult, base::HistogramBase::Count>
GetAppLaunchedEntry() {
return {BookmarkAppNavigationThrottleResult::kProceedTransitionAutoBookmark,
1};
}
std::string CreateClientRedirect(const GURL& target_url) {
const char* const kClientRedirectBase = "/client-redirect?";
return kClientRedirectBase +
net::EscapeQueryParamValue(target_url.spec(), false);
}
// Inserts an iframe in the main frame of |web_contents|.
void InsertIFrame(content::WebContents* web_contents) {
ASSERT_TRUE(
content::ExecuteScript(web_contents,
"let iframe = document.createElement('iframe');"
"document.body.appendChild(iframe);"));
}
void ExecuteContextMenuLinkCommandAndWait(content::WebContents* web_contents,
const GURL& target_url,
int command_id) {
auto observer =
BookmarkAppNavigationBrowserTest::GetTestNavigationObserver(target_url);
content::ContextMenuParams params;
params.page_url = web_contents->GetLastCommittedURL();
params.link_url = target_url;
TestRenderViewContextMenu menu(web_contents->GetMainFrame(), params);
menu.Init();
menu.ExecuteCommand(command_id, 0 /* event_flags */);
observer->WaitForNavigationFinished();
}
void OpenPopupAndWait(content::WebContents* web_contents,
const GURL& target_url) {
auto observer =
BookmarkAppNavigationBrowserTest::GetTestNavigationObserver(target_url);
const std::string script = base::StringPrintf(
"(() => {"
" window.openedWindow = window.open('%s', '_blank', 'toolbar=no');"
"})();",
target_url.spec().c_str());
ASSERT_TRUE(content::ExecuteScript(web_contents, script));
observer->WaitForNavigationFinished();
}
// Calls window.open() with |target_url| on the main frame of |web_contents|.
// Returns once the new window has navigated to |target_url|.
void WindowOpenAndWait(content::WebContents* web_contents,
const GURL& target_url) {
auto observer =
BookmarkAppNavigationBrowserTest::GetTestNavigationObserver(target_url);
const std::string script = base::StringPrintf(
"(() => {"
" window.openedWindow = window.open('%s');"
"})();",
target_url.spec().c_str());
ASSERT_TRUE(content::ExecuteScript(web_contents, script));
observer->WaitForNavigationFinished();
}
// Calls window.open() with |target_url| on the main frame of |web_contents|.
// Returns true if the resulting child window is allowed to access members of
// its opener.
WindowAccessResult CanChildWindowAccessOpener(
content::WebContents* web_contents,
const GURL& target_url) {
WindowOpenAndWait(web_contents, target_url);
content::WebContents* new_contents =
chrome::FindLastActive()->tab_strip_model()->GetActiveWebContents();
const std::string script = base::StringPrintf(
"(() => {"
" const [CAN_ACCESS, CANNOT_ACCESS, OTHER] = [0, 1, 2];"
" let result = OTHER;"
" try {"
" if (window.opener.location.href === '%s')"
" result = CAN_ACCESS;"
" } catch (e) {"
" if (e.name === 'SecurityError')"
" result = CANNOT_ACCESS;"
" }"
" window.domAutomationController.send(result);"
"})();",
web_contents->GetLastCommittedURL().spec().c_str());
int access_result;
CHECK(content::ExecuteScriptAndExtractInt(new_contents, script,
&access_result));
switch (access_result) {
case 0:
return WindowAccessResult::CAN_ACCESS;
case 1:
return WindowAccessResult::CANNOT_ACCESS;
case 2:
return WindowAccessResult::OTHER;
default:
NOTREACHED();
return WindowAccessResult::OTHER;
}
}
// Adds a query parameter to |base_url|.
GURL AddTestQueryParam(const GURL& base_url) {
GURL::Replacements replacements;
std::string query(kQueryParam);
replacements.SetQuery(query.c_str(), url::Component(0, query.length()));
return base_url.ReplaceComponents(replacements);
}
// Creates a <form> element with a |target_url| action and |method| method. Adds
// the form to the DOM with a button and clicks the button. Returns once
// |target_url| has been loaded.
//
// If |method| is net::URLFetcher::RequestType::GET, |target_url| should contain
// an empty query string, since that URL will be loaded when submitting the form
// e.g. "https://www.example.com/?".
void SubmitFormAndWait(content::WebContents* web_contents,
const GURL& target_url,
net::URLFetcher::RequestType method) {
bool is_post = true;
if (method == net::URLFetcher::RequestType::GET) {
is_post = false;
ASSERT_TRUE(target_url.has_query());
ASSERT_EQ(kQueryParam, target_url.query());
}
BookmarkAppNavigationObserver observer(target_url);
std::string script = base::StringPrintf(
"(() => {"
"const form = document.createElement('form');"
"form.action = '%s';"
"form.method = '%s';"
"form.enctype = '%s';"
"const input = document.createElement('input');"
"input.name = '%s';"
"form.appendChild(input);"
"const button = document.createElement('input');"
"button.type = 'submit';"
"form.appendChild(button);"
"document.body.appendChild(form);"
"button.dispatchEvent(new MouseEvent('click', {'view': window}));"
"})();",
target_url.spec().c_str(),
method == net::URLFetcher::RequestType::POST ? "post" : "get",
kTextPlainEncType, kQueryParamName);
ASSERT_TRUE(content::ExecuteScript(web_contents, script));
observer.WaitForNavigationFinished();
EXPECT_EQ(is_post, observer.last_navigation_is_post());
if (is_post) {
const net::HttpRequestHeaders& headers = observer.last_request_headers();
std::string post_content_type;
headers.GetHeader(net::HttpRequestHeaders::kContentType,
&post_content_type);
EXPECT_EQ(kTextPlainEncType, post_content_type);
const std::vector<network::DataElement>* elements =
observer.last_resource_request_body()->elements();
EXPECT_EQ(1u, elements->size());
const auto& element = elements->front();
// The text/plain enconding algorithm appends "\r\n".
EXPECT_EQ(std::string(kQueryParam) + "\r\n",
std::string(element.bytes(), element.length()));
}
}
// Uses |params| to navigate to a URL. Blocks until the URL is loaded.
void NavigateToURLAndWait(NavigateParams* params) {
auto observer =
BookmarkAppNavigationBrowserTest::GetTestNavigationObserver(params->url);
ui_test_utils::NavigateToURL(params);
observer->WaitForNavigationFinished();
}
// Wrapper so that we can use base::BindOnce with NavigateToURL.
void NavigateToURLWrapper(NavigateParams* params) {
ui_test_utils::NavigateToURL(params);
}
} // namespace
// Tests for the behavior when the kDesktopPWAsLinkCapturing flag is on.
class BookmarkAppNavigationThrottleExperimentalBrowserTest
: public BookmarkAppNavigationBrowserTest {
public:
void SetUp() override {
scoped_feature_list_.InitWithFeatures(
{features::kDesktopPWAWindowing, features::kDesktopPWAsLinkCapturing},
{});
BookmarkAppNavigationBrowserTest::SetUp();
}
private:
base::test::ScopedFeatureList scoped_feature_list_;
};
// Tests that the result is the same regardless of the 'rel' attribute of links.
class BookmarkAppNavigationThrottleExperimentalLinkBrowserTest
: public BookmarkAppNavigationThrottleExperimentalBrowserTest,
public ::testing::WithParamInterface<std::string> {};
// Tests that navigating to the Web App's app_url doesn't open a new window
// if features::kDesktopPWAsLinkCapturing is disabled before installing the app.
IN_PROC_BROWSER_TEST_P(BookmarkAppNavigationThrottleExperimentalLinkBrowserTest,
FeatureDisable_BeforeInstall) {
base::test::ScopedFeatureList feature_list;
feature_list.InitWithFeatures({}, {features::kDesktopPWAsLinkCapturing});
InstallTestBookmarkApp();
NavigateToLaunchingPage();
const GURL app_url = https_server().GetURL(GetAppUrlHost(), GetAppUrlPath());
TestTabActionDoesNotOpenAppWindow(
app_url,
base::BindOnce(&ClickLinkAndWait,
browser()->tab_strip_model()->GetActiveWebContents(),
app_url, LinkTarget::SELF, GetParam()));
ExpectNavigationResultHistogramEquals(global_histogram(), {});
}
// Tests that navigating to the Web App's app_url doesn't open a new window
// if features::kDesktopPWAWindowing is disabled after installing the app.
IN_PROC_BROWSER_TEST_P(BookmarkAppNavigationThrottleExperimentalLinkBrowserTest,
FeatureDisable_AfterInstall) {
InstallTestBookmarkApp();
base::test::ScopedFeatureList feature_list;
feature_list.InitWithFeatures({}, {features::kDesktopPWAsLinkCapturing});
NavigateToLaunchingPage();
const GURL app_url = https_server().GetURL(GetAppUrlHost(), GetAppUrlPath());
TestTabActionDoesNotOpenAppWindow(
app_url,
base::BindOnce(&ClickLinkAndWait,
browser()->tab_strip_model()->GetActiveWebContents(),
app_url, LinkTarget::SELF, GetParam()));
ExpectNavigationResultHistogramEquals(global_histogram(), {});
}
// Tests that most transition types for navigations to in-scope or
// out-of-scope URLs do not result in new app windows.
class BookmarkAppNavigationThrottleExperimentalTransitionBrowserTest
: public BookmarkAppNavigationThrottleExperimentalBrowserTest,
public ::testing::WithParamInterface<
std::tuple<std::string, ui::PageTransition>> {};
INSTANTIATE_TEST_SUITE_P(
/* no prefix */,
BookmarkAppNavigationThrottleExperimentalTransitionBrowserTest,
testing::Combine(
testing::Values(
BookmarkAppNavigationBrowserTest::GetInScopeUrlPath(),
BookmarkAppNavigationBrowserTest::GetOutOfScopeUrlPath()),
testing::Range(ui::PAGE_TRANSITION_FIRST,
ui::PAGE_TRANSITION_LAST_CORE)));
#if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_MACOSX)
#define MAYBE_MainFrameNavigations DISABLED_MainFrameNavigations
#else
#define MAYBE_MainFrameNavigations MainFrameNavigations
#endif
IN_PROC_BROWSER_TEST_P(
BookmarkAppNavigationThrottleExperimentalTransitionBrowserTest,
MAYBE_MainFrameNavigations) {
InstallTestBookmarkApp();
GURL target_url =
https_server().GetURL(GetAppUrlHost(), std::get<0>(GetParam()));
ui::PageTransition transition = std::get<1>(GetParam());
NavigateParams params(browser(), target_url, transition);
if (!ui::PageTransitionIsMainFrame(transition)) {
// Subframe navigations require a different setup. See
// BookmarkAppNavigationThrottleExperimentalBrowserTest.SubframeNavigation.
return;
}
if (ui::PageTransitionCoreTypeIs(ui::PAGE_TRANSITION_LINK, transition) &&
target_url ==
https_server().GetURL(GetAppUrlHost(), GetInScopeUrlPath())) {
TestTabActionOpensAppWindow(target_url,
base::BindOnce(&NavigateToURLAndWait, ¶ms));
} else {
TestTabActionDoesNotOpenAppWindow(
target_url, base::BindOnce(&NavigateToURLAndWait, ¶ms));
}
}
// Tests that navigations in subframes don't open new app windows.
//
// The transition type for subframe navigations is not set until
// after NavigationThrottles run. Because of this, our
// BookmarkAppNavigationThrottle will not see the transition type as
// PAGE_TRANSITION_AUTO_SUBFRAME/PAGE_TRANSITION_MANUAL_SUBFRAME, even though,
// by the end of the navigation, the transition type is
// PAGE_TRANSITION_AUTO_SUBFRAME/PAGE_TRANSITON_MANUAL_SUBFRAME.
IN_PROC_BROWSER_TEST_F(BookmarkAppNavigationThrottleExperimentalBrowserTest,
AutoSubframeNavigation) {
InstallTestBookmarkApp();
NavigateToLaunchingPage();
content::WebContents* initial_tab =
browser()->tab_strip_model()->GetActiveWebContents();
InsertIFrame(initial_tab);
content::RenderFrameHost* iframe = GetIFrame(initial_tab);
const GURL app_url = https_server().GetURL(GetAppUrlHost(), GetAppUrlPath());
NavigateParams params(browser(), app_url, ui::PAGE_TRANSITION_LINK);
params.frame_tree_node_id = iframe->GetFrameTreeNodeId();
content::TestFrameNavigationObserver observer(iframe);
TestIFrameActionDoesNotOpenAppWindow(
app_url, base::BindOnce(&NavigateToURLWrapper, ¶ms));
ASSERT_TRUE(ui::PageTransitionCoreTypeIs(observer.transition_type(),
ui::PAGE_TRANSITION_AUTO_SUBFRAME));
// Subframe navigations are completely ignored, so there should be no change
// in the histogram.
ExpectNavigationResultHistogramEquals(global_histogram(), {});
}
IN_PROC_BROWSER_TEST_F(BookmarkAppNavigationThrottleExperimentalBrowserTest,
ManualSubframeNavigation) {
InstallTestBookmarkApp();
NavigateToLaunchingPage();
content::WebContents* initial_tab =
browser()->tab_strip_model()->GetActiveWebContents();
InsertIFrame(initial_tab);
{
// Navigate the iframe once, so that the next navigation is a
// MANUAL_SUBFRAME navigation.
content::RenderFrameHost* iframe = GetIFrame(initial_tab);
NavigateParams params(browser(), GetLaunchingPageURL(),
ui::PAGE_TRANSITION_LINK);
params.frame_tree_node_id = iframe->GetFrameTreeNodeId();
ASSERT_TRUE(TestIFrameActionDoesNotOpenAppWindow(
GetLaunchingPageURL(), base::BindOnce(&NavigateToURLWrapper, ¶ms)));
}
content::RenderFrameHost* iframe = GetIFrame(initial_tab);
const GURL app_url = https_server().GetURL(GetAppUrlHost(), GetAppUrlPath());
NavigateParams params(browser(), app_url, ui::PAGE_TRANSITION_LINK);
params.frame_tree_node_id = iframe->GetFrameTreeNodeId();
content::TestFrameNavigationObserver observer(iframe);
TestIFrameActionDoesNotOpenAppWindow(
app_url, base::BindOnce(&NavigateToURLWrapper, ¶ms));
ASSERT_TRUE(ui::PageTransitionCoreTypeIs(
observer.transition_type(), ui::PAGE_TRANSITION_MANUAL_SUBFRAME));
// Subframe navigations are completely ignored, so there should be no change
// in the histogram.
ExpectNavigationResultHistogramEquals(global_histogram(), {});
}
// Tests that pasting an in-scope URL into the address bar and navigating to it,
// does not open an app window.
// https://crbug.com/782004
IN_PROC_BROWSER_TEST_F(BookmarkAppNavigationThrottleExperimentalBrowserTest,
LinkNavigationFromAddressBar) {
InstallTestBookmarkApp();
const GURL app_url = https_server().GetURL(GetAppUrlHost(), GetAppUrlPath());
// Fake a navigation with a TRANSITION_LINK core type and a
// TRANSITION_FROM_ADDRESS_BAR qualifier. This matches the transition that
// results from pasting a URL into the address and navigating to it.
NavigateParams params(
browser(), app_url,
ui::PageTransitionFromInt(ui::PAGE_TRANSITION_LINK |
ui::PAGE_TRANSITION_FROM_ADDRESS_BAR));
ASSERT_TRUE(TestTabActionDoesNotOpenAppWindow(
app_url, base::BindOnce(&NavigateToURLWrapper, ¶ms)));
ExpectNavigationResultHistogramEquals(
global_histogram(),
{{BookmarkAppNavigationThrottleResult::kProceedTransitionFromAddressBar,
1}});
}
// Tests that going back to an in-scope URL does not open a new app window.
IN_PROC_BROWSER_TEST_F(BookmarkAppNavigationThrottleExperimentalBrowserTest,
BackNavigation) {
InstallTestBookmarkApp();
NavigateToTestAppURL();
// Navigate to an in-scope URL to generate a link navigation that didn't
// get intercepted. The navigation won't get intercepted because the target
// URL is in-scope of the app for the current URL.
const GURL in_scope_url =
https_server().GetURL(GetAppUrlHost(), GetInScopeUrlPath());
ASSERT_TRUE(TestTabActionDoesNotOpenAppWindow(
in_scope_url,
base::BindOnce(&ClickLinkAndWait,
browser()->tab_strip_model()->GetActiveWebContents(),
in_scope_url, LinkTarget::SELF, "" /* rel */)));
// Navigate to an out-of-scope URL.
{
const GURL out_of_scope_url =
https_server().GetURL(GetAppUrlHost(), GetOutOfScopeUrlPath());
NavigateParams params(browser(), out_of_scope_url,
ui::PAGE_TRANSITION_TYPED);
ASSERT_TRUE(TestTabActionDoesNotOpenAppWindow(
out_of_scope_url, base::BindOnce(&NavigateToURLWrapper, ¶ms)));
}
base::HistogramTester scoped_histogram;
TestTabActionDoesNotOpenAppWindow(
in_scope_url,
base::BindOnce(
[](content::WebContents* web_contents, const GURL& in_scope_url) {
auto observer = GetTestNavigationObserver(in_scope_url);
web_contents->GetController().GoBack();
observer->WaitForNavigationFinished();
},
browser()->tab_strip_model()->GetActiveWebContents(), in_scope_url));
ExpectNavigationResultHistogramEquals(
scoped_histogram,
{{BookmarkAppNavigationThrottleResult::kProceedTransitionForwardBack,
1}});
}
// Tests that clicking a link to an app that launches in a tab does not open a
// a new app window.
IN_PROC_BROWSER_TEST_P(BookmarkAppNavigationThrottleExperimentalLinkBrowserTest,
TabApp) {
InstallTestBookmarkApp();
// Set a pref indicating that the user wants to launch in a regular tab.
extensions::SetLaunchType(browser()->profile(), test_bookmark_app()->id(),
extensions::LAUNCH_TYPE_REGULAR);
NavigateToLaunchingPage();
const GURL app_url = https_server().GetURL(GetAppUrlHost(), GetAppUrlPath());
TestTabActionDoesNotOpenAppWindow(
app_url,
base::BindOnce(&ClickLinkAndWait,
browser()->tab_strip_model()->GetActiveWebContents(),
app_url, LinkTarget::SELF, GetParam()));
// Non-windowed apps are not considered when looking for a target app, so it's
// as if there was no app installed for the URL.
ExpectNavigationResultHistogramEquals(global_histogram(), {});
}
// Tests that clicking a link to an app that isn't locally installed does not
// open a new app window.
IN_PROC_BROWSER_TEST_P(BookmarkAppNavigationThrottleExperimentalLinkBrowserTest,
NotLocallyInstalledApp) {
InstallTestBookmarkApp();
// Part of the installation process (setting that this is a locally installed
// app) runs asynchronously. Wait for that to complete before setting locally
// installed to false.
base::RunLoop().RunUntilIdle();
SetBookmarkAppIsLocallyInstalled(browser()->profile(), test_bookmark_app(),
false /* is_locally_installed */);
NavigateToLaunchingPage();
const GURL app_url = https_server().GetURL(GetAppUrlHost(), GetAppUrlPath());
TestTabActionDoesNotOpenAppWindow(
app_url,
base::BindOnce(&ClickLinkAndWait,
browser()->tab_strip_model()->GetActiveWebContents(),
app_url, LinkTarget::SELF, GetParam()));
// Non-locally installed apps are not considered when looking for a target
// app, so it's as if there was no app installed for the URL.
ExpectNavigationResultHistogramEquals(global_histogram(), {});
}
// Tests that clicking a link with target="_self" to the app's app_url opens the
// Bookmark App.
IN_PROC_BROWSER_TEST_P(BookmarkAppNavigationThrottleExperimentalLinkBrowserTest,
AppUrlSelf) {
InstallTestBookmarkApp();
NavigateToLaunchingPage();
const GURL app_url = https_server().GetURL(GetAppUrlHost(), GetAppUrlPath());
TestTabActionOpensAppWindow(
app_url,
base::BindOnce(&ClickLinkAndWait,
browser()->tab_strip_model()->GetActiveWebContents(),
app_url, LinkTarget::SELF, GetParam()));
ExpectNavigationResultHistogramEquals(
global_histogram(),
{{BookmarkAppNavigationThrottleResult::kCancelOpenedApp, 1},
GetAppLaunchedEntry()});
}
// Tests that clicking a link with target="_blank" to the app's app_url opens
// the Bookmark App.
IN_PROC_BROWSER_TEST_P(BookmarkAppNavigationThrottleExperimentalLinkBrowserTest,
AppUrlBlank) {
InstallTestBookmarkApp();
NavigateToLaunchingPage();
const GURL app_url = https_server().GetURL(GetAppUrlHost(), GetAppUrlPath());
TestTabActionOpensAppWindow(
app_url,
base::BindOnce(&ClickLinkAndWait,
browser()->tab_strip_model()->GetActiveWebContents(),
app_url, LinkTarget::BLANK, GetParam()));
ExpectNavigationResultHistogramEquals(
global_histogram(),
{{BookmarkAppNavigationThrottleResult::kDeferMovingContentsToNewAppWindow,
1}});
}
// Tests that Ctrl + Clicking a link to the app's app_url opens a new background
// tab and not the app.
IN_PROC_BROWSER_TEST_P(BookmarkAppNavigationThrottleExperimentalLinkBrowserTest,
AppUrlCtrlClick) {
InstallTestBookmarkApp();
NavigateToLaunchingPage();
const GURL app_url = https_server().GetURL(GetAppUrlPath());
TestTabActionOpensBackgroundTab(
app_url,
base::BindOnce(&ClickLinkWithModifiersAndWait,
browser()->tab_strip_model()->GetActiveWebContents(),
app_url, LinkTarget::SELF, GetParam(), kCtrlOrMeta));
ExpectNavigationResultHistogramEquals(
global_histogram(), {{BookmarkAppNavigationThrottleResult::
kProceedDispositionNewBackgroundTab,
1}});
}
// Tests that clicking a link with target="_self" and for which the server
// redirects to the app's app_url opens the Bookmark App.
IN_PROC_BROWSER_TEST_P(BookmarkAppNavigationThrottleExperimentalLinkBrowserTest,
ServerRedirectToAppUrlSelf) {
InstallTestBookmarkApp();
NavigateToLaunchingPage();
const GURL app_url = https_server().GetURL(GetAppUrlHost(), GetAppUrlPath());
const GURL redirecting_url = https_server().GetURL(
GetLaunchingPageHost(), CreateServerRedirect(app_url));
TestTabActionOpensAppWindow(
app_url,
base::BindOnce(&ClickLinkAndWaitForURL,
browser()->tab_strip_model()->GetActiveWebContents(),
redirecting_url, app_url, LinkTarget::SELF, GetParam()));
ExpectNavigationResultHistogramEquals(
global_histogram(),
{{BookmarkAppNavigationThrottleResult::kCancelOpenedApp, 1},
GetAppLaunchedEntry()});
}
// Tests that clicking a link with target="_blank" and for which the server
// redirects to the app's app_url opens the Bookmark App.
IN_PROC_BROWSER_TEST_P(BookmarkAppNavigationThrottleExperimentalLinkBrowserTest,
ServerRedirectToAppUrlBlank) {
InstallTestBookmarkApp();
NavigateToLaunchingPage();
const GURL app_url = https_server().GetURL(GetAppUrlHost(), GetAppUrlPath());
const GURL redirecting_url = https_server().GetURL(
GetLaunchingPageHost(), CreateServerRedirect(app_url));
TestTabActionOpensAppWindow(
app_url,
base::BindOnce(&ClickLinkAndWaitForURL,
browser()->tab_strip_model()->GetActiveWebContents(),
redirecting_url, app_url, LinkTarget::BLANK, GetParam()));
ExpectNavigationResultHistogramEquals(
global_histogram(),
{{BookmarkAppNavigationThrottleResult::kDeferMovingContentsToNewAppWindow,
1}});
}
// Tests that clicking a link with target="_self" and for which the client
// redirects to the app's app_url opens the Bookmark App. The initial tab will
// be left on the redirecting URL.
IN_PROC_BROWSER_TEST_P(BookmarkAppNavigationThrottleExperimentalLinkBrowserTest,
ClientRedirectToAppUrlSelf) {
InstallTestBookmarkApp();
NavigateToLaunchingPage();
content::WebContents* initial_tab =
browser()->tab_strip_model()->GetActiveWebContents();
GURL initial_url = initial_tab->GetLastCommittedURL();
int num_tabs = browser()->tab_strip_model()->count();
size_t num_browsers = chrome::GetBrowserCount(profile());
const GURL app_url = https_server().GetURL(GetAppUrlHost(), GetAppUrlPath());
const GURL redirecting_url = https_server().GetURL(
GetLaunchingPageHost(), CreateClientRedirect(app_url));
ClickLinkAndWaitForURL(browser()->tab_strip_model()->GetActiveWebContents(),
redirecting_url, app_url, LinkTarget::SELF,
GetParam());
EXPECT_EQ(num_tabs, browser()->tab_strip_model()->count());
EXPECT_EQ(++num_browsers, chrome::GetBrowserCount(profile()));
EXPECT_NE(browser(), chrome::FindLastActive());
EXPECT_EQ(redirecting_url, initial_tab->GetLastCommittedURL());
EXPECT_EQ(app_url, chrome::FindLastActive()
->tab_strip_model()
->GetActiveWebContents()
->GetLastCommittedURL());
ExpectNavigationResultHistogramEquals(
global_histogram(),
{{BookmarkAppNavigationThrottleResult::kCancelOpenedApp, 1},
GetAppLaunchedEntry()});
}
// Tests that clicking a link with target="_blank" and for which the client
// redirects to the app's app_url opens the Bookmark App. The new tab will be
// left on the redirecting URL.
IN_PROC_BROWSER_TEST_P(BookmarkAppNavigationThrottleExperimentalLinkBrowserTest,
ClientRedirectToAppUrlBlank) {
InstallTestBookmarkApp();
NavigateToLaunchingPage();
content::WebContents* initial_tab =
browser()->tab_strip_model()->GetActiveWebContents();
GURL initial_url = initial_tab->GetLastCommittedURL();
int num_tabs = browser()->tab_strip_model()->count();
size_t num_browsers = chrome::GetBrowserCount(profile());
const GURL app_url = https_server().GetURL(GetAppUrlHost(), GetAppUrlPath());
const GURL redirecting_url = https_server().GetURL(
GetLaunchingPageHost(), CreateClientRedirect(app_url));
ClickLinkAndWaitForURL(browser()->tab_strip_model()->GetActiveWebContents(),
redirecting_url, app_url, LinkTarget::BLANK,
GetParam());
EXPECT_EQ(++num_tabs, browser()->tab_strip_model()->count());
EXPECT_EQ(++num_browsers, chrome::GetBrowserCount(profile()));
EXPECT_NE(browser(), chrome::FindLastActive());
content::WebContents* new_tab =
browser()->tab_strip_model()->GetActiveWebContents();
EXPECT_NE(new_tab, initial_tab);
EXPECT_EQ(redirecting_url, new_tab->GetLastCommittedURL());
EXPECT_EQ(app_url, chrome::FindLastActive()
->tab_strip_model()
->GetActiveWebContents()
->GetLastCommittedURL());
ExpectNavigationResultHistogramEquals(
global_histogram(),
{{BookmarkAppNavigationThrottleResult::kCancelOpenedApp, 1},
GetAppLaunchedEntry()});
}
// Tests that clicking a link with target="_self" to a URL in the Web App's
// scope opens a new browser window.
IN_PROC_BROWSER_TEST_P(BookmarkAppNavigationThrottleExperimentalLinkBrowserTest,
InScopeUrlSelf) {
InstallTestBookmarkApp();
NavigateToLaunchingPage();
const GURL in_scope_url =
https_server().GetURL(GetAppUrlHost(), GetInScopeUrlPath());
TestTabActionOpensAppWindow(
in_scope_url,
base::BindOnce(&ClickLinkAndWait,
browser()->tab_strip_model()->GetActiveWebContents(),
in_scope_url, LinkTarget::SELF, GetParam()));
ExpectNavigationResultHistogramEquals(
global_histogram(),
{{BookmarkAppNavigationThrottleResult::kCancelOpenedApp, 1},
GetAppLaunchedEntry()});
}
// Tests that clicking a link with target="_self" to a URL out of the Web App's
// scope but with the same origin doesn't open a new browser window.
IN_PROC_BROWSER_TEST_P(BookmarkAppNavigationThrottleExperimentalLinkBrowserTest,
OutOfScopeUrlSelf) {
InstallTestBookmarkApp();
NavigateToLaunchingPage();
const GURL out_of_scope_url =
https_server().GetURL(GetAppUrlHost(), GetOutOfScopeUrlPath());
TestTabActionDoesNotOpenAppWindow(
out_of_scope_url,
base::BindOnce(&ClickLinkAndWait,
browser()->tab_strip_model()->GetActiveWebContents(),
out_of_scope_url, LinkTarget::SELF, GetParam()));
ExpectNavigationResultHistogramEquals(global_histogram(), {});
}
// Tests that prerender links don't open the app.
IN_PROC_BROWSER_TEST_F(BookmarkAppNavigationThrottleExperimentalBrowserTest,
PrerenderLinks) {
prerender::PrerenderManager::SetMode(
prerender::PrerenderManager::DEPRECATED_PRERENDER_MODE_ENABLED);
InstallTestBookmarkApp();
NavigateToLaunchingPage();
TestTabActionDoesNotNavigateOrOpenAppWindow(base::BindOnce(
[](content::WebContents* web_contents, const GURL& target_url) {
std::string script = base::StringPrintf(
"(() => {"
"const prerender_link = document.createElement('link');"
"prerender_link.rel = 'prerender';"
"prerender_link.href = '%s';"
"prerender_link.addEventListener('webkitprerenderstop',"
"() => window.domAutomationController.send(true));"
"document.body.appendChild(prerender_link);"
"})();",
target_url.spec().c_str());
bool result;
ASSERT_TRUE(content::ExecuteScriptAndExtractBool(web_contents, script,
&result));
ASSERT_TRUE(result);
},
browser()->tab_strip_model()->GetActiveWebContents(),
https_server().GetURL(GetAppUrlHost(), GetInScopeUrlPath())));
ExpectNavigationResultHistogramEquals(
global_histogram(),
{{BookmarkAppNavigationThrottleResult::kCancelPrerenderContents, 1}});
}
// Tests fetch calls don't open a new App window.
IN_PROC_BROWSER_TEST_F(BookmarkAppNavigationThrottleExperimentalBrowserTest,
Fetch) {
InstallTestBookmarkApp();
NavigateToLaunchingPage();
TestTabActionDoesNotNavigateOrOpenAppWindow(base::BindOnce(
[](content::WebContents* web_contents, const GURL& target_url) {
std::string script = base::StringPrintf(
"(() => {"
"fetch('%s').then(response => {"
" window.domAutomationController.send(response.ok);"
"});"
"})();",
target_url.spec().c_str());
bool result;
ASSERT_TRUE(content::ExecuteScriptAndExtractBool(web_contents, script,
&result));
ASSERT_TRUE(result);
},
browser()->tab_strip_model()->GetActiveWebContents(),
https_server().GetURL(GetAppUrlHost(), GetInScopeUrlPath())));
// Fetch requests don't go through our NavigationHandle.
ExpectNavigationResultHistogramEquals(global_histogram(), {});
}
// Tests that clicking "Open link in new tab" to an in-scope URL opens a new
// tab in the background.
IN_PROC_BROWSER_TEST_F(BookmarkAppNavigationThrottleExperimentalBrowserTest,
ContextMenuNewTab) {
InstallTestBookmarkApp();
NavigateToLaunchingPage();
const GURL app_url = https_server().GetURL(GetAppUrlHost(), GetAppUrlPath());
TestTabActionOpensBackgroundTab(
app_url,
base::BindOnce(&ExecuteContextMenuLinkCommandAndWait,
browser()->tab_strip_model()->GetActiveWebContents(),
app_url, IDC_CONTENT_CONTEXT_OPENLINKNEWTAB));
ExpectNavigationResultHistogramEquals(
global_histogram(),
{{BookmarkAppNavigationThrottleResult::kProceedStartedFromContextMenu,
1}});
}
// Tests that clicking "Open link in new window" to an in-scope URL opens a new
// window in the foreground.
IN_PROC_BROWSER_TEST_F(BookmarkAppNavigationThrottleExperimentalBrowserTest,
ContextMenuNewWindow) {
InstallTestBookmarkApp();
NavigateToLaunchingPage();
const GURL app_url = https_server().GetURL(GetAppUrlHost(), GetAppUrlPath());
TestTabActionOpensForegroundWindow(
app_url,
base::BindOnce(&ExecuteContextMenuLinkCommandAndWait,
browser()->tab_strip_model()->GetActiveWebContents(),
app_url, IDC_CONTENT_CONTEXT_OPENLINKNEWWINDOW));
ExpectNavigationResultHistogramEquals(
global_histogram(),
{{BookmarkAppNavigationThrottleResult::kProceedStartedFromContextMenu,
1}});
}
// Tests that clicking "Open link in new tab" in an app to an in-scope URL opens
// a new foreground tab in a regular browser window.
IN_PROC_BROWSER_TEST_F(BookmarkAppNavigationThrottleExperimentalBrowserTest,
InAppContextMenuNewTab) {
InstallTestBookmarkApp();
Browser* app_browser = OpenTestBookmarkApp();
base::HistogramTester scoped_histogram;
const GURL app_url = https_server().GetURL(GetAppUrlHost(), GetAppUrlPath());
TestAppActionOpensForegroundTab(
app_browser, app_url,
base::BindOnce(&ExecuteContextMenuLinkCommandAndWait,
app_browser->tab_strip_model()->GetActiveWebContents(),
app_url, IDC_CONTENT_CONTEXT_OPENLINKNEWTAB));
ExpectNavigationResultHistogramEquals(
scoped_histogram,
{{BookmarkAppNavigationThrottleResult::kProceedStartedFromContextMenu,
1}});
}
// Tests that clicking "Open link in incognito window" to an in-scope URL opens
// an incognito window and not an app window.
IN_PROC_BROWSER_TEST_F(BookmarkAppNavigationThrottleExperimentalBrowserTest,
OpenInIncognito) {
InstallTestBookmarkApp();
NavigateToLaunchingPage();
size_t num_browsers = chrome::GetBrowserCount(profile());
int num_tabs = browser()->tab_strip_model()->count();
content::WebContents* initial_tab =
browser()->tab_strip_model()->GetActiveWebContents();
GURL initial_url = initial_tab->GetLastCommittedURL();
const GURL in_scope_url =
https_server().GetURL(GetAppUrlHost(), GetInScopeUrlPath());
auto observer = GetTestNavigationObserver(in_scope_url);
content::ContextMenuParams params;
params.page_url = initial_url;
params.link_url = in_scope_url;
TestRenderViewContextMenu menu(initial_tab->GetMainFrame(), params);
menu.Init();
menu.ExecuteCommand(IDC_CONTENT_CONTEXT_OPENLINKOFFTHERECORD,
0 /* event_flags */);
observer->WaitForNavigationFinished();
Browser* incognito_browser = chrome::FindLastActive();
EXPECT_EQ(incognito_browser->profile(), profile()->GetOffTheRecordProfile());
EXPECT_NE(browser(), incognito_browser);
EXPECT_EQ(in_scope_url, incognito_browser->tab_strip_model()
->GetActiveWebContents()
->GetLastCommittedURL());
EXPECT_EQ(num_browsers, chrome::GetBrowserCount(profile()));
EXPECT_EQ(num_tabs, browser()->tab_strip_model()->count());
EXPECT_EQ(initial_tab, browser()->tab_strip_model()->GetActiveWebContents());
EXPECT_EQ(initial_url, initial_tab->GetLastCommittedURL());