forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
/
spdy_session_pool_unittest.cc
1587 lines (1321 loc) · 61.6 KB
/
spdy_session_pool_unittest.cc
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
// Copyright (c) 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "net/spdy/spdy_session_pool.h"
#include <cstddef>
#include <utility>
#include "base/bind.h"
#include "base/memory/ref_counted.h"
#include "base/run_loop.h"
#include "base/stl_util.h"
#include "base/test/bind_test_util.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/trace_event/memory_allocator_dump.h"
#include "base/trace_event/process_memory_dump.h"
#include "base/trace_event/traced_value.h"
#include "build/build_config.h"
#include "net/dns/host_cache.h"
#include "net/http/http_network_session.h"
#include "net/log/net_log_with_source.h"
#include "net/log/test_net_log.h"
#include "net/socket/client_socket_handle.h"
#include "net/socket/socket_tag.h"
#include "net/socket/transport_client_socket_pool.h"
#include "net/spdy/spdy_session.h"
#include "net/spdy/spdy_stream_test_util.h"
#include "net/spdy/spdy_test_util_common.h"
#include "net/test/cert_test_util.h"
#include "net/test/gtest_util.h"
#include "net/test/test_certificate_data.h"
#include "net/test/test_data_directory.h"
#include "net/test/test_with_task_environment.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
using base::trace_event::MemoryAllocatorDump;
using net::test::IsError;
using net::test::IsOk;
using testing::Contains;
using testing::Eq;
using testing::Contains;
using testing::ByRef;
namespace net {
class SpdySessionPoolTest : public TestWithTaskEnvironment {
protected:
// Used by RunIPPoolingTest().
enum SpdyPoolCloseSessionsType {
SPDY_POOL_CLOSE_SESSIONS_MANUALLY,
SPDY_POOL_CLOSE_CURRENT_SESSIONS,
SPDY_POOL_CLOSE_IDLE_SESSIONS,
};
SpdySessionPoolTest() : spdy_session_pool_(nullptr) {}
void CreateNetworkSession() {
http_session_ = SpdySessionDependencies::SpdyCreateSession(&session_deps_);
spdy_session_pool_ = http_session_->spdy_session_pool();
}
void AddSSLSocketData() {
auto ssl = std::make_unique<SSLSocketDataProvider>(SYNCHRONOUS, OK);
ssl->ssl_info.cert =
ImportCertFromFile(GetTestCertsDirectory(), "spdy_pooling.pem");
ASSERT_TRUE(ssl->ssl_info.cert);
session_deps_.socket_factory->AddSSLSocketDataProvider(ssl.get());
ssl_data_vector_.push_back(std::move(ssl));
}
void RunIPPoolingTest(SpdyPoolCloseSessionsType close_sessions_type);
void RunIPPoolingDisabledTest(SSLSocketDataProvider* ssl);
size_t num_active_streams(base::WeakPtr<SpdySession> session) {
return session->active_streams_.size();
}
SpdySessionDependencies session_deps_;
std::unique_ptr<HttpNetworkSession> http_session_;
SpdySessionPool* spdy_session_pool_;
std::vector<std::unique_ptr<SSLSocketDataProvider>> ssl_data_vector_;
};
class SpdySessionRequestDelegate
: public SpdySessionPool::SpdySessionRequest::Delegate {
public:
SpdySessionRequestDelegate() = default;
~SpdySessionRequestDelegate() override = default;
void OnSpdySessionAvailable(
base::WeakPtr<SpdySession> spdy_session) override {
EXPECT_FALSE(callback_invoked_);
callback_invoked_ = true;
spdy_session_ = spdy_session;
}
bool callback_invoked() const { return callback_invoked_; }
SpdySession* spdy_session() { return spdy_session_.get(); }
private:
bool callback_invoked_ = false;
base::WeakPtr<SpdySession> spdy_session_;
DISALLOW_COPY_AND_ASSIGN(SpdySessionRequestDelegate);
};
// Attempts to set up an alias for |key| using an already existing session in
// |pool|. To do this, simulates a host resolution that returns
// |ip_address_list|.
bool TryCreateAliasedSpdySession(SpdySessionPool* pool,
const SpdySessionKey& key,
const std::string& ip_address_list,
bool enable_ip_based_pooling = true,
bool is_websocket = false) {
// The requested session must not already exist.
EXPECT_FALSE(pool->FindAvailableSession(key, enable_ip_based_pooling,
is_websocket, NetLogWithSource()));
// Create a request for the session. There should be no matching session
// (aliased or otherwise) yet. A pending request is necessary for the session
// to create an alias on host resolution completion.
std::unique_ptr<SpdySessionPool::SpdySessionRequest> request;
bool is_blocking_request_for_session = false;
SpdySessionRequestDelegate request_delegate;
EXPECT_FALSE(pool->RequestSession(
key, enable_ip_based_pooling, is_websocket, NetLogWithSource(),
/* on_blocking_request_destroyed_callback = */ base::RepeatingClosure(),
&request_delegate, &request, &is_blocking_request_for_session));
EXPECT_TRUE(request);
EXPECT_TRUE(is_blocking_request_for_session);
AddressList address_list;
EXPECT_THAT(
ParseAddressList(ip_address_list, /* canonical_name = */ std::string(),
&address_list),
IsOk());
address_list = AddressList::CopyWithPort(address_list, 443);
// Simulate a host resolution completing.
OnHostResolutionCallbackResult result =
pool->OnHostResolutionComplete(key, is_websocket, address_list);
// Spin the message loop and see if it creates an H2 session.
base::RunLoop().RunUntilIdle();
EXPECT_EQ(request_delegate.callback_invoked(),
result == OnHostResolutionCallbackResult::kMayBeDeletedAsync);
EXPECT_EQ(request_delegate.callback_invoked(),
request_delegate.spdy_session() != nullptr);
request.reset();
// Calling RequestSession again should return request_delegate.spdy_session()
// (i.e. the newly created session, if a session was created, or nullptr, if
// one was not.)
EXPECT_EQ(request_delegate.spdy_session(),
pool->RequestSession(key, enable_ip_based_pooling, is_websocket,
NetLogWithSource(),
/* on_blocking_request_destroyed_callback = */
base::RepeatingClosure(), &request_delegate,
&request, &is_blocking_request_for_session)
.get());
return request_delegate.spdy_session() != nullptr;
}
// A delegate that opens a new session when it is closed.
class SessionOpeningDelegate : public SpdyStream::Delegate {
public:
SessionOpeningDelegate(SpdySessionPool* spdy_session_pool,
const SpdySessionKey& key)
: spdy_session_pool_(spdy_session_pool),
key_(key) {}
~SessionOpeningDelegate() override = default;
void OnHeadersSent() override {}
void OnHeadersReceived(
const spdy::SpdyHeaderBlock& response_headers,
const spdy::SpdyHeaderBlock* pushed_request_headers) override {}
void OnDataReceived(std::unique_ptr<SpdyBuffer> buffer) override {}
void OnDataSent() override {}
void OnTrailers(const spdy::SpdyHeaderBlock& trailers) override {}
void OnClose(int status) override {
ignore_result(CreateFakeSpdySession(spdy_session_pool_, key_));
}
bool CanGreaseFrameType() const override { return false; }
NetLogSource source_dependency() const override { return NetLogSource(); }
private:
SpdySessionPool* const spdy_session_pool_;
const SpdySessionKey key_;
};
// Set up a SpdyStream to create a new session when it is closed.
// CloseCurrentSessions should not close the newly-created session.
TEST_F(SpdySessionPoolTest, CloseCurrentSessions) {
const char kTestHost[] = "www.foo.com";
const int kTestPort = 80;
HostPortPair test_host_port_pair(kTestHost, kTestPort);
SpdySessionKey test_key = SpdySessionKey(
test_host_port_pair, ProxyServer::Direct(), PRIVACY_MODE_DISABLED,
SpdySessionKey::IsProxySession::kFalse, SocketTag(),
NetworkIsolationKey(), false /* disable_secure_dns */);
MockConnect connect_data(SYNCHRONOUS, OK);
MockRead reads[] = {
MockRead(SYNCHRONOUS, ERR_IO_PENDING) // Stall forever.
};
StaticSocketDataProvider data(reads, base::span<MockWrite>());
data.set_connect_data(connect_data);
session_deps_.socket_factory->AddSocketDataProvider(&data);
SSLSocketDataProvider ssl(SYNCHRONOUS, OK);
session_deps_.socket_factory->AddSSLSocketDataProvider(&ssl);
CreateNetworkSession();
// Setup the first session to the first host.
base::WeakPtr<SpdySession> session =
CreateSpdySession(http_session_.get(), test_key, NetLogWithSource());
// Flush the SpdySession::OnReadComplete() task.
base::RunLoop().RunUntilIdle();
// Verify that we have sessions for everything.
EXPECT_TRUE(HasSpdySession(spdy_session_pool_, test_key));
// Set the stream to create a new session when it is closed.
base::WeakPtr<SpdyStream> spdy_stream = CreateStreamSynchronously(
SPDY_BIDIRECTIONAL_STREAM, session, GURL("http://www.foo.com"), MEDIUM,
NetLogWithSource());
SessionOpeningDelegate delegate(spdy_session_pool_, test_key);
spdy_stream->SetDelegate(&delegate);
// Close the current session.
spdy_session_pool_->CloseCurrentSessions(ERR_ABORTED);
EXPECT_TRUE(HasSpdySession(spdy_session_pool_, test_key));
}
TEST_F(SpdySessionPoolTest, CloseCurrentIdleSessions) {
MockConnect connect_data(SYNCHRONOUS, OK);
MockRead reads[] = {
MockRead(SYNCHRONOUS, ERR_IO_PENDING) // Stall forever.
};
StaticSocketDataProvider data1(reads, base::span<MockWrite>());
data1.set_connect_data(connect_data);
session_deps_.socket_factory->AddSocketDataProvider(&data1);
AddSSLSocketData();
AddSSLSocketData();
AddSSLSocketData();
CreateNetworkSession();
// Set up session 1
const GURL url1("https://www.example.org");
HostPortPair test_host_port_pair1(HostPortPair::FromURL(url1));
SpdySessionKey key1(test_host_port_pair1, ProxyServer::Direct(),
PRIVACY_MODE_DISABLED,
SpdySessionKey::IsProxySession::kFalse, SocketTag(),
NetworkIsolationKey(), false /* disable_secure_dns */);
base::WeakPtr<SpdySession> session1 =
CreateSpdySession(http_session_.get(), key1, NetLogWithSource());
base::WeakPtr<SpdyStream> spdy_stream1 = CreateStreamSynchronously(
SPDY_BIDIRECTIONAL_STREAM, session1, url1, MEDIUM, NetLogWithSource());
ASSERT_TRUE(spdy_stream1);
// Set up session 2
StaticSocketDataProvider data2(reads, base::span<MockWrite>());
session_deps_.socket_factory->AddSocketDataProvider(&data2);
const GURL url2("https://mail.example.org");
HostPortPair test_host_port_pair2(HostPortPair::FromURL(url2));
SpdySessionKey key2(test_host_port_pair2, ProxyServer::Direct(),
PRIVACY_MODE_DISABLED,
SpdySessionKey::IsProxySession::kFalse, SocketTag(),
NetworkIsolationKey(), false /* disable_secure_dns */);
base::WeakPtr<SpdySession> session2 =
CreateSpdySession(http_session_.get(), key2, NetLogWithSource());
base::WeakPtr<SpdyStream> spdy_stream2 = CreateStreamSynchronously(
SPDY_BIDIRECTIONAL_STREAM, session2, url2, MEDIUM, NetLogWithSource());
ASSERT_TRUE(spdy_stream2);
// Set up session 3
StaticSocketDataProvider data3(reads, base::span<MockWrite>());
data3.set_connect_data(connect_data);
session_deps_.socket_factory->AddSocketDataProvider(&data3);
const GURL url3("https://mail.example.com");
HostPortPair test_host_port_pair3(HostPortPair::FromURL(url3));
SpdySessionKey key3(test_host_port_pair3, ProxyServer::Direct(),
PRIVACY_MODE_DISABLED,
SpdySessionKey::IsProxySession::kFalse, SocketTag(),
NetworkIsolationKey(), false /* disable_secure_dns */);
base::WeakPtr<SpdySession> session3 =
CreateSpdySession(http_session_.get(), key3, NetLogWithSource());
base::WeakPtr<SpdyStream> spdy_stream3 = CreateStreamSynchronously(
SPDY_BIDIRECTIONAL_STREAM, session3, url3, MEDIUM, NetLogWithSource());
ASSERT_TRUE(spdy_stream3);
// All sessions are active and not closed
EXPECT_TRUE(session1->is_active());
EXPECT_TRUE(session1->IsAvailable());
EXPECT_TRUE(session2->is_active());
EXPECT_TRUE(session2->IsAvailable());
EXPECT_TRUE(session3->is_active());
EXPECT_TRUE(session3->IsAvailable());
// Should not do anything, all are active
spdy_session_pool_->CloseCurrentIdleSessions();
EXPECT_TRUE(session1->is_active());
EXPECT_TRUE(session1->IsAvailable());
EXPECT_TRUE(session2->is_active());
EXPECT_TRUE(session2->IsAvailable());
EXPECT_TRUE(session3->is_active());
EXPECT_TRUE(session3->IsAvailable());
// Make sessions 1 and 3 inactive, but keep them open.
// Session 2 still open and active
session1->CloseCreatedStream(spdy_stream1, OK);
EXPECT_FALSE(spdy_stream1);
session3->CloseCreatedStream(spdy_stream3, OK);
EXPECT_FALSE(spdy_stream3);
EXPECT_FALSE(session1->is_active());
EXPECT_TRUE(session1->IsAvailable());
EXPECT_TRUE(session2->is_active());
EXPECT_TRUE(session2->IsAvailable());
EXPECT_FALSE(session3->is_active());
EXPECT_TRUE(session3->IsAvailable());
// Should close session 1 and 3, 2 should be left open
spdy_session_pool_->CloseCurrentIdleSessions();
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(session1);
EXPECT_TRUE(session2->is_active());
EXPECT_TRUE(session2->IsAvailable());
EXPECT_FALSE(session3);
// Should not do anything
spdy_session_pool_->CloseCurrentIdleSessions();
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(session2->is_active());
EXPECT_TRUE(session2->IsAvailable());
// Make 2 not active
session2->CloseCreatedStream(spdy_stream2, OK);
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(spdy_stream2);
EXPECT_FALSE(session2->is_active());
EXPECT_TRUE(session2->IsAvailable());
// This should close session 2
spdy_session_pool_->CloseCurrentIdleSessions();
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(session2);
}
// Set up a SpdyStream to create a new session when it is closed.
// CloseAllSessions should close the newly-created session.
TEST_F(SpdySessionPoolTest, CloseAllSessions) {
const char kTestHost[] = "www.foo.com";
const int kTestPort = 80;
HostPortPair test_host_port_pair(kTestHost, kTestPort);
SpdySessionKey test_key = SpdySessionKey(
test_host_port_pair, ProxyServer::Direct(), PRIVACY_MODE_DISABLED,
SpdySessionKey::IsProxySession::kFalse, SocketTag(),
NetworkIsolationKey(), false /* disable_secure_dns */);
MockConnect connect_data(SYNCHRONOUS, OK);
MockRead reads[] = {
MockRead(SYNCHRONOUS, ERR_IO_PENDING) // Stall forever.
};
StaticSocketDataProvider data(reads, base::span<MockWrite>());
data.set_connect_data(connect_data);
session_deps_.socket_factory->AddSocketDataProvider(&data);
SSLSocketDataProvider ssl(SYNCHRONOUS, OK);
session_deps_.socket_factory->AddSSLSocketDataProvider(&ssl);
CreateNetworkSession();
// Setup the first session to the first host.
base::WeakPtr<SpdySession> session =
CreateSpdySession(http_session_.get(), test_key, NetLogWithSource());
// Flush the SpdySession::OnReadComplete() task.
base::RunLoop().RunUntilIdle();
// Verify that we have sessions for everything.
EXPECT_TRUE(HasSpdySession(spdy_session_pool_, test_key));
// Set the stream to create a new session when it is closed.
base::WeakPtr<SpdyStream> spdy_stream = CreateStreamSynchronously(
SPDY_BIDIRECTIONAL_STREAM, session, GURL("http://www.foo.com"), MEDIUM,
NetLogWithSource());
SessionOpeningDelegate delegate(spdy_session_pool_, test_key);
spdy_stream->SetDelegate(&delegate);
// Close the current session.
spdy_session_pool_->CloseAllSessions();
EXPECT_FALSE(HasSpdySession(spdy_session_pool_, test_key));
}
// This test has three variants, one for each style of closing the connection.
// If |clean_via_close_current_sessions| is SPDY_POOL_CLOSE_SESSIONS_MANUALLY,
// the sessions are closed manually, calling SpdySessionPool::Remove() directly.
// If |clean_via_close_current_sessions| is SPDY_POOL_CLOSE_CURRENT_SESSIONS,
// sessions are closed with SpdySessionPool::CloseCurrentSessions().
// If |clean_via_close_current_sessions| is SPDY_POOL_CLOSE_IDLE_SESSIONS,
// sessions are closed with SpdySessionPool::CloseIdleSessions().
void SpdySessionPoolTest::RunIPPoolingTest(
SpdyPoolCloseSessionsType close_sessions_type) {
const int kTestPort = 443;
struct TestHosts {
std::string url;
std::string name;
std::string iplist;
SpdySessionKey key;
} test_hosts[] = {
{"http://www.example.org", "www.example.org",
"192.0.2.33,192.168.0.1,192.168.0.5"},
{"http://mail.example.org", "mail.example.org",
"192.168.0.2,192.168.0.3,192.168.0.5,192.0.2.33"},
{"http://mail.example.com", "mail.example.com",
"192.168.0.4,192.168.0.3"},
};
for (size_t i = 0; i < base::size(test_hosts); i++) {
session_deps_.host_resolver->rules()->AddIPLiteralRule(
test_hosts[i].name, test_hosts[i].iplist, std::string());
test_hosts[i].key = SpdySessionKey(
HostPortPair(test_hosts[i].name, kTestPort), ProxyServer::Direct(),
PRIVACY_MODE_DISABLED, SpdySessionKey::IsProxySession::kFalse,
SocketTag(), NetworkIsolationKey(), false /* disable_secure_dns */);
}
MockConnect connect_data(SYNCHRONOUS, OK);
MockRead reads[] = {
MockRead(SYNCHRONOUS, ERR_IO_PENDING) // Stall forever.
};
StaticSocketDataProvider data1(reads, base::span<MockWrite>());
data1.set_connect_data(connect_data);
session_deps_.socket_factory->AddSocketDataProvider(&data1);
AddSSLSocketData();
CreateNetworkSession();
// Setup the first session to the first host.
base::WeakPtr<SpdySession> session = CreateSpdySession(
http_session_.get(), test_hosts[0].key, NetLogWithSource());
// Flush the SpdySession::OnReadComplete() task.
base::RunLoop().RunUntilIdle();
// The third host has no overlap with the first, so it can't pool IPs.
EXPECT_FALSE(TryCreateAliasedSpdySession(
spdy_session_pool_, test_hosts[2].key, test_hosts[2].iplist));
// The second host overlaps with the first, and should IP pool.
EXPECT_TRUE(TryCreateAliasedSpdySession(spdy_session_pool_, test_hosts[1].key,
test_hosts[1].iplist));
// However, if IP pooling is disabled, FindAvailableSession() should not find
// |session| for the second host.
base::WeakPtr<SpdySession> session1 =
spdy_session_pool_->FindAvailableSession(
test_hosts[1].key, /* enable_ip_based_pooling = */ false,
/* is_websocket = */ false, NetLogWithSource());
EXPECT_FALSE(session1);
// Verify that the second host, through a proxy, won't share the IP, even if
// the IP list matches.
SpdySessionKey proxy_key(
test_hosts[1].key.host_port_pair(),
ProxyServer::FromPacString("HTTP http://proxy.foo.com/"),
PRIVACY_MODE_DISABLED, SpdySessionKey::IsProxySession::kFalse,
SocketTag(), NetworkIsolationKey(), false /* disable_secure_dns */);
EXPECT_FALSE(TryCreateAliasedSpdySession(spdy_session_pool_, proxy_key,
test_hosts[1].iplist));
// Verify that the second host, with a different disable_secure_dns value,
// won't share the IP, even if the IP list matches.
SpdySessionKey disable_secure_dns_key(
test_hosts[1].key.host_port_pair(), ProxyServer::Direct(),
PRIVACY_MODE_DISABLED, SpdySessionKey::IsProxySession::kFalse,
SocketTag(), NetworkIsolationKey(), true /* disable_secure_dns */);
EXPECT_FALSE(TryCreateAliasedSpdySession(
spdy_session_pool_, disable_secure_dns_key, test_hosts[1].iplist));
// Overlap between 2 and 3 is not transitive to 1.
EXPECT_FALSE(TryCreateAliasedSpdySession(
spdy_session_pool_, test_hosts[2].key, test_hosts[2].iplist));
// Create a new session to host 2.
StaticSocketDataProvider data2(reads, base::span<MockWrite>());
data2.set_connect_data(connect_data);
session_deps_.socket_factory->AddSocketDataProvider(&data2);
AddSSLSocketData();
base::WeakPtr<SpdySession> session2 = CreateSpdySession(
http_session_.get(), test_hosts[2].key, NetLogWithSource());
// Verify that we have sessions for everything.
EXPECT_TRUE(HasSpdySession(spdy_session_pool_, test_hosts[0].key));
EXPECT_TRUE(HasSpdySession(spdy_session_pool_, test_hosts[1].key));
EXPECT_TRUE(HasSpdySession(spdy_session_pool_, test_hosts[2].key));
// Grab the session to host 1 and verify that it is the same session
// we got with host 0, and that is a different from host 2's session.
session1 = spdy_session_pool_->FindAvailableSession(
test_hosts[1].key, /* enable_ip_based_pooling = */ true,
/* is_websocket = */ false, NetLogWithSource());
EXPECT_EQ(session.get(), session1.get());
EXPECT_NE(session2.get(), session1.get());
// Remove the aliases and observe that we still have a session for host1.
SpdySessionPoolPeer pool_peer(spdy_session_pool_);
pool_peer.RemoveAliases(test_hosts[0].key);
pool_peer.RemoveAliases(test_hosts[1].key);
EXPECT_TRUE(HasSpdySession(spdy_session_pool_, test_hosts[1].key));
// Cleanup the sessions.
switch (close_sessions_type) {
case SPDY_POOL_CLOSE_SESSIONS_MANUALLY:
session->CloseSessionOnError(ERR_ABORTED, std::string());
session2->CloseSessionOnError(ERR_ABORTED, std::string());
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(session);
EXPECT_FALSE(session2);
break;
case SPDY_POOL_CLOSE_CURRENT_SESSIONS:
spdy_session_pool_->CloseCurrentSessions(ERR_ABORTED);
break;
case SPDY_POOL_CLOSE_IDLE_SESSIONS:
GURL url(test_hosts[0].url);
base::WeakPtr<SpdyStream> spdy_stream = CreateStreamSynchronously(
SPDY_BIDIRECTIONAL_STREAM, session, url, MEDIUM, NetLogWithSource());
GURL url1(test_hosts[1].url);
base::WeakPtr<SpdyStream> spdy_stream1 =
CreateStreamSynchronously(SPDY_BIDIRECTIONAL_STREAM, session1, url1,
MEDIUM, NetLogWithSource());
GURL url2(test_hosts[2].url);
base::WeakPtr<SpdyStream> spdy_stream2 =
CreateStreamSynchronously(SPDY_BIDIRECTIONAL_STREAM, session2, url2,
MEDIUM, NetLogWithSource());
// Close streams to make spdy_session and spdy_session1 inactive.
session->CloseCreatedStream(spdy_stream, OK);
EXPECT_FALSE(spdy_stream);
session1->CloseCreatedStream(spdy_stream1, OK);
EXPECT_FALSE(spdy_stream1);
// Check spdy_session and spdy_session1 are not closed.
EXPECT_FALSE(session->is_active());
EXPECT_TRUE(session->IsAvailable());
EXPECT_FALSE(session1->is_active());
EXPECT_TRUE(session1->IsAvailable());
EXPECT_TRUE(session2->is_active());
EXPECT_TRUE(session2->IsAvailable());
// Test that calling CloseIdleSessions, does not cause a crash.
// http://crbug.com/181400
spdy_session_pool_->CloseCurrentIdleSessions();
base::RunLoop().RunUntilIdle();
// Verify spdy_session and spdy_session1 are closed.
EXPECT_FALSE(session);
EXPECT_FALSE(session1);
EXPECT_TRUE(session2->is_active());
EXPECT_TRUE(session2->IsAvailable());
spdy_stream2->Cancel(ERR_ABORTED);
EXPECT_FALSE(spdy_stream);
EXPECT_FALSE(spdy_stream1);
EXPECT_FALSE(spdy_stream2);
session2->CloseSessionOnError(ERR_ABORTED, std::string());
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(session2);
break;
}
// Verify that the map is all cleaned up.
EXPECT_FALSE(HasSpdySession(spdy_session_pool_, test_hosts[0].key));
EXPECT_FALSE(HasSpdySession(spdy_session_pool_, test_hosts[1].key));
EXPECT_FALSE(HasSpdySession(spdy_session_pool_, test_hosts[2].key));
EXPECT_FALSE(TryCreateAliasedSpdySession(
spdy_session_pool_, test_hosts[0].key, test_hosts[0].iplist));
EXPECT_FALSE(TryCreateAliasedSpdySession(
spdy_session_pool_, test_hosts[1].key, test_hosts[1].iplist));
EXPECT_FALSE(TryCreateAliasedSpdySession(
spdy_session_pool_, test_hosts[2].key, test_hosts[2].iplist));
}
void SpdySessionPoolTest::RunIPPoolingDisabledTest(SSLSocketDataProvider* ssl) {
const int kTestPort = 443;
struct TestHosts {
std::string name;
std::string iplist;
SpdySessionKey key;
} test_hosts[] = {
{"www.webkit.org", "192.0.2.33,192.168.0.1,192.168.0.5"},
{"js.webkit.com", "192.168.0.4,192.168.0.1,192.0.2.33"},
};
session_deps_.host_resolver->set_synchronous_mode(true);
for (size_t i = 0; i < base::size(test_hosts); i++) {
session_deps_.host_resolver->rules()->AddIPLiteralRule(
test_hosts[i].name, test_hosts[i].iplist, std::string());
// Setup a SpdySessionKey
test_hosts[i].key = SpdySessionKey(
HostPortPair(test_hosts[i].name, kTestPort), ProxyServer::Direct(),
PRIVACY_MODE_DISABLED, SpdySessionKey::IsProxySession::kFalse,
SocketTag(), NetworkIsolationKey(), false /* disable_secure_dns */);
}
MockRead reads[] = {
MockRead(ASYNC, ERR_IO_PENDING),
};
StaticSocketDataProvider data(reads, base::span<MockWrite>());
session_deps_.socket_factory->AddSocketDataProvider(&data);
session_deps_.socket_factory->AddSSLSocketDataProvider(ssl);
CreateNetworkSession();
base::WeakPtr<SpdySession> spdy_session = CreateSpdySession(
http_session_.get(), test_hosts[0].key, NetLogWithSource());
EXPECT_TRUE(
HasSpdySession(http_session_->spdy_session_pool(), test_hosts[0].key));
EXPECT_FALSE(TryCreateAliasedSpdySession(
spdy_session_pool_, test_hosts[1].key, test_hosts[1].iplist,
/* enable_ip_based_pooling = */ false));
http_session_->spdy_session_pool()->CloseAllSessions();
}
TEST_F(SpdySessionPoolTest, IPPooling) {
RunIPPoolingTest(SPDY_POOL_CLOSE_SESSIONS_MANUALLY);
}
TEST_F(SpdySessionPoolTest, IPPoolingCloseCurrentSessions) {
RunIPPoolingTest(SPDY_POOL_CLOSE_CURRENT_SESSIONS);
}
TEST_F(SpdySessionPoolTest, IPPoolingCloseIdleSessions) {
RunIPPoolingTest(SPDY_POOL_CLOSE_IDLE_SESSIONS);
}
// Regression test for https://crbug.com/643025.
TEST_F(SpdySessionPoolTest, IPPoolingNetLog) {
// Define two hosts with identical IP address.
const int kTestPort = 443;
struct TestHosts {
std::string name;
std::string iplist;
SpdySessionKey key;
} test_hosts[] = {
{"www.example.org", "192.168.0.1"}, {"mail.example.org", "192.168.0.1"},
};
// Populate the HostResolver cache.
session_deps_.host_resolver->set_synchronous_mode(true);
for (size_t i = 0; i < base::size(test_hosts); i++) {
session_deps_.host_resolver->rules()->AddIPLiteralRule(
test_hosts[i].name, test_hosts[i].iplist, std::string());
test_hosts[i].key = SpdySessionKey(
HostPortPair(test_hosts[i].name, kTestPort), ProxyServer::Direct(),
PRIVACY_MODE_DISABLED, SpdySessionKey::IsProxySession::kFalse,
SocketTag(), NetworkIsolationKey(), false /* disable_secure_dns */);
}
MockRead reads[] = {MockRead(SYNCHRONOUS, ERR_IO_PENDING)};
StaticSocketDataProvider data(reads, base::span<MockWrite>());
MockConnect connect_data(SYNCHRONOUS, OK);
data.set_connect_data(connect_data);
session_deps_.socket_factory->AddSocketDataProvider(&data);
AddSSLSocketData();
CreateNetworkSession();
// Open SpdySession to the first host.
base::WeakPtr<SpdySession> session0 = CreateSpdySession(
http_session_.get(), test_hosts[0].key, NetLogWithSource());
// The second host should pool to the existing connection.
RecordingBoundTestNetLog net_log;
base::HistogramTester histogram_tester;
EXPECT_TRUE(TryCreateAliasedSpdySession(spdy_session_pool_, test_hosts[1].key,
test_hosts[1].iplist));
histogram_tester.ExpectTotalCount("Net.SpdySessionGet", 1);
base::WeakPtr<SpdySession> session1 =
spdy_session_pool_->FindAvailableSession(
test_hosts[1].key, /* enable_ip_based_pooling = */ true,
/* is_websocket = */ false, net_log.bound());
EXPECT_EQ(session0.get(), session1.get());
ASSERT_EQ(1u, net_log.GetSize());
histogram_tester.ExpectTotalCount("Net.SpdySessionGet", 2);
// FindAvailableSession() should have logged a netlog event indicating IP
// pooling.
auto entry_list = net_log.GetEntries();
EXPECT_EQ(
NetLogEventType::HTTP2_SESSION_POOL_FOUND_EXISTING_SESSION_FROM_IP_POOL,
entry_list[0].type);
// Both FindAvailableSession() calls (including one from
// TryCreateAliasedSpdySession) should log histogram entries indicating IP
// pooling.
histogram_tester.ExpectUniqueSample("Net.SpdySessionGet", 2, 2);
}
TEST_F(SpdySessionPoolTest, IPPoolingDisabled) {
// Define two hosts with identical IP address.
const int kTestPort = 443;
struct TestHosts {
std::string name;
std::string iplist;
SpdySessionKey key;
} test_hosts[] = {
{"www.example.org", "192.168.0.1"}, {"mail.example.org", "192.168.0.1"},
};
// Populate the HostResolver cache.
session_deps_.host_resolver->set_synchronous_mode(true);
for (size_t i = 0; i < base::size(test_hosts); i++) {
session_deps_.host_resolver->rules()->AddIPLiteralRule(
test_hosts[i].name, test_hosts[i].iplist, std::string());
test_hosts[i].key = SpdySessionKey(
HostPortPair(test_hosts[i].name, kTestPort), ProxyServer::Direct(),
PRIVACY_MODE_DISABLED, SpdySessionKey::IsProxySession::kFalse,
SocketTag(), NetworkIsolationKey(), false /* disable_secure_dns */);
}
MockRead reads[] = {MockRead(SYNCHRONOUS, ERR_IO_PENDING)};
StaticSocketDataProvider data(reads, base::span<MockWrite>());
MockConnect connect_data(SYNCHRONOUS, OK);
data.set_connect_data(connect_data);
session_deps_.socket_factory->AddSocketDataProvider(&data);
AddSSLSocketData();
MockRead reads1[] = {MockRead(SYNCHRONOUS, ERR_IO_PENDING)};
StaticSocketDataProvider data1(reads1, base::span<MockWrite>());
MockConnect connect_data1(SYNCHRONOUS, OK);
data1.set_connect_data(connect_data1);
session_deps_.socket_factory->AddSocketDataProvider(&data1);
AddSSLSocketData();
CreateNetworkSession();
// Open SpdySession to the first host.
base::WeakPtr<SpdySession> session0 = CreateSpdySession(
http_session_.get(), test_hosts[0].key, NetLogWithSource());
// |test_hosts[1]| should pool to the existing connection.
EXPECT_TRUE(TryCreateAliasedSpdySession(spdy_session_pool_, test_hosts[1].key,
test_hosts[1].iplist));
base::WeakPtr<SpdySession> session1 =
spdy_session_pool_->FindAvailableSession(
test_hosts[1].key, /* enable_ip_based_pooling = */ true,
/* is_websocket = */ false, NetLogWithSource());
EXPECT_EQ(session0.get(), session1.get());
// A request to the second host should not pool to the existing connection if
// IP based pooling is disabled.
session1 = spdy_session_pool_->FindAvailableSession(
test_hosts[1].key, /* enable_ip_based_pooling = */ false,
/* is_websocket = */ false, NetLogWithSource());
EXPECT_FALSE(session1);
// It should be possible to open a new SpdySession, even if a previous call to
// FindAvailableSession() linked the second key to the first connection in the
// IP pooled bucket of SpdySessionPool::available_session_map_.
session1 = CreateSpdySessionWithIpBasedPoolingDisabled(
http_session_.get(), test_hosts[1].key, NetLogWithSource());
EXPECT_TRUE(session1);
EXPECT_NE(session0.get(), session1.get());
}
// Verifies that an SSL connection with client authentication disables SPDY IP
// pooling.
TEST_F(SpdySessionPoolTest, IPPoolingClientCert) {
SSLSocketDataProvider ssl(ASYNC, OK);
ssl.ssl_info.cert = X509Certificate::CreateFromBytes(
reinterpret_cast<const char*>(webkit_der), sizeof(webkit_der));
ASSERT_TRUE(ssl.ssl_info.cert);
ssl.ssl_info.client_cert_sent = true;
ssl.next_proto = kProtoHTTP2;
RunIPPoolingDisabledTest(&ssl);
}
// Construct a Pool with SpdySessions in various availability states. Simulate
// an IP address change. Ensure sessions gracefully shut down. Regression test
// for crbug.com/379469.
TEST_F(SpdySessionPoolTest, IPAddressChanged) {
MockConnect connect_data(SYNCHRONOUS, OK);
session_deps_.host_resolver->set_synchronous_mode(true);
// This isn't testing anything having to do with SPDY frames; we
// can ignore issues of how dependencies are set. We default to
// setting them (when doing the appropriate protocol) since that's
// where we're eventually headed for all HTTP/2 connections.
SpdyTestUtil spdy_util;
MockRead reads[] = {
MockRead(SYNCHRONOUS, ERR_IO_PENDING) // Stall forever.
};
spdy::SpdySerializedFrame req(
spdy_util.ConstructSpdyGet("http://www.example.org", 1, MEDIUM));
MockWrite writes[] = {CreateMockWrite(req, 1)};
StaticSocketDataProvider dataA(reads, writes);
dataA.set_connect_data(connect_data);
session_deps_.socket_factory->AddSocketDataProvider(&dataA);
AddSSLSocketData();
CreateNetworkSession();
// Set up session A: Going away, but with an active stream.
const std::string kTestHostA("www.example.org");
HostPortPair test_host_port_pairA(kTestHostA, 80);
SpdySessionKey keyA(test_host_port_pairA, ProxyServer::Direct(),
PRIVACY_MODE_DISABLED,
SpdySessionKey::IsProxySession::kFalse, SocketTag(),
NetworkIsolationKey(), false /* disable_secure_dns */);
base::WeakPtr<SpdySession> sessionA =
CreateSpdySession(http_session_.get(), keyA, NetLogWithSource());
GURL urlA("http://www.example.org");
base::WeakPtr<SpdyStream> spdy_streamA = CreateStreamSynchronously(
SPDY_BIDIRECTIONAL_STREAM, sessionA, urlA, MEDIUM, NetLogWithSource());
test::StreamDelegateDoNothing delegateA(spdy_streamA);
spdy_streamA->SetDelegate(&delegateA);
spdy::SpdyHeaderBlock headers(spdy_util.ConstructGetHeaderBlock(urlA.spec()));
spdy_streamA->SendRequestHeaders(std::move(headers), NO_MORE_DATA_TO_SEND);
base::RunLoop().RunUntilIdle(); // Allow headers to write.
EXPECT_TRUE(delegateA.send_headers_completed());
sessionA->MakeUnavailable();
EXPECT_TRUE(sessionA->IsGoingAway());
EXPECT_FALSE(delegateA.StreamIsClosed());
// Set up session B: Available, with a created stream.
StaticSocketDataProvider dataB(reads, writes);
dataB.set_connect_data(connect_data);
session_deps_.socket_factory->AddSocketDataProvider(&dataB);
AddSSLSocketData();
const std::string kTestHostB("mail.example.org");
HostPortPair test_host_port_pairB(kTestHostB, 80);
SpdySessionKey keyB(test_host_port_pairB, ProxyServer::Direct(),
PRIVACY_MODE_DISABLED,
SpdySessionKey::IsProxySession::kFalse, SocketTag(),
NetworkIsolationKey(), false /* disable_secure_dns */);
base::WeakPtr<SpdySession> sessionB =
CreateSpdySession(http_session_.get(), keyB, NetLogWithSource());
EXPECT_TRUE(sessionB->IsAvailable());
GURL urlB("http://mail.example.org");
base::WeakPtr<SpdyStream> spdy_streamB = CreateStreamSynchronously(
SPDY_BIDIRECTIONAL_STREAM, sessionB, urlB, MEDIUM, NetLogWithSource());
test::StreamDelegateDoNothing delegateB(spdy_streamB);
spdy_streamB->SetDelegate(&delegateB);
// Set up session C: Draining.
StaticSocketDataProvider dataC(reads, writes);
dataC.set_connect_data(connect_data);
session_deps_.socket_factory->AddSocketDataProvider(&dataC);
AddSSLSocketData();
const std::string kTestHostC("mail.example.com");
HostPortPair test_host_port_pairC(kTestHostC, 80);
SpdySessionKey keyC(test_host_port_pairC, ProxyServer::Direct(),
PRIVACY_MODE_DISABLED,
SpdySessionKey::IsProxySession::kFalse, SocketTag(),
NetworkIsolationKey(), false /* disable_secure_dns */);
base::WeakPtr<SpdySession> sessionC =
CreateSpdySession(http_session_.get(), keyC, NetLogWithSource());
sessionC->CloseSessionOnError(ERR_HTTP2_PROTOCOL_ERROR, "Error!");
EXPECT_TRUE(sessionC->IsDraining());
spdy_session_pool_->OnIPAddressChanged();
#if defined(OS_ANDROID) || defined(OS_WIN) || defined(OS_IOS)
EXPECT_TRUE(sessionA->IsGoingAway());
EXPECT_TRUE(sessionB->IsDraining());
EXPECT_TRUE(sessionC->IsDraining());
EXPECT_EQ(1u,
num_active_streams(sessionA)); // Active stream is still active.
EXPECT_FALSE(delegateA.StreamIsClosed());
EXPECT_TRUE(delegateB.StreamIsClosed()); // Created stream was closed.
EXPECT_THAT(delegateB.WaitForClose(), IsError(ERR_NETWORK_CHANGED));
sessionA->CloseSessionOnError(ERR_ABORTED, "Closing");
sessionB->CloseSessionOnError(ERR_ABORTED, "Closing");
EXPECT_TRUE(delegateA.StreamIsClosed());
EXPECT_THAT(delegateA.WaitForClose(), IsError(ERR_ABORTED));
#else
EXPECT_TRUE(sessionA->IsDraining());
EXPECT_TRUE(sessionB->IsDraining());
EXPECT_TRUE(sessionC->IsDraining());
// Both streams were closed with an error.
EXPECT_TRUE(delegateA.StreamIsClosed());
EXPECT_THAT(delegateA.WaitForClose(), IsError(ERR_NETWORK_CHANGED));
EXPECT_TRUE(delegateB.StreamIsClosed());
EXPECT_THAT(delegateB.WaitForClose(), IsError(ERR_NETWORK_CHANGED));
#endif // defined(OS_ANDROID) || defined(OS_WIN) || defined(OS_IOS)
}
// Regression test for https://crbug.com/789791.
TEST_F(SpdySessionPoolTest, HandleIPAddressChangeThenShutdown) {
MockRead reads[] = {MockRead(SYNCHRONOUS, ERR_IO_PENDING)};
SpdyTestUtil spdy_util;
spdy::SpdySerializedFrame req(
spdy_util.ConstructSpdyGet(kDefaultUrl, 1, MEDIUM));
MockWrite writes[] = {CreateMockWrite(req, 1)};
StaticSocketDataProvider data(reads, writes);
MockConnect connect_data(SYNCHRONOUS, OK);
data.set_connect_data(connect_data);
session_deps_.socket_factory->AddSocketDataProvider(&data);
AddSSLSocketData();
CreateNetworkSession();
const GURL url(kDefaultUrl);
SpdySessionKey key(HostPortPair::FromURL(url), ProxyServer::Direct(),
PRIVACY_MODE_DISABLED,
SpdySessionKey::IsProxySession::kFalse, SocketTag(),
NetworkIsolationKey(), false /* disable_secure_dns */);
base::WeakPtr<SpdySession> session =
CreateSpdySession(http_session_.get(), key, NetLogWithSource());
base::WeakPtr<SpdyStream> spdy_stream = CreateStreamSynchronously(
SPDY_BIDIRECTIONAL_STREAM, session, url, MEDIUM, NetLogWithSource());
test::StreamDelegateDoNothing delegate(spdy_stream);
spdy_stream->SetDelegate(&delegate);
spdy::SpdyHeaderBlock headers(spdy_util.ConstructGetHeaderBlock(url.spec()));
spdy_stream->SendRequestHeaders(std::move(headers), NO_MORE_DATA_TO_SEND);
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(delegate.send_headers_completed());
spdy_session_pool_->OnIPAddressChanged();
#if defined(OS_ANDROID) || defined(OS_WIN) || defined(OS_IOS)
EXPECT_EQ(1u, num_active_streams(session));
EXPECT_TRUE(session->IsGoingAway());
EXPECT_FALSE(session->IsDraining());
#else
EXPECT_EQ(0u, num_active_streams(session));
EXPECT_FALSE(session->IsGoingAway());
EXPECT_TRUE(session->IsDraining());
#endif // defined(OS_ANDROID) || defined(OS_WIN) || defined(OS_IOS)
http_session_.reset();
data.AllReadDataConsumed();
data.AllWriteDataConsumed();
}