forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
/
content_hash_fetcher_unittest.cc
253 lines (210 loc) · 9.72 KB
/
content_hash_fetcher_unittest.cc
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <memory>
#include "base/bind.h"
#include "base/callback.h"
#include "base/callback_helpers.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/memory/weak_ptr.h"
#include "base/path_service.h"
#include "base/version.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/test/browser_task_environment.h"
#include "extensions/browser/content_hash_fetcher.h"
#include "extensions/browser/content_verifier/test_utils.h"
#include "extensions/browser/extensions_test.h"
#include "extensions/common/constants.h"
#include "extensions/common/extension_paths.h"
#include "extensions/common/file_util.h"
#include "mojo/public/cpp/bindings/binding_set.h"
#include "mojo/public/cpp/bindings/pending_remote.h"
#include "net/http/http_status_code.h"
#include "services/network/public/cpp/shared_url_loader_factory.h"
#include "services/network/public/cpp/weak_wrapper_shared_url_loader_factory.h"
#include "services/network/public/mojom/url_loader_factory.mojom.h"
#include "services/network/test/test_url_loader_factory.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/zlib/google/zip.h"
namespace extensions {
// Installs and tests various functionality of an extension loaded without
// verified_contents.json file.
class ContentHashFetcherTest : public ExtensionsTest {
public:
ContentHashFetcherTest()
// We need a real IO thread to be able to entercept the network request
// for the missing verified_contents.json file.
: ExtensionsTest(content::BrowserTaskEnvironment::REAL_IO_THREAD),
test_shared_loader_factory_(
base::MakeRefCounted<network::WeakWrapperSharedURLLoaderFactory>(
&test_url_loader_factory_)) {}
~ContentHashFetcherTest() override {}
bool LoadTestExtension() {
test_dir_base_ = GetTestPath(
base::FilePath(FILE_PATH_LITERAL("missing_verified_contents")));
// We unzip the extension source to a temp directory to simulate it being
// installed there, because the ContentHashFetcher will create the
// _metadata/ directory within the extension install dir and write the
// fetched verified_contents.json file there.
extension_ =
UnzipToTempDirAndLoad(test_dir_base_.AppendASCII("source.zip"));
if (!extension_.get())
return false;
// Make sure there isn't already a verified_contents.json file there.
EXPECT_FALSE(VerifiedContentsFileExists());
delegate_ = std::make_unique<MockContentVerifierDelegate>();
fetch_url_ = delegate_->GetSignatureFetchUrl(extension_->id(),
extension_->version());
return true;
}
std::unique_ptr<ContentHashResult> DoHashFetch() {
if (!extension_.get() || !delegate_.get()) {
ADD_FAILURE() << "No valid extension_ or delegate_, "
"did you forget to call LoadTestExtension()?";
return nullptr;
}
mojo::PendingRemote<network::mojom::URLLoaderFactory>
url_loader_factory_remote;
test_url_loader_factory_.Clone(
url_loader_factory_remote.InitWithNewPipeAndPassReceiver());
std::unique_ptr<ContentHashResult> result =
ContentHashWaiter().CreateAndWaitForCallback(
ContentHash::FetchKey(extension_->id(), extension_->path(),
extension_->version(),
std::move(url_loader_factory_remote),
fetch_url_, delegate_->GetPublicKey()),
ContentVerifierDelegate::VerifierSourceType::SIGNED_HASHES);
delegate_.reset();
return result;
}
const GURL& fetch_url() { return fetch_url_; }
const base::FilePath& extension_root() { return extension_->path(); }
bool VerifiedContentsFileExists() const {
return base::PathExists(
file_util::GetVerifiedContentsPath(extension_->path()));
}
base::FilePath GetResourcePath(const std::string& resource_filename) const {
return test_dir_base_.AppendASCII(resource_filename);
}
// Registers interception of requests for |url| to respond with the contents
// of the file at |response_path|.
void RegisterInterception(const GURL& url,
const base::FilePath& response_path) {
ASSERT_TRUE(base::PathExists(response_path));
std::string data;
EXPECT_TRUE(ReadFileToString(response_path, &data));
constexpr size_t kMaxFileSize = 1024 * 2; // Using 2k file size for safety.
ASSERT_LE(data.length(), kMaxFileSize);
test_url_loader_factory_.AddResponse(url.spec(), data);
}
void RegisterInterceptionWithFailure(const GURL& url, int net_error) {
test_url_loader_factory_.AddResponse(
GURL(url), network::mojom::URLResponseHead::New(), std::string(),
network::URLLoaderCompletionStatus(net_error));
}
private:
// Helper to get files from our subdirectory in the general extensions test
// data dir.
base::FilePath GetTestPath(const base::FilePath& relative_path) {
base::FilePath base_path;
EXPECT_TRUE(base::PathService::Get(extensions::DIR_TEST_DATA, &base_path));
base_path = base_path.AppendASCII("content_hash_fetcher");
return base_path.Append(relative_path);
}
// Unzips the extension source from |extension_zip| into a temporary
// directory and loads it, returning the resuling Extension object.
scoped_refptr<Extension> UnzipToTempDirAndLoad(
const base::FilePath& extension_zip) {
EXPECT_TRUE(temp_dir_.CreateUniqueTempDir());
base::FilePath destination = temp_dir_.GetPath();
EXPECT_TRUE(zip::Unzip(extension_zip, destination));
std::string error;
scoped_refptr<Extension> extension = file_util::LoadExtension(
destination, Manifest::INTERNAL, 0 /* flags */, &error);
EXPECT_NE(nullptr, extension.get()) << " error:'" << error << "'";
return extension;
}
scoped_refptr<network::SharedURLLoaderFactory> test_shared_loader_factory_;
network::TestURLLoaderFactory test_url_loader_factory_;
base::ScopedTempDir temp_dir_;
GURL fetch_url_;
base::FilePath test_dir_base_;
std::unique_ptr<MockContentVerifierDelegate> delegate_;
scoped_refptr<Extension> extension_;
DISALLOW_COPY_AND_ASSIGN(ContentHashFetcherTest);
};
// This tests our ability to successfully fetch, parse, and validate a missing
// verified_contents.json file for an extension.
TEST_F(ContentHashFetcherTest, MissingVerifiedContents) {
ASSERT_TRUE(LoadTestExtension());
RegisterInterception(fetch_url(), GetResourcePath("verified_contents.json"));
// Make sure the fetch was successful.
std::unique_ptr<ContentHashResult> result = DoHashFetch();
ASSERT_TRUE(result.get());
EXPECT_TRUE(result->success);
EXPECT_FALSE(result->was_cancelled);
EXPECT_TRUE(result->mismatch_paths.empty());
// Make sure the verified_contents.json file was written into the extension's
// install dir.
EXPECT_TRUE(VerifiedContentsFileExists());
}
// Tests that if the network fetches invalid verified_contents.json, failure
// happens correctly.
TEST_F(ContentHashFetcherTest, FetchInvalidVerifiedContents) {
ASSERT_TRUE(LoadTestExtension());
// Simulate invalid verified_contents.json fetch by providing a modified and
// incorrect json file.
// invalid_verified_contents.json is a modified version of
// verified_contents.json, with one hash character garbled.
RegisterInterception(fetch_url(),
GetResourcePath("invalid_verified_contents.json"));
std::unique_ptr<ContentHashResult> result = DoHashFetch();
ASSERT_TRUE(result.get());
EXPECT_FALSE(result->success);
EXPECT_FALSE(result->was_cancelled);
EXPECT_TRUE(result->mismatch_paths.empty());
// TODO(lazyboy): This should be EXPECT_FALSE, we shouldn't be writing
// verified_contents.json file if it didn't succeed.
//// Make sure the verified_contents.json file was *not* written into the
//// extension's install dir.
// EXPECT_FALSE(VerifiedContentsFileExists());
EXPECT_TRUE(VerifiedContentsFileExists());
}
// Tests that if the verified_contents.json network request 404s, failure
// happens as expected.
TEST_F(ContentHashFetcherTest, Fetch404VerifiedContents) {
ASSERT_TRUE(LoadTestExtension());
RegisterInterceptionWithFailure(fetch_url(), net::HTTP_NOT_FOUND);
// Make sure the fetch was *not* successful.
std::unique_ptr<ContentHashResult> result = DoHashFetch();
ASSERT_TRUE(result.get());
EXPECT_FALSE(result->success);
EXPECT_FALSE(result->was_cancelled);
EXPECT_TRUE(result->mismatch_paths.empty());
// Make sure the verified_contents.json file was *not* written into the
// extension's install dir.
EXPECT_FALSE(VerifiedContentsFileExists());
}
// Similar to MissingVerifiedContents, but tests the case where the extension
// actually has corruption.
TEST_F(ContentHashFetcherTest, MissingVerifiedContentsAndCorrupt) {
ASSERT_TRUE(LoadTestExtension());
// Tamper with a file in the extension.
base::FilePath script_path = extension_root().AppendASCII("script.js");
std::string addition = "//hello world";
ASSERT_TRUE(
base::AppendToFile(script_path, addition.c_str(), addition.size()));
RegisterInterception(fetch_url(), GetResourcePath("verified_contents.json"));
// Make sure the fetch was *not* successful.
std::unique_ptr<ContentHashResult> result = DoHashFetch();
ASSERT_NE(nullptr, result.get());
EXPECT_TRUE(result->success);
EXPECT_FALSE(result->was_cancelled);
EXPECT_TRUE(base::Contains(result->mismatch_paths, script_path.BaseName()));
// Make sure the verified_contents.json file was written into the extension's
// install dir.
EXPECT_TRUE(VerifiedContentsFileExists());
}
} // namespace extensions