forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
/
active_tab_apitest.cc
384 lines (332 loc) · 14.8 KB
/
active_tab_apitest.cc
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <memory>
#include "base/bind.h"
#include "base/logging.h"
#include "base/macros.h"
#include "base/strings/stringprintf.h"
#include "base/test/scoped_feature_list.h"
#include "chrome/browser/extensions/extension_action_runner.h"
#include "chrome/browser/extensions/extension_apitest.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_tab_util.h"
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/sessions/session_tab_helper.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/test_utils.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/test_extension_registry_observer.h"
#include "extensions/common/constants.h"
#include "extensions/common/extension.h"
#include "extensions/test/extension_test_message_listener.h"
#include "extensions/test/result_catcher.h"
#include "net/base/filename_util.h"
#include "net/dns/mock_host_resolver.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "services/network/public/cpp/features.h"
#if defined(OS_CHROMEOS)
#include "chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos.h"
#include "chromeos/login/login_state/scoped_test_public_session_login_state.h"
#endif
namespace extensions {
namespace {
enum class TestMode {
kWithBlinkCors,
kWithOutOfBlinkCors,
};
class ExtensionActiveTabTest : public ExtensionApiTest,
public testing::WithParamInterface<TestMode> {
public:
ExtensionActiveTabTest() = default;
// ExtensionApiTest override:
void SetUp() override {
std::vector<base::Feature> enabled_features;
std::vector<base::Feature> disabled_features;
if (ShouldEnableOutOfBlinkCors()) {
enabled_features.push_back(network::features::kOutOfBlinkCors);
enabled_features.push_back(network::features::kNetworkService);
} else {
disabled_features.push_back(network::features::kOutOfBlinkCors);
disabled_features.push_back(network::features::kNetworkService);
}
scoped_feature_list_.InitWithFeatures(enabled_features, disabled_features);
ExtensionApiTest::SetUp();
}
void SetUpOnMainThread() override {
ExtensionApiTest::SetUpOnMainThread();
// Map all hosts to localhost.
host_resolver()->AddRule("*", "127.0.0.1");
ASSERT_EQ(ShouldEnableOutOfBlinkCors(),
base::FeatureList::IsEnabled(network::features::kOutOfBlinkCors));
ASSERT_EQ(ShouldEnableOutOfBlinkCors(),
base::FeatureList::IsEnabled(network::features::kNetworkService));
}
private:
bool ShouldEnableOutOfBlinkCors() const {
TestMode mode = GetParam();
return mode == TestMode::kWithOutOfBlinkCors;
}
base::test::ScopedFeatureList scoped_feature_list_;
DISALLOW_COPY_AND_ASSIGN(ExtensionActiveTabTest);
};
IN_PROC_BROWSER_TEST_P(ExtensionActiveTabTest, ActiveTab) {
ASSERT_TRUE(StartEmbeddedTestServer());
ExtensionTestMessageListener background_page_ready("ready",
false /*will_reply*/);
const Extension* extension =
LoadExtension(test_data_dir_.AppendASCII("active_tab"));
ASSERT_TRUE(extension);
ASSERT_TRUE(background_page_ready.WaitUntilSatisfied());
// Shouldn't be initially granted based on activeTab.
{
ExtensionTestMessageListener navigation_count_listener(
"1", false /*will_reply*/);
ResultCatcher catcher;
ui_test_utils::NavigateToURL(
browser(),
embedded_test_server()->GetURL(
"google.com", "/extensions/api_test/active_tab/page.html"));
EXPECT_TRUE(catcher.GetNextResult()) << message_;
EXPECT_TRUE(navigation_count_listener.WaitUntilSatisfied());
}
// Do one pass of BrowserAction without granting activeTab permission,
// extension shouldn't have access to tab.url.
{
ResultCatcher catcher;
ExtensionActionRunner::GetForWebContents(
browser()->tab_strip_model()->GetActiveWebContents())
->RunAction(extension, false);
EXPECT_TRUE(catcher.GetNextResult()) << message_;
}
// Granting to the extension should give it access to page.html.
{
ResultCatcher catcher;
ExtensionActionRunner::GetForWebContents(
browser()->tab_strip_model()->GetActiveWebContents())
->RunAction(extension, true);
EXPECT_TRUE(catcher.GetNextResult()) << message_;
}
#if defined(OS_CHROMEOS)
// For the third pass grant the activeTab permission and do it in a public
// session. URL should be scrubbed down to origin.
{
// Setup state.
chromeos::ScopedTestPublicSessionLoginState login_state;
ExtensionTabUtil::SetPlatformDelegate(
std::make_unique<ExtensionTabUtilDelegateChromeOS>());
ExtensionTestMessageListener listener(false);
ResultCatcher catcher;
ExtensionActionRunner::GetForWebContents(
browser()->tab_strip_model()->GetActiveWebContents())
->RunAction(extension, true);
EXPECT_TRUE(catcher.GetNextResult()) << message_;
EXPECT_EQ(GURL(listener.message()).GetOrigin().spec(), listener.message());
// Clean up.
ExtensionTabUtil::SetPlatformDelegate(nullptr);
}
#endif
// Navigating to a different page on the same origin should revoke extension's
// access to the tab, unless the runtime host permissions feature is enabled.
{
ExtensionTestMessageListener navigation_count_listener(
"2", false /*will_reply*/);
ResultCatcher catcher;
ui_test_utils::NavigateToURL(
browser(),
embedded_test_server()->GetURL(
"google.com", "/extensions/api_test/active_tab/final_page.html"));
EXPECT_TRUE(catcher.GetNextResult()) << message_;
EXPECT_TRUE(navigation_count_listener.WaitUntilSatisfied());
}
// Navigating to a different origin should revoke extension's access to the
// tab.
{
ExtensionTestMessageListener navigation_count_listener(
"3", false /*will_reply*/);
ResultCatcher catcher;
ui_test_utils::NavigateToURL(
browser(),
embedded_test_server()->GetURL(
"example.com", "/extensions/api_test/active_tab/final_page.html"));
EXPECT_TRUE(catcher.GetNextResult()) << message_;
EXPECT_TRUE(navigation_count_listener.WaitUntilSatisfied());
}
}
INSTANTIATE_TEST_SUITE_P(WithBlinkCors,
ExtensionActiveTabTest,
testing::Values(TestMode::kWithBlinkCors));
INSTANTIATE_TEST_SUITE_P(WithOutOfBlinkCors,
ExtensionActiveTabTest,
testing::Values(TestMode::kWithOutOfBlinkCors));
// Tests the behavior of activeTab and its relation to an extension's ability to
// xhr file urls and inject scripts in file frames.
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, FileURLs) {
ASSERT_TRUE(StartEmbeddedTestServer());
ExtensionTestMessageListener background_page_ready("ready",
false /*will_reply*/);
const Extension* extension =
LoadExtension(test_data_dir_.AppendASCII("active_tab_file_urls"));
ASSERT_TRUE(extension);
const std::string extension_id = extension->id();
// Ensure the extension's background page is ready.
EXPECT_TRUE(background_page_ready.WaitUntilSatisfied());
auto can_xhr_file_urls = [this, &extension_id]() {
constexpr char script[] = R"(
var req = new XMLHttpRequest();
var url = '%s';
req.open('GET', url, true);
req.onload = function() {
if (req.responseText === 'Hello!')
window.domAutomationController.send('true');
// Even for a successful request, the status code might be 0. Ensure
// that onloadend is not subsequently called if the request is
// successful.
req.onloadend = null;
};
// We track 'onloadend' to detect failures instead of 'onerror', since for
// access check violations 'abort' event may be raised (instead of the
// 'error' event).
req.onloadend = function() {
if (req.status === 0)
window.domAutomationController.send('false');
};
req.send();
)";
base::FilePath test_file =
test_data_dir_.DirName().AppendASCII("test_file.txt");
std::string result = ExecuteScriptInBackgroundPage(
extension_id,
base::StringPrintf(script,
net::FilePathToFileURL(test_file).spec().c_str()));
EXPECT_TRUE(result == "true" || result == "false");
return result == "true";
};
auto can_load_file_iframe = [this, &extension_id]() {
const Extension* extension =
extension_service()->GetExtensionById(extension_id, false);
// Load an extension page with a file iframe.
GURL page = extension->GetResourceURL("file_iframe.html");
ExtensionTestMessageListener listener(false /*will_reply*/);
ui_test_utils::NavigateToURLWithDisposition(
browser(), page, WindowOpenDisposition::NEW_FOREGROUND_TAB,
ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
EXPECT_TRUE(listener.WaitUntilSatisfied());
EXPECT_TRUE(listener.message() == "allowed" ||
listener.message() == "denied")
<< "Unexpected message " << listener.message();
bool allowed = listener.message() == "allowed";
// Sanity check the last committed url on the |file_iframe|.
content::RenderFrameHost* file_iframe = content::FrameMatchingPredicate(
browser()->tab_strip_model()->GetActiveWebContents(),
base::Bind(&content::FrameMatchesName, "file_iframe"));
bool is_file_url = file_iframe->GetLastCommittedURL() == GURL("file:///");
EXPECT_EQ(allowed, is_file_url)
<< "Unexpected committed url: "
<< file_iframe->GetLastCommittedURL().spec();
browser()->tab_strip_model()->CloseSelectedTabs();
return allowed;
};
auto can_script_tab = [this, &extension_id](int tab_id) {
constexpr char script[] = R"(
var tabID = %d;
chrome.tabs.executeScript(
tabID, {code: 'console.log("injected");'}, function() {
const expectedError = 'Cannot access contents of the page. ' +
'Extension manifest must request permission to access the ' +
'respective host.';
if (chrome.runtime.lastError &&
expectedError != chrome.runtime.lastError.message) {
window.domAutomationController.send(
'unexpected error: ' + chrome.runtime.lastError.message);
} else {
window.domAutomationController.send(
chrome.runtime.lastError ? 'false' : 'true');
}
});
)";
std::string result = ExecuteScriptInBackgroundPage(
extension_id, base::StringPrintf(script, tab_id));
EXPECT_TRUE(result == "true" || result == "false") << result;
return result == "true";
};
auto get_active_tab_id = [this]() {
SessionTabHelper* session_tab_helper = SessionTabHelper::FromWebContents(
browser()->tab_strip_model()->GetActiveWebContents());
if (!session_tab_helper) {
ADD_FAILURE();
return extension_misc::kUnknownTabId;
}
return session_tab_helper->session_id().id();
};
// Navigate to two file urls (the extension's manifest.json and background.js
// in this case).
GURL file_url_1 =
net::FilePathToFileURL(extension->path().AppendASCII("manifest.json"));
ui_test_utils::NavigateToURL(browser(), file_url_1);
// Assigned to |inactive_tab_id| since we open another foreground tab
// subsequently.
int inactive_tab_id = get_active_tab_id();
EXPECT_NE(extension_misc::kUnknownTabId, inactive_tab_id);
GURL file_url_2 =
net::FilePathToFileURL(extension->path().AppendASCII("background.js"));
ui_test_utils::NavigateToURLWithDisposition(
browser(), file_url_2, WindowOpenDisposition::NEW_FOREGROUND_TAB,
ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
int active_tab_id = get_active_tab_id();
EXPECT_NE(extension_misc::kUnknownTabId, active_tab_id);
EXPECT_NE(inactive_tab_id, active_tab_id);
// By default the extension should have file access enabled. However, since it
// does not have host permissions to the localhost on the file scheme, it
// should not be able to xhr file urls. For the same reason, it should not be
// able to execute script in the two tabs or embed file iframes.
EXPECT_TRUE(util::AllowFileAccess(extension_id, profile()));
EXPECT_FALSE(can_xhr_file_urls());
EXPECT_FALSE(can_script_tab(active_tab_id));
EXPECT_FALSE(can_script_tab(inactive_tab_id));
EXPECT_FALSE(can_load_file_iframe());
// First don't grant the tab permission. Verify that the extension can't xhr
// file urls, can't script the two tabs and can't embed file iframes.
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
ExtensionActionRunner::GetForWebContents(web_contents)
->RunAction(extension, false /*grant_tab_permissions*/);
EXPECT_FALSE(can_xhr_file_urls());
EXPECT_FALSE(can_script_tab(active_tab_id));
EXPECT_FALSE(can_script_tab(inactive_tab_id));
EXPECT_FALSE(can_load_file_iframe());
// Now grant the tab permission. Ensure the extension can now xhr file urls ,
// script the active tab and embed file iframes. It should still not be able
// to script the background tab.
ExtensionActionRunner::GetForWebContents(web_contents)
->RunAction(extension, true /*grant_tab_permissions*/);
EXPECT_TRUE(can_xhr_file_urls());
EXPECT_TRUE(can_script_tab(active_tab_id));
EXPECT_TRUE(can_load_file_iframe());
EXPECT_FALSE(can_script_tab(inactive_tab_id));
// Revoke extension's access to file urls. This will cause the extension to
// reload, invalidating the |extension| pointer. Re-initialize the |extension|
// pointer.
background_page_ready.Reset();
util::SetAllowFileAccess(extension_id, profile(), false /*allow*/);
EXPECT_FALSE(util::AllowFileAccess(extension_id, profile()));
extension = TestExtensionRegistryObserver(ExtensionRegistry::Get(profile()))
.WaitForExtensionLoaded();
EXPECT_TRUE(extension);
// Ensure the extension's background page is ready.
EXPECT_TRUE(background_page_ready.WaitUntilSatisfied());
// Grant the tab permission for the active url to the extension. Ensure it
// still can't xhr file urls, script the active tab or embed file iframes
// (since it does not have file access).
ExtensionActionRunner::GetForWebContents(web_contents)
->RunAction(extension, true /*grant_tab_permissions*/);
EXPECT_FALSE(can_xhr_file_urls());
EXPECT_FALSE(can_script_tab(active_tab_id));
EXPECT_FALSE(can_script_tab(inactive_tab_id));
EXPECT_FALSE(can_load_file_iframe());
}
} // namespace
} // namespace extensions