forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
/
chrome_app_icon_unittest.cc
310 lines (258 loc) · 10.8 KB
/
chrome_app_icon_unittest.cc
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <memory>
#include <utility>
#include <vector>
#include "ash/public/cpp/app_list/app_list_config.h"
#include "base/bind.h"
#include "base/macros.h"
#include "base/run_loop.h"
#include "build/chromeos_buildflags.h"
#include "chrome/browser/extensions/chrome_app_icon.h"
#include "chrome/browser/extensions/chrome_app_icon_delegate.h"
#include "chrome/browser/extensions/chrome_app_icon_loader.h"
#include "chrome/browser/extensions/chrome_app_icon_service.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_service_test_base.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/app_icon_loader_delegate.h"
#include "chrome/common/chrome_constants.h"
#include "chrome/test/base/testing_profile.h"
#include "extensions/common/constants.h"
#include "ui/gfx/color_utils.h"
#include "ui/gfx/image/image_skia_operations.h"
#include "ui/gfx/image/image_unittest_util.h"
#if BUILDFLAG(IS_CHROMEOS_ASH)
#include "chrome/browser/chromeos/arc/arc_util.h"
#include "chrome/browser/chromeos/extensions/gfx_utils.h"
#include "chrome/browser/ui/app_list/arc/arc_app_test.h"
#include "components/arc/test/fake_app_instance.h"
#include "ui/chromeos/resources/grit/ui_chromeos_resources.h"
#endif // BUILDFLAG(IS_CHROMEOS_ASH)
namespace extensions {
namespace {
constexpr char kTestAppId[] = "emfkafnhnpcmabnnkckkchdilgeoekbo";
// Receives icon image updates from ChromeAppIcon.
class TestAppIcon : public ChromeAppIconDelegate {
public:
TestAppIcon(content::BrowserContext* context,
const std::string& app_id,
int size,
const ChromeAppIconService::ResizeFunction& resize_function) {
app_icon_ = ChromeAppIconService::Get(context)->CreateIcon(
this, app_id, size, resize_function);
DCHECK(app_icon_);
}
TestAppIcon(content::BrowserContext* context,
const std::string& app_id,
int size) {
app_icon_ =
ChromeAppIconService::Get(context)->CreateIcon(this, app_id, size);
DCHECK(app_icon_);
}
~TestAppIcon() override = default;
void Reset() { app_icon_.reset(); }
int GetIconUpdateCountAndReset() {
int icon_update_count = icon_update_count_;
icon_update_count_ = 0;
return icon_update_count;
}
size_t icon_update_count() const { return icon_update_count_; }
ChromeAppIcon* app_icon() { return app_icon_.get(); }
const gfx::ImageSkia& image_skia() const { return app_icon_->image_skia(); }
void WaitForIconUpdates() {
base::RunLoop run_loop;
icon_update_count_expected_ =
icon_update_count_ + image_skia().image_reps().size();
icon_updated_callback_ = run_loop.QuitClosure();
run_loop.Run();
}
private:
void OnIconUpdated(ChromeAppIcon* icon) override {
++icon_update_count_;
if (icon_update_count_ == icon_update_count_expected_ &&
icon_updated_callback_) {
std::move(icon_updated_callback_).Run();
}
}
std::unique_ptr<ChromeAppIcon> app_icon_;
size_t icon_update_count_ = 0;
size_t icon_update_count_expected_ = 0;
base::OnceClosure icon_updated_callback_;
DISALLOW_COPY_AND_ASSIGN(TestAppIcon);
};
// Receives icon image updates from ChromeAppIconLoader.
class TestAppIconLoader : public AppIconLoaderDelegate {
public:
TestAppIconLoader() = default;
~TestAppIconLoader() override = default;
// AppIconLoaderDelegate:
void OnAppImageUpdated(const std::string& app_id,
const gfx::ImageSkia& image) override {
image_skia_ = image;
}
gfx::ImageSkia& icon() { return image_skia_; }
const gfx::ImageSkia& icon() const { return image_skia_; }
private:
gfx::ImageSkia image_skia_;
DISALLOW_COPY_AND_ASSIGN(TestAppIconLoader);
};
// Returns true if provided |image| consists from only empty pixels.
bool IsBlankImage(const gfx::ImageSkia& image) {
if (!image.width() || !image.height())
return false;
const SkBitmap* bitmap = image.bitmap();
DCHECK(bitmap);
DCHECK_EQ(bitmap->width(), image.width());
DCHECK_EQ(bitmap->height(), image.height());
for (int x = 0; x < bitmap->width(); ++x) {
for (int y = 0; y < bitmap->height(); ++y) {
if (*bitmap->getAddr32(x, y))
return false;
}
}
return true;
}
// Returns true if provided |image| is grayscale.
bool IsGrayscaleImage(const gfx::ImageSkia& image) {
const SkBitmap* bitmap = image.bitmap();
DCHECK(bitmap);
for (int x = 0; x < bitmap->width(); ++x) {
for (int y = 0; y < bitmap->height(); ++y) {
const unsigned int pixel = *bitmap->getAddr32(x, y);
if ((pixel & 0xff) != ((pixel >> 8) & 0xff) ||
(pixel & 0xff) != ((pixel >> 16) & 0xff)) {
return false;
}
}
}
return true;
}
// Returns true if provided |image1| and |image2| are equal.
bool AreEqual(const gfx::ImageSkia& image1, const gfx::ImageSkia& image2) {
return gfx::test::AreImagesEqual(gfx::Image(image1), gfx::Image(image2));
}
#if BUILDFLAG(IS_CHROMEOS_ASH)
// Returns true if |res| image is the |src| image with badge identified by
// |badge_type| resource. If |grayscale| is true applies HSL shift for the
// comparison.
bool IsBadgeApplied(const gfx::ImageSkia& src,
const gfx::ImageSkia& res,
ChromeAppIcon::Badge badge_type,
bool grayscale) {
src.EnsureRepsForSupportedScales();
gfx::ImageSkia reference_src = src.DeepCopy();
if (grayscale) {
constexpr color_utils::HSL shift = {-1, 0, 0.6};
reference_src =
gfx::ImageSkiaOperations::CreateHSLShiftedImage(reference_src, shift);
}
util::ApplyBadge(&reference_src, badge_type);
return AreEqual(reference_src, res);
}
#endif
} // namespace
class ChromeAppIconTest : public ExtensionServiceTestBase {
public:
ChromeAppIconTest() = default;
~ChromeAppIconTest() override = default;
// ExtensionServiceTestBase:
void SetUp() override {
ExtensionServiceTestBase::SetUp();
const base::FilePath source_install_dir =
data_dir().AppendASCII("app_list").AppendASCII("Extensions");
const base::FilePath pref_path =
source_install_dir.DirName().Append(chrome::kPreferencesFilename);
InitializeInstalledExtensionService(pref_path, source_install_dir);
service_->Init();
}
private:
DISALLOW_COPY_AND_ASSIGN(ChromeAppIconTest);
};
TEST_F(ChromeAppIconTest, IconLifeCycle) {
TestAppIcon reference_icon(profile(), kTestAppId,
extension_misc::EXTENSION_ICON_MEDIUM);
EXPECT_EQ(1U, reference_icon.icon_update_count());
// By default no representation in image.
EXPECT_FALSE(reference_icon.image_skia().HasRepresentation(1.0f));
// Default blank image must be provided without an update.
EXPECT_FALSE(reference_icon.image_skia().GetRepresentation(1.0f).is_null());
EXPECT_EQ(1U, reference_icon.icon_update_count());
EXPECT_TRUE(reference_icon.image_skia().HasRepresentation(1.0f));
EXPECT_EQ(extension_misc::EXTENSION_ICON_MEDIUM,
reference_icon.image_skia().width());
EXPECT_EQ(extension_misc::EXTENSION_ICON_MEDIUM,
reference_icon.image_skia().height());
EXPECT_TRUE(IsBlankImage(reference_icon.image_skia()));
// Wait until real image is loaded.
reference_icon.WaitForIconUpdates();
EXPECT_EQ(2U, reference_icon.icon_update_count());
EXPECT_FALSE(IsBlankImage(reference_icon.image_skia()));
EXPECT_FALSE(IsGrayscaleImage(reference_icon.image_skia()));
const gfx::ImageSkia image_before_disable = reference_icon.image_skia();
// Disable extension. This should update icon and provide grayed image inline.
// Note update might be sent twice in CrOS.
service()->DisableExtension(kTestAppId, disable_reason::DISABLE_CORRUPTED);
const size_t update_count_after_disable = reference_icon.icon_update_count();
EXPECT_NE(2U, update_count_after_disable);
EXPECT_FALSE(IsBlankImage(reference_icon.image_skia()));
#if BUILDFLAG(IS_CHROMEOS_ASH)
EXPECT_TRUE(IsBadgeApplied(image_before_disable, reference_icon.image_skia(),
ChromeAppIcon::Badge::kBlocked,
true /* grayscale */));
#else
EXPECT_TRUE(IsGrayscaleImage(reference_icon.image_skia()));
#endif
// Reenable extension. It should match previous enabled image
service()->EnableExtension(kTestAppId);
EXPECT_NE(update_count_after_disable, reference_icon.icon_update_count());
EXPECT_TRUE(AreEqual(reference_icon.image_skia(), image_before_disable));
}
// Validates that icon release is safe.
TEST_F(ChromeAppIconTest, IconRelease) {
TestAppIcon test_icon1(profile(), kTestAppId,
extension_misc::EXTENSION_ICON_MEDIUM);
TestAppIcon test_icon2(profile(), kTestAppId,
extension_misc::EXTENSION_ICON_MEDIUM);
EXPECT_FALSE(test_icon1.image_skia().GetRepresentation(1.0f).is_null());
EXPECT_FALSE(test_icon2.image_skia().GetRepresentation(1.0f).is_null());
// Reset before service is stopped.
test_icon1.Reset();
// Reset after service is stopped.
profile_.reset();
test_icon2.Reset();
}
#if BUILDFLAG(IS_CHROMEOS_ASH)
TEST_F(ChromeAppIconTest, ChromeBadging) {
ArcAppTest arc_test;
arc_test.SetUp(profile());
TestAppIcon reference_icon(profile(), kTestAppId,
extension_misc::EXTENSION_ICON_MEDIUM);
// Wait until reference data is loaded.
EXPECT_FALSE(reference_icon.image_skia().GetRepresentation(1.0f).is_null());
reference_icon.WaitForIconUpdates();
EXPECT_FALSE(IsBlankImage(reference_icon.image_skia()));
reference_icon.GetIconUpdateCountAndReset();
const gfx::ImageSkia image_before_badging = reference_icon.image_skia();
// Badging should be applied once package is installed.
std::vector<arc::mojom::AppInfo> fake_apps = arc_test.fake_apps();
fake_apps[0].package_name = arc_test.fake_packages()[0]->package_name;
arc_test.app_instance()->SendRefreshAppList(fake_apps);
arc_test.app_instance()->SendRefreshPackageList(
ArcAppTest::ClonePackages(arc_test.fake_packages()));
// Expect the package list refresh to generate two icon updates - one called
// by ArcAppListPrefs, and one called by LaunchExtensionAppUpdate.
EXPECT_EQ(2U, reference_icon.icon_update_count());
EXPECT_FALSE(AreEqual(reference_icon.image_skia(), image_before_badging));
EXPECT_TRUE(IsBadgeApplied(image_before_badging, reference_icon.image_skia(),
ChromeAppIcon::Badge::kChrome,
false /* grayscale */));
// Opts out the Play Store. Badge should be gone and icon image is the same
// as it was before badging.
arc::SetArcPlayStoreEnabledForProfile(profile(), false);
EXPECT_EQ(3U, reference_icon.icon_update_count());
EXPECT_TRUE(AreEqual(reference_icon.image_skia(), image_before_badging));
}
#endif // BUILDFLAG(IS_CHROMEOS_ASH)
} // namespace extensions