forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
/
tab_drag_drop_delegate_unittest.cc
270 lines (219 loc) · 10.3 KB
/
tab_drag_drop_delegate_unittest.cc
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
// Copyright 2020 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ash/drag_drop/tab_drag_drop_delegate.h"
#include <memory>
#include <utility>
#include <vector>
#include "ash/public/cpp/ash_features.h"
#include "ash/scoped_animation_disabler.h"
#include "ash/screen_util.h"
#include "ash/shell.h"
#include "ash/test/ash_test_base.h"
#include "ash/test_shell_delegate.h"
#include "ash/wm/overview/overview_controller.h"
#include "ash/wm/splitview/split_view_controller.h"
#include "ash/wm/tablet_mode/tablet_mode_controller_test_api.h"
#include "base/containers/flat_map.h"
#include "base/no_destructor.h"
#include "base/pickle.h"
#include "base/stl_util.h"
#include "base/strings/string16.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/scoped_feature_list.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "ui/base/clipboard/clipboard_format_type.h"
#include "ui/base/clipboard/custom_data_helper.h"
#include "ui/base/dragdrop/os_exchange_data.h"
#include "ui/events/test/event_generator.h"
#include "ui/gfx/geometry/vector2d.h"
using ::testing::_;
using ::testing::NiceMock;
using ::testing::Return;
namespace ash {
namespace {
class MockShellDelegate : public TestShellDelegate {
public:
MockShellDelegate() = default;
~MockShellDelegate() override = default;
MOCK_METHOD(bool, IsTabDrag, (const ui::OSExchangeData&), (override));
MOCK_METHOD(aura::Window*,
CreateBrowserForTabDrop,
(aura::Window*, const ui::OSExchangeData&),
(override));
};
} // namespace
class TabDragDropDelegateTest : public AshTestBase {
public:
TabDragDropDelegateTest() {
ash::features::SetWebUITabStripEnabled(true);
scoped_feature_list_.InitAndEnableFeature(
ash::features::kWebUITabStripTabDragIntegration);
}
// AshTestBase:
void SetUp() override {
auto mock_shell_delegate = std::make_unique<NiceMock<MockShellDelegate>>();
mock_shell_delegate_ = mock_shell_delegate.get();
AshTestBase::SetUp(std::move(mock_shell_delegate));
ash::TabletModeControllerTestApi().EnterTabletMode();
// Create a dummy window and exit overview mode since drags can't be
// initiated from overview mode.
dummy_window_ = CreateToplevelTestWindow();
ASSERT_TRUE(Shell::Get()->overview_controller()->EndOverview());
}
void TearDown() override {
// Must be deleted before AshTestBase's tear down.
dummy_window_.reset();
// Clear our pointer before the object is destroyed.
mock_shell_delegate_ = nullptr;
AshTestBase::TearDown();
}
MockShellDelegate* mock_shell_delegate() { return mock_shell_delegate_; }
private:
base::test::ScopedFeatureList scoped_feature_list_;
NiceMock<MockShellDelegate>* mock_shell_delegate_ = nullptr;
std::unique_ptr<aura::Window> dummy_window_;
};
TEST_F(TabDragDropDelegateTest, ForwardsDragCheckToShellDelegate) {
ON_CALL(*mock_shell_delegate(), IsTabDrag(_)).WillByDefault(Return(false));
EXPECT_FALSE(TabDragDropDelegate::IsChromeTabDrag(ui::OSExchangeData()));
ON_CALL(*mock_shell_delegate(), IsTabDrag(_)).WillByDefault(Return(true));
EXPECT_TRUE(TabDragDropDelegate::IsChromeTabDrag(ui::OSExchangeData()));
}
TEST_F(TabDragDropDelegateTest, DragToExistingTabStrip) {
// Create a fake source window. Its details don't matter.
std::unique_ptr<aura::Window> source_window = CreateToplevelTestWindow();
// A new window shouldn't be created in this case.
EXPECT_CALL(*mock_shell_delegate(), CreateBrowserForTabDrop(_, _)).Times(0);
// Emulate a drag session whose drop target accepts the drop. In this
// case, TabDragDropDelegate::Drop() is not called.
TabDragDropDelegate delegate(Shell::GetPrimaryRootWindow(),
source_window.get(), gfx::Point(0, 0));
delegate.DragUpdate(gfx::Point(1, 0));
delegate.DragUpdate(gfx::Point(2, 0));
// Let |delegate| be destroyed without a Drop() call.
}
TEST_F(TabDragDropDelegateTest, DragToNewWindow) {
// Create the source window. This should automatically fill the work area
// since we're in tablet mode.
std::unique_ptr<aura::Window> source_window = CreateToplevelTestWindow();
EXPECT_FALSE(
SplitViewController::Get(source_window.get())->InTabletSplitViewMode());
const gfx::Point drag_start_location = source_window->bounds().CenterPoint();
// Emulate a drag session ending in a drop to a new window.
TabDragDropDelegate delegate(Shell::GetPrimaryRootWindow(),
source_window.get(), drag_start_location);
delegate.DragUpdate(drag_start_location);
delegate.DragUpdate(drag_start_location + gfx::Vector2d(1, 0));
delegate.DragUpdate(drag_start_location + gfx::Vector2d(2, 0));
// Check that a new window is requested. Assume the correct drop data
// is passed. Return the new window.
std::unique_ptr<aura::Window> new_window = CreateToplevelTestWindow();
EXPECT_CALL(*mock_shell_delegate(),
CreateBrowserForTabDrop(source_window.get(), _))
.Times(1)
.WillOnce(Return(new_window.get()));
delegate.Drop(drag_start_location + gfx::Vector2d(2, 0),
ui::OSExchangeData());
EXPECT_FALSE(
SplitViewController::Get(source_window.get())->InTabletSplitViewMode());
}
TEST_F(TabDragDropDelegateTest, DropOnEdgeEntersSplitView) {
// Create the source window. This should automatically fill the work area
// since we're in tablet mode.
std::unique_ptr<aura::Window> source_window = CreateToplevelTestWindow();
// We want to avoid entering overview mode between the delegate.Drop()
// call and |new_window|'s destruction. So we define it here before
// creating it.
std::unique_ptr<aura::Window> new_window;
// Emulate a drag to the right edge of the screen.
const gfx::Point drag_start_location = source_window->bounds().CenterPoint();
const gfx::Point drag_end_location =
screen_util::GetDisplayWorkAreaBoundsInScreenForActiveDeskContainer(
source_window.get())
.right_center();
TabDragDropDelegate delegate(Shell::GetPrimaryRootWindow(),
source_window.get(), drag_start_location);
delegate.DragUpdate(drag_start_location);
delegate.DragUpdate(drag_end_location);
new_window = CreateToplevelTestWindow();
EXPECT_CALL(*mock_shell_delegate(),
CreateBrowserForTabDrop(source_window.get(), _))
.Times(1)
.WillOnce(Return(new_window.get()));
delegate.Drop(drag_end_location, ui::OSExchangeData());
SplitViewController* const split_view_controller =
SplitViewController::Get(source_window.get());
EXPECT_TRUE(split_view_controller->InTabletSplitViewMode());
EXPECT_EQ(new_window.get(), split_view_controller->GetSnappedWindow(
SplitViewController::SnapPosition::RIGHT));
EXPECT_EQ(source_window.get(), split_view_controller->GetSnappedWindow(
SplitViewController::SnapPosition::LEFT));
}
TEST_F(TabDragDropDelegateTest, SourceWindowBoundsUpdatedWhileDragging) {
// Create the source window. This should automatically fill the work area
// since we're in tablet mode.
std::unique_ptr<aura::Window> source_window = CreateToplevelTestWindow();
const gfx::Rect original_bounds = source_window->bounds();
// Drag a few pixels away to trigger window scaling, then to the
// screen edge to visually snap the source window.
const gfx::Point drag_start_location = source_window->bounds().CenterPoint();
const gfx::Point drag_mid_location =
drag_start_location + gfx::Vector2d(10, 0);
const gfx::Point drag_end_location =
screen_util::GetDisplayWorkAreaBoundsInScreenForActiveDeskContainer(
source_window.get())
.left_center();
{
TabDragDropDelegate delegate(Shell::GetPrimaryRootWindow(),
source_window.get(), drag_start_location);
delegate.DragUpdate(drag_start_location);
delegate.DragUpdate(drag_mid_location);
// |source_window| should be shrunk in all directions
EXPECT_GT(source_window->bounds().x(), original_bounds.x());
EXPECT_GT(source_window->bounds().y(), original_bounds.y());
EXPECT_LT(source_window->bounds().right(), original_bounds.right());
EXPECT_LT(source_window->bounds().bottom(), original_bounds.bottom());
delegate.DragUpdate(drag_end_location);
// |source_window| should appear in the snapped position, but not
// actually be snapped.
SplitViewController* const split_view_controller =
SplitViewController::Get(source_window.get());
EXPECT_EQ(
source_window->bounds(),
split_view_controller->GetSnappedWindowBoundsInParent(
SplitViewController::SnapPosition::RIGHT, source_window.get()));
EXPECT_FALSE(split_view_controller->InSplitViewMode());
}
// The original bounds should be restored.
EXPECT_EQ(source_window->bounds(), original_bounds);
}
TEST_F(TabDragDropDelegateTest, SnappedSourceWindowNotMoved) {
// Create the source window. This should automatically fill the work area
// since we're in tablet mode.
std::unique_ptr<aura::Window> source_window = CreateToplevelTestWindow();
SplitViewController* const split_view_controller =
SplitViewController::Get(source_window.get());
SplitViewController::SnapPosition const snap_position =
SplitViewController::SnapPosition::LEFT;
split_view_controller->SnapWindow(source_window.get(), snap_position);
const gfx::Rect original_bounds = source_window->bounds();
const gfx::Point drag_start_location = source_window->bounds().CenterPoint();
const gfx::Point drag_end_location =
drag_start_location + gfx::Vector2d(10, 0);
{
TabDragDropDelegate delegate(Shell::GetPrimaryRootWindow(),
source_window.get(), drag_start_location);
delegate.DragUpdate(drag_start_location);
delegate.DragUpdate(drag_end_location);
// |source_window| should remain snapped and it's bounds should not change.
EXPECT_EQ(source_window.get(),
split_view_controller->GetSnappedWindow(snap_position));
EXPECT_EQ(original_bounds, source_window->bounds());
}
// Everything should still be the same after the drag ends.
EXPECT_EQ(source_window.get(),
split_view_controller->GetSnappedWindow(snap_position));
EXPECT_EQ(original_bounds, source_window->bounds());
}
} // namespace ash