forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
/
extension_updater_unittest.cc
2948 lines (2578 loc) · 121 KB
/
extension_updater_unittest.cc
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/extensions/updater/extension_updater.h"
#include <stddef.h>
#include <stdint.h>
#include <list>
#include <map>
#include <memory>
#include <set>
#include <utility>
#include <vector>
#include "base/bind.h"
#include "base/bind_helpers.h"
#include "base/command_line.h"
#include "base/files/file_util.h"
#include "base/memory/weak_ptr.h"
#include "base/run_loop.h"
#include "base/sequenced_task_runner.h"
#include "base/stl_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "base/test/bind_test_util.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/threading/thread.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/version.h"
#include "build/branding_buildflags.h"
#include "build/build_config.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/extensions/crx_installer.h"
#include "chrome/browser/extensions/extension_sync_data.h"
#include "chrome/browser/extensions/test_extension_prefs.h"
#include "chrome/browser/extensions/test_extension_service.h"
#include "chrome/browser/extensions/test_extension_system.h"
#include "chrome/browser/extensions/updater/chrome_extension_downloader_factory.h"
#include "chrome/browser/google/google_brand.h"
#include "chrome/test/base/scoped_testing_local_state.h"
#include "chrome/test/base/testing_browser_process.h"
#include "chrome/test/base/testing_profile.h"
#include "components/crx_file/id_util.h"
#include "components/signin/public/identity_manager/identity_test_environment.h"
#include "components/sync_preferences/pref_service_syncable.h"
#include "components/update_client/update_query_params.h"
#include "content/public/browser/notification_details.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/notification_source.h"
#include "content/public/test/browser_task_environment.h"
#include "content/public/test/test_utils.h"
#include "extensions/browser/disable_reason.h"
#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/extension_system.h"
#include "extensions/browser/pref_names.h"
#include "extensions/browser/updater/extension_downloader.h"
#include "extensions/browser/updater/extension_downloader_delegate.h"
#include "extensions/browser/updater/extension_downloader_test_delegate.h"
#include "extensions/browser/updater/extension_downloader_test_helper.h"
#include "extensions/browser/updater/extension_update_data.h"
#include "extensions/browser/updater/manifest_fetch_data.h"
#include "extensions/browser/updater/request_queue_impl.h"
#include "extensions/common/extension.h"
#include "extensions/common/extension_urls.h"
#include "extensions/common/manifest_constants.h"
#include "extensions/common/verifier_formats.h"
#include "net/base/backoff_entry.h"
#include "net/base/escape.h"
#include "net/base/load_flags.h"
#include "net/http/http_request_headers.h"
#include "services/network/public/cpp/simple_url_loader.h"
#include "services/network/public/cpp/weak_wrapper_shared_url_loader_factory.h"
#include "services/network/test/test_url_loader_factory.h"
#include "services/network/test/test_utils.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/third_party/mozilla/url_parse.h"
#if defined(OS_CHROMEOS)
#include "base/files/scoped_temp_dir.h"
#include "chrome/browser/chromeos/login/users/scoped_test_user_manager.h"
#include "chrome/browser/chromeos/settings/scoped_cros_settings_test_helper.h"
#include "chrome/browser/extensions/load_error_reporter.h"
#include "chrome/browser/extensions/updater/chromeos_extension_cache_delegate.h"
#include "chrome/browser/extensions/updater/extension_cache_impl.h"
#include "chrome/browser/extensions/updater/local_extension_cache.h"
#endif
using base::Time;
using base::TimeDelta;
using content::BrowserThread;
using update_client::UpdateQueryParams;
using testing::DoAll;
using testing::Invoke;
using testing::InvokeWithoutArgs;
using testing::Mock;
using testing::Return;
using testing::SetArgPointee;
using testing::_;
namespace extensions {
typedef ExtensionDownloaderDelegate::Error Error;
typedef ExtensionDownloaderDelegate::PingResult PingResult;
namespace {
const net::BackoffEntry::Policy kNoBackoffPolicy = {
// Number of initial errors (in sequence) to ignore before applying
// exponential back-off rules.
1000,
// Initial delay for exponential back-off in ms.
0,
// Factor by which the waiting time will be multiplied.
0,
// Fuzzing percentage. ex: 10% will spread requests randomly
// between 90%-100% of the calculated time.
0,
// Maximum amount of time we are willing to delay our request in ms.
0,
// Time to keep an entry from being discarded even when it
// has no significant state, -1 to never discard.
-1,
// Don't use initial delay unless the last request was an error.
false,
};
const char kEmptyUpdateUrlData[] = "";
const char kAuthUserQueryKey[] = "authuser";
int kExpectedLoadFlags = net::LOAD_DISABLE_CACHE;
int kExpectedLoadFlagsForDownloadWithCookies = net::LOAD_DISABLE_CACHE;
// Fake authentication constants
const char kFakeOAuth2Token[] = "ce n'est pas un jeton";
const ManifestFetchData::PingData kNeverPingedData(
ManifestFetchData::kNeverPinged,
ManifestFetchData::kNeverPinged,
true,
0);
const int kNotificationsObserved[] = {
extensions::NOTIFICATION_EXTENSION_UPDATING_STARTED,
extensions::NOTIFICATION_EXTENSION_UPDATE_FOUND,
};
// A class that observes the notifications sent by the ExtensionUpdater and
// the ExtensionDownloader.
class NotificationsObserver : public content::NotificationObserver {
public:
NotificationsObserver() {
for (size_t i = 0; i < base::size(kNotificationsObserved); ++i) {
count_[i] = 0;
registrar_.Add(this,
kNotificationsObserved[i],
content::NotificationService::AllSources());
}
}
NotificationsObserver(const NotificationsObserver&) = delete;
NotificationsObserver& operator=(const NotificationsObserver&) = delete;
~NotificationsObserver() override {
for (size_t i = 0; i < base::size(kNotificationsObserved); ++i) {
registrar_.Remove(this,
kNotificationsObserved[i],
content::NotificationService::AllSources());
}
}
size_t StartedCount() { return count_[0]; }
size_t UpdatedCount() { return count_[1]; }
bool Updated(const std::string& id) {
return updated_.find(id) != updated_.end();
}
void Wait() {
scoped_refptr<content::MessageLoopRunner> runner =
new content::MessageLoopRunner;
quit_closure_ = runner->QuitClosure();
runner->Run();
}
private:
void Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) override {
if (!quit_closure_.is_null())
std::move(quit_closure_).Run();
for (size_t i = 0; i < base::size(kNotificationsObserved); ++i) {
if (kNotificationsObserved[i] == type) {
count_[i]++;
if (type == extensions::NOTIFICATION_EXTENSION_UPDATE_FOUND) {
updated_.insert(
content::Details<UpdateDetails>(details)->id);
}
return;
}
}
NOTREACHED();
}
content::NotificationRegistrar registrar_;
size_t count_[base::size(kNotificationsObserved)];
std::set<std::string> updated_;
base::OnceClosure quit_closure_;
};
// Extracts the integer value of the |authuser| query parameter. Returns 0 if
// the parameter is not set.
int GetAuthUserQueryValue(const GURL& url) {
std::string query_string = url.query();
url::Component query(0, query_string.length());
url::Component key, value;
while (
url::ExtractQueryKeyValue(query_string.c_str(), &query, &key, &value)) {
std::string key_string = query_string.substr(key.begin, key.len);
if (key_string == kAuthUserQueryKey) {
int user_index = 0;
base::StringToInt(query_string.substr(value.begin, value.len),
&user_index);
return user_index;
}
}
return 0;
}
class MockUpdateService : public UpdateService {
public:
MockUpdateService() : UpdateService(nullptr, nullptr) {}
MOCK_CONST_METHOD0(IsBusy, bool());
MOCK_CONST_METHOD1(CanUpdate, bool(const std::string& id));
MOCK_METHOD3(SendUninstallPing,
void(const std::string& id,
const base::Version& version,
int reason));
MOCK_METHOD2(StartUpdateCheck,
void(const ExtensionUpdateCheckParams& params,
base::OnceClosure callback));
};
#if defined(OS_CHROMEOS)
// TODO (crbug.com/1061475) : Move this to a utility file.
std::string CreateUpdateManifest(const std::string& extension_id,
const std::string& extension_version,
const std::string& extension_hash) {
return "<?xml version='1.0' encoding='UTF-8'?>"
"<gupdate xmlns='http://www.google.com/update2/response'"
" protocol='2.0'>"
" <app appid='" +
extension_id +
"'>"
" <updatecheck codebase='http://example.com/extension_1.2.3.4.crx'"
" version='" +
extension_version +
(extension_hash.size() ? "' hash='" + extension_hash : "'") +
"' prodversionmin='1.1' />"
" </app>"
"</gupdate>";
}
#endif
} // namespace
// Base class for further specialized test classes.
class MockService : public TestExtensionService {
public:
explicit MockService(
TestExtensionPrefs* prefs,
scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory)
: prefs_(prefs),
pending_extension_manager_(prefs->profile()),
downloader_delegate_override_(nullptr),
test_shared_url_loader_factory_(url_loader_factory) {}
~MockService() override = default;
PendingExtensionManager* pending_extension_manager() override {
ADD_FAILURE() << "Subclass should override this if it will "
<< "be accessed by a test.";
return &pending_extension_manager_;
}
Profile* profile() { return prefs_->profile(); }
ExtensionPrefs* extension_prefs() { return prefs_->prefs(); }
PrefService* pref_service() { return prefs_->pref_service(); }
signin::IdentityTestEnvironment* identity_test_env() {
return identity_test_env_.get();
}
const CoreAccountId& account_id() { return account_info_.account_id; }
// Creates test extensions and inserts them into list. The name and
// version are all based on their index. If |update_url| is non-null, it
// will be used as the update_url for each extension.
// The |id| is used to distinguish extension names and make sure that
// no two extensions share the same name.
void CreateTestExtensions(int id, int count, ExtensionList *list,
const std::string* update_url,
Manifest::Location location) {
for (int i = 1; i <= count; i++) {
base::DictionaryValue manifest;
manifest.SetString(manifest_keys::kVersion,
base::StringPrintf("%d.0.0.0", i));
manifest.SetString(manifest_keys::kName,
base::StringPrintf("Extension %d.%d", id, i));
manifest.SetInteger(manifest_keys::kManifestVersion, 2);
if (update_url)
manifest.SetString(manifest_keys::kUpdateURL, *update_url);
scoped_refptr<Extension> e =
prefs_->AddExtensionWithManifest(manifest, location);
ASSERT_TRUE(e.get() != NULL);
list->push_back(e);
}
}
ExtensionDownloader::Factory GetDownloaderFactory() {
return base::BindRepeating(&MockService::CreateExtensionDownloader,
base::Unretained(this));
}
ExtensionDownloader::Factory GetAuthenticatedDownloaderFactory() {
return base::BindRepeating(
&MockService::CreateExtensionDownloaderWithIdentity,
base::Unretained(this));
}
void OverrideDownloaderDelegate(ExtensionDownloaderDelegate* delegate) {
downloader_delegate_override_ = delegate;
}
protected:
TestExtensionPrefs* const prefs_;
PendingExtensionManager pending_extension_manager_;
private:
std::unique_ptr<ExtensionDownloader> CreateExtensionDownloader(
ExtensionDownloaderDelegate* delegate) {
std::unique_ptr<ExtensionDownloader> downloader =
ChromeExtensionDownloaderFactory::CreateForURLLoaderFactory(
test_shared_url_loader_factory_,
downloader_delegate_override_ ? downloader_delegate_override_
: delegate,
GetTestVerifierFormat());
return downloader;
}
std::unique_ptr<ExtensionDownloader> CreateExtensionDownloaderWithIdentity(
ExtensionDownloaderDelegate* delegate) {
identity_test_env_ = std::make_unique<signin::IdentityTestEnvironment>();
account_info_ = identity_test_env_->MakePrimaryAccountAvailable(
"bobloblaw@lawblog.example.com");
std::unique_ptr<ExtensionDownloader> downloader(
CreateExtensionDownloader(delegate));
downloader->SetIdentityManager(identity_test_env_->identity_manager());
return downloader;
}
AccountInfo account_info_;
std::unique_ptr<signin::IdentityTestEnvironment> identity_test_env_;
ExtensionDownloaderDelegate* downloader_delegate_override_;
scoped_refptr<network::SharedURLLoaderFactory>
test_shared_url_loader_factory_;
DISALLOW_COPY_AND_ASSIGN(MockService);
};
bool ShouldInstallExtensionsOnly(const Extension* extension) {
return extension->GetType() == Manifest::TYPE_EXTENSION;
}
bool ShouldInstallThemesOnly(const Extension* extension) {
return extension->is_theme();
}
bool ShouldAlwaysInstall(const Extension* extension) {
return true;
}
// Loads some pending extension records into a pending extension manager.
void SetupPendingExtensionManagerForTest(
int count,
const GURL& update_url,
PendingExtensionManager* pending_extension_manager) {
for (int i = 1; i <= count; ++i) {
PendingExtensionInfo::ShouldAllowInstallPredicate should_allow_install =
(i % 2 == 0) ? &ShouldInstallThemesOnly : &ShouldInstallExtensionsOnly;
const bool kIsFromSync = true;
const bool kMarkAcknowledged = false;
const bool kRemoteInstall = false;
std::string id =
crx_file::id_util::GenerateId(base::StringPrintf("extension%i", i));
pending_extension_manager->AddForTesting(
PendingExtensionInfo(id,
std::string(),
update_url,
base::Version(),
should_allow_install,
kIsFromSync,
Manifest::INTERNAL,
Extension::NO_FLAGS,
kMarkAcknowledged,
kRemoteInstall));
}
}
class ServiceForManifestTests : public MockService {
public:
explicit ServiceForManifestTests(
TestExtensionPrefs* prefs,
scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory)
: MockService(prefs, url_loader_factory),
registry_(ExtensionRegistry::Get(profile())) {}
~ServiceForManifestTests() override = default;
PendingExtensionManager* pending_extension_manager() override {
return &pending_extension_manager_;
}
const Extension* GetPendingExtensionUpdate(
const std::string& id) const override {
return NULL;
}
bool IsExtensionEnabled(const std::string& id) const override {
return !registry_->disabled_extensions().Contains(id);
}
void set_extensions(ExtensionList extensions,
ExtensionList disabled_extensions,
ExtensionList blocklisted_extensions = ExtensionList()) {
registry_->ClearAll();
for (ExtensionList::const_iterator it = extensions.begin();
it != extensions.end(); ++it) {
registry_->AddEnabled(*it);
}
for (ExtensionList::const_iterator it = disabled_extensions.begin();
it != disabled_extensions.end(); ++it) {
registry_->AddDisabled(*it);
}
for (ExtensionList::const_iterator it = blocklisted_extensions.begin();
it != blocklisted_extensions.end(); ++it) {
registry_->AddBlocklisted(*it);
}
}
private:
ExtensionRegistry* registry_;
};
class ServiceForDownloadTests : public MockService {
public:
explicit ServiceForDownloadTests(
TestExtensionPrefs* prefs,
scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory)
: MockService(prefs, url_loader_factory) {}
// Add a fake crx installer to be returned by a call to UpdateExtension()
// with a specific ID. Caller keeps ownership of |crx_installer|.
void AddFakeCrxInstaller(const std::string& id, CrxInstaller* crx_installer) {
fake_crx_installers_[id] = crx_installer;
}
bool UpdateExtension(const CRXFileInfo& file,
bool file_ownership_passed,
CrxInstaller** out_crx_installer) override {
extension_id_ = file.extension_id;
install_path_ = file.path;
if (base::Contains(fake_crx_installers_, extension_id_)) {
*out_crx_installer = fake_crx_installers_[extension_id_];
return true;
}
return false;
}
PendingExtensionManager* pending_extension_manager() override {
return &pending_extension_manager_;
}
const std::string& extension_id() const { return extension_id_; }
const base::FilePath& install_path() const { return install_path_; }
private:
// Hold the set of ids that UpdateExtension() should fake success on.
// UpdateExtension(id, ...) will return true iff fake_crx_installers_
// contains key |id|. |out_install_notification_source| will be set
// to Source<CrxInstaller(fake_crx_installers_[i]).
std::map<std::string, CrxInstaller*> fake_crx_installers_;
std::string extension_id_;
base::FilePath install_path_;
GURL download_url_;
};
static const int kUpdateFrequencySecs = 15;
// Takes a string with KEY=VALUE parameters separated by '&' in |params| and
// puts the key/value pairs into |result|. For keys with no value, the empty
// string is used. So for "a=1&b=foo&c", result would map "a" to "1", "b" to
// "foo", and "c" to "".
static void ExtractParameters(const std::string& params,
std::map<std::string, std::string>* result) {
for (const std::string& pair : base::SplitString(
params, "&", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL)) {
std::vector<std::string> key_val = base::SplitString(
pair, "=", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
if (!key_val.empty()) {
std::string key = key_val[0];
EXPECT_TRUE(result->find(key) == result->end());
(*result)[key] = (key_val.size() == 2) ? key_val[1] : std::string();
} else {
NOTREACHED();
}
}
}
// Helper function to extract the ping data param values for each extension in
// a manifest fetch url, returned in a map keyed by extension id.
// E.g. for "x=id%3Dabcdef%26ping%3Ddr%253D1%2526dr%253D1024" we'd return
// {"abcdef": {"dr": set("1", "1024")}}
typedef std::map<std::string, std::set<std::string>> ParamsMap;
static std::map<std::string, ParamsMap> GetPingDataFromURL(
const GURL& manifest_url) {
std::map<std::string, ParamsMap> result;
base::StringPairs toplevel_params;
base::SplitStringIntoKeyValuePairs(
manifest_url.query(), '=', '&', &toplevel_params);
for (const auto& param : toplevel_params) {
if (param.first != "x")
continue;
// We've found "x=<something>", now unescape <something> and look for
// the "id=<id>&ping=<ping_value>" parameters within.
std::string unescaped = net::UnescapeBinaryURLComponent(param.second);
base::StringPairs extension_params;
base::SplitStringIntoKeyValuePairs(unescaped, '=', '&', &extension_params);
std::multimap<std::string, std::string> param_map;
param_map.insert(extension_params.begin(), extension_params.end());
if (base::Contains(param_map, "id") && base::Contains(param_map, "ping")) {
std::string id = param_map.find("id")->second;
result[id] = ParamsMap();
// Pull the key=value pairs out of the ping parameter for this id and
// put into the result.
std::string ping =
net::UnescapeBinaryURLComponent(param_map.find("ping")->second);
base::StringPairs ping_params;
base::SplitStringIntoKeyValuePairs(ping, '=', '&', &ping_params);
for (const auto& ping_param : ping_params) {
if (!base::Contains(result[id], ping_param.first))
result[id][ping_param.first] = std::set<std::string>();
result[id][ping_param.first].insert(ping_param.second);
}
}
}
return result;
}
static void VerifyQueryAndExtractParameters(
const std::string& query,
std::map<std::string, std::string>* result) {
std::map<std::string, std::string> params;
ExtractParameters(query, ¶ms);
std::string omaha_params = UpdateQueryParams::Get(UpdateQueryParams::CRX);
std::map<std::string, std::string> expected;
ExtractParameters(omaha_params, &expected);
for (auto it = expected.begin(); it != expected.end(); ++it) {
EXPECT_EQ(it->second, params[it->first]);
}
EXPECT_EQ(1U, params.count("x"));
std::string decoded = net::UnescapeBinaryURLComponent(params["x"]);
ExtractParameters(decoded, result);
}
// All of our tests that need to use private APIs of ExtensionUpdater live
// inside this class (which is a friend to ExtensionUpdater).
class ExtensionUpdaterTest : public testing::Test {
public:
ExtensionUpdaterTest()
: task_environment_(content::BrowserTaskEnvironment::IO_MAINLOOP),
testing_local_state_(TestingBrowserProcess::GetGlobal()) {}
void SetUp() override {
prefs_ = std::make_unique<TestExtensionPrefs>(
base::ThreadTaskRunnerHandle::Get());
}
void TearDown() override {
// Some tests create URLRequestContextGetters, whose destruction must run
// on the IO thread. Make sure the IO loop spins before shutdown so that
// those objects are released.
RunUntilIdle();
prefs_.reset();
}
void RunUntilIdle() {
prefs_->pref_service()->CommitPendingWrite();
base::RunLoop().RunUntilIdle();
}
void SimulateTimerFired(ExtensionUpdater* updater) { updater->NextCheck(); }
void OverrideUpdateService(ExtensionUpdater* updater,
UpdateService* service) {
updater->update_service_ = service;
}
// Adds a Result with the given data to results.
void AddParseResult(const std::string& id,
const std::string& version,
const std::string& url,
UpdateManifestResults* results) {
UpdateManifestResult result;
result.extension_id = id;
result.version = version;
result.crx_url = GURL(url);
results->update_list.push_back(result);
}
void StartUpdateCheck(ExtensionDownloader* downloader,
ManifestFetchData* fetch_data) {
downloader->StartUpdateCheck(
std::unique_ptr<ManifestFetchData>(fetch_data));
}
size_t ManifestFetchersCount(ExtensionDownloader* downloader) {
return downloader->manifests_queue_.size() +
(downloader->manifest_loader_.get() ? 1 : 0);
}
std::set<std::string> GetRunningInstallIds(const ExtensionUpdater& updater) {
std::set<std::string> ret;
for (const auto& pair : updater.running_crx_installs_)
ret.insert(pair.second.info.extension_id);
return ret;
}
void TestExtensionUpdateCheckRequests(bool pending) {
// Create an extension with an update_url.
ExtensionDownloaderTestHelper helper;
ServiceForManifestTests service(prefs_.get(), helper.url_loader_factory());
std::string update_url("http://foo.com/bar");
ExtensionList extensions;
NotificationsObserver observer;
PendingExtensionManager* pending_extension_manager =
service.pending_extension_manager();
if (pending) {
SetupPendingExtensionManagerForTest(1, GURL(update_url),
pending_extension_manager);
} else {
service.CreateTestExtensions(1, 1, &extensions, &update_url,
Manifest::INTERNAL);
service.set_extensions(extensions, ExtensionList());
}
// Set up and start the updater.
ExtensionUpdater updater(&service,
service.extension_prefs(),
service.pref_service(),
service.profile(),
60 * 60 * 24,
NULL,
service.GetDownloaderFactory());
updater.Start();
// Tell the update that it's time to do update checks.
EXPECT_EQ(0u, observer.StartedCount());
SimulateTimerFired(&updater);
EXPECT_EQ(1u, observer.StartedCount());
// Get the url our loader was asked to fetch.
const ManifestFetchData& fetch =
*updater.downloader_->manifests_queue_.active_request();
const GURL& url = fetch.full_url();
EXPECT_FALSE(url.is_empty());
EXPECT_TRUE(url.is_valid());
EXPECT_TRUE(url.SchemeIs("http"));
EXPECT_EQ("foo.com", url.host());
EXPECT_EQ("/bar", url.path());
// Validate the extension request parameters in the query. It should
// look something like "x=id%3D<id>%26v%3D<version>%26uc".
EXPECT_TRUE(url.has_query());
std::map<std::string, std::string> params;
VerifyQueryAndExtractParameters(url.query(), ¶ms);
if (pending) {
EXPECT_TRUE(pending_extension_manager->IsIdPending(params["id"]));
EXPECT_EQ("0.0.0.0", params["v"]);
} else {
EXPECT_EQ(extensions[0]->id(), params["id"]);
EXPECT_EQ(extensions[0]->VersionString(), params["v"]);
}
EXPECT_EQ("", params["uc"]);
}
void TestUpdateUrlDataEmpty() {
const std::string id(32, 'a');
const std::string version = "1.0";
// Make sure that an empty update URL data string does not cause a ap=
// option to appear in the x= parameter.
std::unique_ptr<ManifestFetchData> fetch_data(
CreateManifestFetchData(GURL("http://localhost/foo")));
fetch_data->AddExtension(id, version, &kNeverPingedData, std::string(),
std::string(), Manifest::Location::INTERNAL,
ManifestFetchData::FetchPriority::BACKGROUND);
std::map<std::string, std::string> params;
VerifyQueryAndExtractParameters(fetch_data->full_url().query(), ¶ms);
EXPECT_EQ(id, params["id"]);
EXPECT_EQ(version, params["v"]);
EXPECT_EQ(0U, params.count("ap"));
}
void TestUpdateUrlDataSimple() {
const std::string id(32, 'a');
const std::string version = "1.0";
// Make sure that an update URL data string causes an appropriate ap=
// option to appear in the x= parameter.
std::unique_ptr<ManifestFetchData> fetch_data(
CreateManifestFetchData(GURL("http://localhost/foo")));
fetch_data->AddExtension(id, version, &kNeverPingedData, "bar",
std::string(), Manifest::Location::INTERNAL,
ManifestFetchData::FetchPriority::BACKGROUND);
std::map<std::string, std::string> params;
VerifyQueryAndExtractParameters(fetch_data->full_url().query(), ¶ms);
EXPECT_EQ(id, params["id"]);
EXPECT_EQ(version, params["v"]);
EXPECT_EQ("bar", params["ap"]);
}
void TestUpdateUrlDataCompound() {
const std::string id(32, 'a');
const std::string version = "1.0";
// Make sure that an update URL data string causes an appropriate ap=
// option to appear in the x= parameter.
std::unique_ptr<ManifestFetchData> fetch_data(
CreateManifestFetchData(GURL("http://localhost/foo")));
fetch_data->AddExtension(id, version, &kNeverPingedData, "a=1&b=2&c",
std::string(), Manifest::Location::INTERNAL,
ManifestFetchData::FetchPriority::BACKGROUND);
std::map<std::string, std::string> params;
VerifyQueryAndExtractParameters(fetch_data->full_url().query(), ¶ms);
EXPECT_EQ(id, params["id"]);
EXPECT_EQ(version, params["v"]);
EXPECT_EQ("a%3D1%26b%3D2%26c", params["ap"]);
}
void TestUpdateUrlDataFromUrl(
const std::string& update_url,
ManifestFetchData::FetchPriority fetch_priority,
int num_extensions,
bool should_include_traffic_management_headers) {
ExtensionDownloaderTestHelper helper;
MockService service(prefs_.get(), helper.url_loader_factory());
ExtensionList extensions;
service.CreateTestExtensions(1, num_extensions, &extensions, &update_url,
Manifest::INTERNAL);
for (int i = 0; i < num_extensions; ++i) {
const std::string& id = extensions[i]->id();
EXPECT_CALL(helper.delegate(), GetPingDataForExtension(id, _));
helper.downloader().AddExtension(*extensions[i], 0, fetch_priority);
}
// Get the headers our loader was asked to fetch.
base::RunLoop loop;
net::HttpRequestHeaders last_request_headers;
helper.test_url_loader_factory().SetInterceptor(base::BindLambdaForTesting(
[&](const network::ResourceRequest& request) {
last_request_headers = request.headers;
loop.Quit();
}));
helper.downloader().StartAllPending(NULL);
EXPECT_TRUE(helper.downloader().manifest_loader_);
loop.Run();
// Make sure that extensions that update from the gallery ignore any
// update URL data.
const ManifestFetchData& fetch =
*helper.downloader().manifests_queue_.active_request();
const std::string& fetcher_url = fetch.full_url().spec();
std::string::size_type x = fetcher_url.find("x=");
EXPECT_NE(std::string::npos, x);
std::string::size_type ap = fetcher_url.find("ap%3D", x);
EXPECT_EQ(std::string::npos, ap);
net::HttpRequestHeaders fetch_headers;
std::swap(fetch_headers, last_request_headers);
EXPECT_EQ(should_include_traffic_management_headers,
fetch_headers.HasHeader(
ExtensionDownloader::kUpdateInteractivityHeader));
EXPECT_EQ(should_include_traffic_management_headers,
fetch_headers.HasHeader(ExtensionDownloader::kUpdateAppIdHeader));
EXPECT_EQ(
should_include_traffic_management_headers,
fetch_headers.HasHeader(ExtensionDownloader::kUpdateUpdaterHeader));
if (should_include_traffic_management_headers) {
std::string interactivity_value;
fetch_headers.GetHeader(ExtensionDownloader::kUpdateInteractivityHeader,
&interactivity_value);
std::string expected_interactivity_value =
fetch_priority == ManifestFetchData::FetchPriority::FOREGROUND ? "fg"
: "bg";
EXPECT_EQ(expected_interactivity_value, interactivity_value);
std::string appid_value;
fetch_headers.GetHeader(ExtensionDownloader::kUpdateAppIdHeader,
&appid_value);
if (num_extensions > 1) {
for (int i = 0; i < num_extensions; ++i) {
EXPECT_TRUE(
testing::IsSubstring("", "", extensions[i]->id(), appid_value));
}
} else {
EXPECT_EQ(extensions[0]->id(), appid_value);
}
std::string updater_value;
fetch_headers.GetHeader(ExtensionDownloader::kUpdateUpdaterHeader,
&updater_value);
const std::string expected_updater_value = base::StringPrintf(
"%s-%s", UpdateQueryParams::GetProdIdString(UpdateQueryParams::CRX),
UpdateQueryParams::GetProdVersion().c_str());
EXPECT_EQ(expected_updater_value, updater_value);
}
}
void TestInstallSource() {
const std::string id(32, 'a');
const std::string version = "1.0";
const std::string install_source = "instally";
// Make sure that an installsource= appears in the x= parameter.
std::unique_ptr<ManifestFetchData> fetch_data(
CreateManifestFetchData(GURL("http://localhost/foo")));
fetch_data->AddExtension(id, version, &kNeverPingedData,
kEmptyUpdateUrlData, install_source,
Manifest::Location::INTERNAL,
ManifestFetchData::FetchPriority::BACKGROUND);
std::map<std::string, std::string> params;
VerifyQueryAndExtractParameters(fetch_data->full_url().query(), ¶ms);
EXPECT_EQ(id, params["id"]);
EXPECT_EQ(version, params["v"]);
EXPECT_EQ(install_source, params["installsource"]);
}
void TestInstallLocation() {
const std::string id(32, 'a');
const std::string version = "1.0";
const std::string install_location = "external";
// Make sure that installedby= appears in the x= parameter.
std::unique_ptr<ManifestFetchData> fetch_data(
CreateManifestFetchData(GURL("http://localhost/foo")));
fetch_data->AddExtension(id, version, &kNeverPingedData,
kEmptyUpdateUrlData, std::string(),
Manifest::Location::EXTERNAL_PREF_DOWNLOAD,
ManifestFetchData::FetchPriority::BACKGROUND);
std::map<std::string, std::string> params;
VerifyQueryAndExtractParameters(fetch_data->full_url().query(), ¶ms);
EXPECT_EQ(id, params["id"]);
EXPECT_EQ(version, params["v"]);
EXPECT_EQ(install_location, params["installedby"]);
}
void TestDetermineUpdates() {
ExtensionDownloaderTestHelper helper;
// Check passing an empty list of parse results to DetermineUpdates
std::unique_ptr<ManifestFetchData> fetch_data(
CreateManifestFetchData(GURL("http://localhost/foo")));
UpdateManifestResults updates;
std::vector<UpdateManifestResult*> updateable;
std::set<std::string> not_updateable;
ManifestInvalidFailureDataList errors;
helper.downloader().DetermineUpdates(*fetch_data, updates, &updateable,
¬_updateable, &errors);
EXPECT_TRUE(updateable.empty());
EXPECT_TRUE(not_updateable.empty());
EXPECT_TRUE(errors.empty());
// Create two updates - expect that DetermineUpdates will return the first
// one (v1.0 installed, v1.1 available) but not the second one (both
// installed and available at v2.0).
const std::string id1 = crx_file::id_util::GenerateId("1");
const std::string id2 = crx_file::id_util::GenerateId("2");
fetch_data->AddExtension(id1, "1.0.0.0", &kNeverPingedData,
kEmptyUpdateUrlData, std::string(),
Manifest::Location::INTERNAL,
ManifestFetchData::FetchPriority::BACKGROUND);
AddParseResult(id1, "1.1", "http://localhost/e1_1.1.crx", &updates);
fetch_data->AddExtension(id2, "2.0.0.0", &kNeverPingedData,
kEmptyUpdateUrlData, std::string(),
Manifest::Location::INTERNAL,
ManifestFetchData::FetchPriority::BACKGROUND);
AddParseResult(id2, "2.0.0.0", "http://localhost/e2_2.0.crx", &updates);
EXPECT_CALL(helper.delegate(), IsExtensionPending(_))
.WillRepeatedly(Return(false));
EXPECT_CALL(helper.delegate(), GetExtensionExistingVersion(id1, _))
.WillOnce(DoAll(SetArgPointee<1>("1.0.0.0"), Return(true)));
EXPECT_CALL(helper.delegate(), GetExtensionExistingVersion(id2, _))
.WillOnce(DoAll(SetArgPointee<1>("2.0.0.0"), Return(true)));
updateable.clear();
not_updateable.clear();
errors.clear();
helper.downloader().DetermineUpdates(*fetch_data, updates, &updateable,
¬_updateable, &errors);
EXPECT_TRUE(errors.empty());
EXPECT_THAT(not_updateable, testing::ElementsAre(id2));
ASSERT_EQ(1u, updateable.size());
EXPECT_EQ("1.1", updateable[0]->version);
}
void TestDetermineUpdatesError() {
ExtensionDownloaderTestHelper helper;
MockExtensionDownloaderDelegate& delegate = helper.delegate();
std::unique_ptr<ManifestFetchData> fetch_data(
CreateManifestFetchData(GURL("http://localhost/foo")));
UpdateManifestResults updates;
// id1 => updatable (current version (1.1) is older than update version).
// id2 => non_updateable (current version (2.0.0.0) is the same as update
// version).
// id3 => non_updateable (manifest update version is empty).
// id4 => errors (|updates| doesn't contain id4).
// id5 => errors (the extension is not currently installed).
// id6 => errors (manifest update version is invalid).
const std::string id1 = crx_file::id_util::GenerateId("1");
const std::string id2 = crx_file::id_util::GenerateId("2");
const std::string id3 = crx_file::id_util::GenerateId("3");
const std::string id4 = crx_file::id_util::GenerateId("4");
const std::string id5 = crx_file::id_util::GenerateId("5");
const std::string id6 = crx_file::id_util::GenerateId("6");
fetch_data->AddExtension(id1, "1.0.0.0", &kNeverPingedData,
kEmptyUpdateUrlData, std::string(),
Manifest::Location::INTERNAL,
ManifestFetchData::FetchPriority::BACKGROUND);
AddParseResult(id1, "1.1", "http://localhost/e1_1.1.crx", &updates);
fetch_data->AddExtension(id2, "2.0.0.0", &kNeverPingedData,
kEmptyUpdateUrlData, std::string(),
Manifest::Location::INTERNAL,
ManifestFetchData::FetchPriority::BACKGROUND);
AddParseResult(id2, "2.0.0.0", "http://localhost/e2_2.0.crx", &updates);
fetch_data->AddExtension(id3, "0.0.0.0", &kNeverPingedData,
kEmptyUpdateUrlData, std::string(),
Manifest::Location::INTERNAL,
ManifestFetchData::FetchPriority::BACKGROUND);
// Empty update version in manifest.
AddParseResult(id3, "", "http://localhost/e3_3.0.crx", &updates);
fetch_data->AddExtension(id4, "0.0.0.0", &kNeverPingedData,
kEmptyUpdateUrlData, std::string(),