forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
/
PRESUBMIT.py
40 lines (33 loc) · 1.52 KB
/
PRESUBMIT.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
# Copyright 2017 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
_CPP_WHITE_LIST = (r'.+\.cc$', r'.+\.h$')
def CheckMakeUnique(input_api, output_api):
"""Encourage to use std::make_unique, instead of base::MakeUnique."""
errors = []
def SourceFilter(affected_file):
return input_api.FilterSourceFile(affected_file, _CPP_WHITE_LIST,
input_api.DEFAULT_BLACK_LIST)
for f in input_api.AffectedSourceFiles(SourceFilter):
for line_number, line in f.ChangedContents():
if input_api.re.search(r'\bbase::MakeUnique<', line):
errors.append(output_api.PresubmitError(
'%s:%d uses base::MakeUnique. Use std::make_unique instead.' %
(f.LocalPath(), line_number)))
return errors
def CheckUniquePtr(input_api, output_api):
# Runs CheckUniquePtr in cc/PRESUBMIT.py.
# Probably, we'd like to promote the check to somewhere to be shared.
presubmit_path = (
input_api.change.RepositoryRoot() + '/cc/PRESUBMIT.py')
presubmit_content = input_api.ReadFile(presubmit_path)
global_vars = {}
exec(presubmit_content, global_vars)
return global_vars['CheckUniquePtr'](input_api, output_api)
def CheckChangeOnUpload(input_api, output_api):
results = []
results += input_api.canned_checks.CheckChangeLintsClean(
input_api, output_api)
results += CheckUniquePtr(input_api, output_api)
results += CheckMakeUnique(input_api, output_api)
return results