From 04209ec5b08095a9b207905c6d6090478892345a Mon Sep 17 00:00:00 2001 From: foolip Date: Wed, 26 Oct 2016 03:42:02 -0700 Subject: [PATCH] Use RTCPeerConnection instead of webkitRTCPeerConnection Cases where the second argument (constraints) is used are left alone, as a reminder that this isn't standarized behavior. BUG=658423 Review-Url: https://codereview.chromium.org/2446173002 Cr-Commit-Position: refs/heads/master@{#427662} --- .../docs/examples/api/desktopCapture/app.js | 5 +- .../api_test/tab_capture/end_to_end.js | 4 +- .../api_test/tab_capture/performance.js | 4 +- content/test/data/media/datachannel_test.html | 4 +- .../test/data/media/mediarecorder_test.html | 4 +- .../test/data/media/peerconnection-call.html | 6 +- .../examples/video_effects/video_effects.html | 1 - .../mediastream/constructors-expected.txt | 6 +- .../fast/mediastream/constructors.html | 6 +- .../RTCPeerConnection-AddRemoveStream.html | 2 +- ...TCPeerConnection-createAnswer-promise.html | 4 +- .../RTCPeerConnection-createAnswer.html | 4 +- ...RTCPeerConnection-createOffer-promise.html | 4 +- .../RTCPeerConnection-createOffer.html | 4 +- .../RTCPeerConnection-datachannel.html | 4 +- .../RTCPeerConnection-dtmf.html | 2 +- .../RTCPeerConnection-events.html | 2 +- .../RTCPeerConnection-expected.txt | 103 ++++++++-------- ...RTCPeerConnection-generateCertificate.html | 20 ++-- .../RTCPeerConnection-getStats-promise.html | 2 +- ...RTCPeerConnection-ice-promise-expected.txt | 2 +- .../RTCPeerConnection-ice-promise.html | 2 +- .../peerconnection/RTCPeerConnection-ice.html | 4 +- .../RTCPeerConnection-lifetime.html | 6 +- ...erConnection-localDescription-promise.html | 2 +- .../RTCPeerConnection-localDescription.html | 6 +- ...RTCPeerConnection-onnegotiationneeded.html | 2 +- ...rConnection-remoteDescription-promise.html | 2 +- .../RTCPeerConnection-remoteDescription.html | 6 +- .../RTCPeerConnection-remotestreams.html | 4 +- .../RTCPeerConnection-state.html | 2 +- .../RTCPeerConnection-stats-expected.txt | 2 +- .../RTCPeerConnection-stats.html | 2 +- ...CPeerConnection-statsSelector-expected.txt | 2 +- .../RTCPeerConnection-statsSelector.html | 2 +- .../peerconnection/RTCPeerConnection.html | 110 +++++++++--------- 36 files changed, 174 insertions(+), 173 deletions(-) diff --git a/chrome/common/extensions/docs/examples/api/desktopCapture/app.js b/chrome/common/extensions/docs/examples/api/desktopCapture/app.js index a6d8e4717dbdda..e7ae8bc3051d64 100644 --- a/chrome/common/extensions/docs/examples/api/desktopCapture/app.js +++ b/chrome/common/extensions/docs/examples/api/desktopCapture/app.js @@ -60,12 +60,11 @@ function gotStream(stream) { video.src = URL.createObjectURL(stream); stream.onended = function() { console.log('Ended'); }; - var servers = null; - pc1 = new webkitRTCPeerConnection(servers); + pc1 = new RTCPeerConnection(); pc1.onicecandidate = function(event) { onIceCandidate(pc1, event); }; - pc2 = new webkitRTCPeerConnection(servers); + pc2 = new RTCPeerConnection(); pc2.onicecandidate = function(event) { onIceCandidate(pc2, event); }; diff --git a/chrome/test/data/extensions/api_test/tab_capture/end_to_end.js b/chrome/test/data/extensions/api_test/tab_capture/end_to_end.js index 087eddfc1f2316..e15e266800595c 100644 --- a/chrome/test/data/extensions/api_test/tab_capture/end_to_end.js +++ b/chrome/test/data/extensions/api_test/tab_capture/end_to_end.js @@ -207,8 +207,8 @@ chrome.test.runTests([ receiveStream = captureStream; waitForExpectedColors(colorDeviation); } else if (transportMethod == 'webrtc') { - var sender = new webkitRTCPeerConnection(null); - var receiver = new webkitRTCPeerConnection(null); + var sender = new RTCPeerConnection(); + var receiver = new RTCPeerConnection(); sender.onicecandidate = function (event) { if (event.candidate) { receiver.addIceCandidate(new RTCIceCandidate(event.candidate)); diff --git a/chrome/test/data/extensions/api_test/tab_capture/performance.js b/chrome/test/data/extensions/api_test/tab_capture/performance.js index 552b42ccd37a09..4d6025d03fb197 100644 --- a/chrome/test/data/extensions/api_test/tab_capture/performance.js +++ b/chrome/test/data/extensions/api_test/tab_capture/performance.js @@ -70,8 +70,8 @@ function TestStream(stream) { function testThroughWebRTC(stream) { capture_stream = stream; console.log("Testing through webrtc."); - var sender = new webkitRTCPeerConnection(null); - var receiver = new webkitRTCPeerConnection(null); + var sender = new RTCPeerConnection(); + var receiver = new RTCPeerConnection(); sender.onicecandidate = function (event) { if (event.candidate) { receiver.addIceCandidate(new RTCIceCandidate(event.candidate)); diff --git a/content/test/data/media/datachannel_test.html b/content/test/data/media/datachannel_test.html index 3b6e30325b5be4..aa49fc03bb33a3 100644 --- a/content/test/data/media/datachannel_test.html +++ b/content/test/data/media/datachannel_test.html @@ -6,8 +6,8 @@ // Tests that an RTCDataChannel with event handlers is not garbage-collected // prematurely. function testDataChannelGC() { - var pc1 = new webkitRTCPeerConnection(null); - var pc2 = new webkitRTCPeerConnection(null); + var pc1 = new RTCPeerConnection(); + var pc2 = new RTCPeerConnection(); var iceCandidateHandler = function(rpc) { return function(e) { diff --git a/content/test/data/media/mediarecorder_test.html b/content/test/data/media/mediarecorder_test.html index 86e392d3507bec..fa58e53950e987 100644 --- a/content/test/data/media/mediarecorder_test.html +++ b/content/test/data/media/mediarecorder_test.html @@ -42,8 +42,8 @@ return new Promise(function(resolve, reject) { var localStream = stream; var remoteStream = null; - var localPeerConnection = new webkitRTCPeerConnection(null); - var remotePeerConnection = new webkitRTCPeerConnection(null); + var localPeerConnection = new RTCPeerConnection(); + var remotePeerConnection = new RTCPeerConnection(); function createAnswer(description) { remotePeerConnection.createAnswer(function(description) { diff --git a/content/test/data/media/peerconnection-call.html b/content/test/data/media/peerconnection-call.html index c592ab2c9b7081..781b86968836ab 100644 --- a/content/test/data/media/peerconnection-call.html +++ b/content/test/data/media/peerconnection-call.html @@ -518,7 +518,7 @@ } function callWithDevicePermissionGranted() { - var pc = new webkitRTCPeerConnection(null, null); + var pc = new RTCPeerConnection(); gatherIceCandidates(pc, function(candidates) { var hasLoopbackCandidate = false; assertEquals(candidates.length > 0, true); @@ -534,7 +534,7 @@ } function callWithNoCandidateExpected() { - var pc = new webkitRTCPeerConnection({iceServers:[]}, null); + var pc = new RTCPeerConnection(); gatherIceCandidates(pc, function(candidates) { assertEquals(candidates.length, 0); reportTestSuccess(); @@ -542,7 +542,7 @@ } function callAndExpectNonLoopbackCandidates() { - var pc = new webkitRTCPeerConnection(null, null); + var pc = new RTCPeerConnection(); gatherIceCandidates(pc, function(candidates) { var hasCandidate = false; assertEquals(candidates.length > 0, true); diff --git a/ppapi/examples/video_effects/video_effects.html b/ppapi/examples/video_effects/video_effects.html index fa37d59b81c489..54697534ca2e5a 100644 --- a/ppapi/examples/video_effects/video_effects.html +++ b/ppapi/examples/video_effects/video_effects.html @@ -49,7 +49,6 @@ width="320" height="240"/> diff --git a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-lifetime.html b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-lifetime.html index 7991384ffa2d53..7565bf796d6f53 100644 --- a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-lifetime.html +++ b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-lifetime.html @@ -25,7 +25,7 @@ function createPeerConnectionAndDataChannel() { // The Peer Connection object is leaked - var pc = new webkitRTCPeerConnection({iceServers:[]}, null); + var pc = new RTCPeerConnection(); dc = pc.createDataChannel("label"); dc.onopen = dataChannelOpen; } @@ -34,7 +34,7 @@ var observationB = null; // Test that the PeerConnection object is gc'd if close is called. -var pcA = new webkitRTCPeerConnection(null, null); +var pcA = new RTCPeerConnection(); // Do not pass the object directly to observeGC function. This may // remain live on this function's stack preventing GC from collecting // it. Accessing the object inside an inner function will prevent any @@ -47,7 +47,7 @@ observationA = null; // Test that the PeerConnection object is not gc'd if close is not called. - pcB = new webkitRTCPeerConnection(null, null); + pcB = new RTCPeerConnection(); // Do not pass the object directly to observeGC function. This may // remain live on this function's stack preventing GC from collecting // it. Accessing the object inside an inner function will prevent any diff --git a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-localDescription-promise.html b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-localDescription-promise.html index 1eb3c289f85a26..9749767fb3f302 100644 --- a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-localDescription-promise.html +++ b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-localDescription-promise.html @@ -56,7 +56,7 @@ testPassed('expectedInvalidSessionDescription was called.') } -pc = new webkitRTCPeerConnection(null, null); +pc = new RTCPeerConnection(); shouldNotThrow('pc.setLocalDescription().catch(expectedTypeError)'); shouldNotThrow('pc.setLocalDescription(null).catch(expectedInvalidSessionDescription)'); var sessionDescription = new RTCSessionDescription({type:"offer", sdp:"local"}); diff --git a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-localDescription.html b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-localDescription.html index 801373d0ff7ceb..1619aef9601404 100644 --- a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-localDescription.html +++ b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-localDescription.html @@ -52,7 +52,7 @@ function testExecutionOrderClosedConnection() { - var localPeerConnection = new webkitRTCPeerConnection(null, null); + var localPeerConnection = new RTCPeerConnection(); localPeerConnection.close(); var counter = 0; window.events = []; @@ -65,13 +65,13 @@ events[counter++] = 2; }); Promise.resolve().then(_ => { - events[counter++] = 3; + events[counter++] = 3; shouldBe('events', '[1,2,3]'); }); } shouldNotThrow('testExecutionOrderClosedConnection()'); -pc = new webkitRTCPeerConnection(null, null); +pc = new RTCPeerConnection(); shouldNotThrow('pc.setLocalDescription().catch(expectedTypeError)'); shouldNotThrow('pc.setLocalDescription(null).catch(expectedInvalidSessionDescription)'); var sessionDescription = new RTCSessionDescription({type:"offer", sdp:"local"}); diff --git a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-onnegotiationneeded.html b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-onnegotiationneeded.html index 3cd322e9ddac4e..d2b178ebc52237 100644 --- a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-onnegotiationneeded.html +++ b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-onnegotiationneeded.html @@ -34,7 +34,7 @@ testPassed('Got a stream.'); stream = s; - pc = new webkitRTCPeerConnection(null, null); + pc = new RTCPeerConnection(); pc.onnegotiationneeded = onNegotiationNeeded; pc.addStream(stream); diff --git a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remoteDescription-promise.html b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remoteDescription-promise.html index 31e12bcf6327a4..c675b3951e66bb 100644 --- a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remoteDescription-promise.html +++ b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remoteDescription-promise.html @@ -56,7 +56,7 @@ testPassed('expectedInvalidSessionDescription was called.') } -pc = new webkitRTCPeerConnection(null, null); +pc = new RTCPeerConnection(); shouldNotThrow('pc.setRemoteDescription().catch(expectedTypeError)'); shouldNotThrow('pc.setRemoteDescription(null).catch(expectedInvalidSessionDescription)'); var sessionDescription = new RTCSessionDescription({type:"answer", sdp:"remote"}); diff --git a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remoteDescription.html b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remoteDescription.html index 573eeedd2cbdb3..722773f1038d00 100644 --- a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remoteDescription.html +++ b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remoteDescription.html @@ -52,7 +52,7 @@ function testExecutionOrderClosedConnection() { - var localPeerConnection = new webkitRTCPeerConnection(null, null); + var localPeerConnection = new RTCPeerConnection(); localPeerConnection.close(); var counter = 0; window.events = []; @@ -65,13 +65,13 @@ events[counter++] = 2; }); Promise.resolve().then(_ => { - events[counter++] = 3; + events[counter++] = 3; shouldBe('events', '[1,2,3]'); }); } shouldNotThrow('testExecutionOrderClosedConnection()'); -pc = new webkitRTCPeerConnection(null, null); +pc = new RTCPeerConnection(); shouldNotThrow('pc.setRemoteDescription().catch(expectedTypeError)'); shouldNotThrow('pc.setRemoteDescription(null).catch(expectedInvalidSessionDescription)'); var sessionDescription = new RTCSessionDescription({type:"answer", sdp:"remote"}); diff --git a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remotestreams.html b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remotestreams.html index b2690cbd2aa20c..a693e494fe253c 100644 --- a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remotestreams.html +++ b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remotestreams.html @@ -28,7 +28,7 @@ { testPassed('requestSucceeded was called.'); shouldBeEqualToNumber('pc.getRemoteStreams().length', 0); - finishJSTest(); + finishJSTest(); } function requestSucceeded1() @@ -73,7 +73,7 @@ shouldBeFalse('event.stream.active') } -pc = new webkitRTCPeerConnection(null, null); +pc = new RTCPeerConnection(); pc.onaddstream = onAddStream; pc.onremovestream = onRemoveStream; getUserMedia({audio:true, video:true}, gotStream); diff --git a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-state.html b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-state.html index d7fb3f5ff8a558..5f5d7d80515557 100644 --- a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-state.html +++ b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-state.html @@ -9,7 +9,7 @@