Skip to content

Commit

Permalink
DEPS update: Breakpad 51db53eec729, LSS 3f6478ac95ed, NaCl 412a6e2bb153
Browse files Browse the repository at this point in the history
Yes, these three updates are truly interdependent. See
https://crbug.com/629874.

Breakpad was previously on a branch that had cherry-picked 027633792600.
Breakpad 2fcb8afbc807 requires linux-syscall-support 3f6478ac95ed. The
repository for linux-syscall-support has changed locations. Native
Client also depends on linux-syscall-support and must be updated to
412a6e2bb153 for compatibility with this version of
linux-syscall-support.

Update Breakpad to 51db53eec7293a35cb6fc10bd2e333f22dd9d201

220c852dc209 Dump INFO CODE_ID containing Build ID in Linux dump_syms
2fcb8afbc807 linux-syscall-support: pull in latest version
1f7cb2e4c523 Server-side workaround to handle overlapping modules
8c612166fa87 Add a new argument to specify the minidump type to write on
             Windows
2131271ecabd [Android] Guard some NDK workarounds by major version
027633792600 Recover memory mappings before writing dump on ChromeOS
0de9e29cb674 Don't define |r_debug| and |link_map| on Android releases
             21 and later
e55a878d5b74 Add process type to MicroDumpExtraInfo
423e661072aa Add new exception code for OOM generated from Chromium
4dc6be51f90c Revert "Don't define |r_debug| and |link_map| on Android
             releases 21 and later"
51db53eec729 Remove DISALLOW_COPY_AND_ASSIGN from MinidumpStreamInfo

Update linux-syscall-support to 3f6478ac95edf86cd3da300c2c0d34a438f5dbeb

2ce6a9744160 Add codereview.settings for new repo location
cd0177fdded9 Fix VIEW_VC URL in codereview.settings
929203010984 Finally fix VIEW_VC url with proper review
08056836f2b4 migrate site/wiki docs over
348bdf8d32b3 README: clearly document goals/APIs/supported systems
3f6478ac95ed Add s390/s390x support to linux_syscall_support.h

Update Native Client to 412a6e2bb153f39f22b9b3e47bc1ed0abb82df3f

412a6e2bb153 Update linux-syscall-support to 3f6478ac95ed

Update generate_breakpad_symbols.py for Breakpad 220c852dc209.

BUG=629874
TEST=tools/perf/run_tests core.stacktrace_unittest.TabStackTraceTest.

Review-Url: https://codereview.chromium.org/2167703002
Cr-Commit-Position: refs/heads/master@{#407569}
  • Loading branch information
markmentovai authored and Commit bot committed Jul 25, 2016
1 parent b005452 commit 051962e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,11 @@ vars = {
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling lss
# and whatever else without interference from each other.
'lss_revision': '4fc942258fe5509549333b9487ec018e3c8c5b10',
'lss_revision': '3f6478ac95edf86cd3da300c2c0d34a438f5dbeb',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling NaCl
# and whatever else without interference from each other.
'nacl_revision': '0ea1fef9391b6084be99b9238542b4782365e23c',
'nacl_revision': '412a6e2bb153f39f22b9b3e47bc1ed0abb82df3f',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling freetype-android
# and whatever else without interference from each other.
Expand All @@ -106,7 +106,7 @@ allowed_hosts = [

deps = {
'src/breakpad/src':
Var('chromium_git') + '/breakpad/breakpad/src.git' + '@' + '7c70f47255713629c8053826008bd00f98d71ced',
Var('chromium_git') + '/breakpad/breakpad/src.git' + '@' + '51db53eec7293a35cb6fc10bd2e333f22dd9d201',

'src/buildtools':
Var('chromium_git') + '/chromium/buildtools.git' + '@' + Var('buildtools_revision'),
Expand Down Expand Up @@ -362,7 +362,7 @@ deps_os = {
Var('chromium_git') + '/chromium/deps/xdg-utils.git' + '@' + 'd80274d5869b17b8c9067a1022e4416ee7ed5e0d',

'src/third_party/lss':
Var('chromium_git') + '/external/linux-syscall-support/lss.git' + '@' + Var('lss_revision'),
Var('chromium_git') + '/linux-syscall-support.git' + '@' + Var('lss_revision'),

# For Linux and Chromium OS.
'src/third_party/cros_system_api':
Expand Down Expand Up @@ -472,7 +472,7 @@ deps_os = {
Var('chromium_git') + '/external/github.com/square/leakcanary.git' + '@' + '608ded739e036a3aa69db47ac43777dcee506f8e',

'src/third_party/lss':
Var('chromium_git') + '/external/linux-syscall-support/lss.git' + '@' + Var('lss_revision'),
Var('chromium_git') + '/linux-syscall-support.git' + '@' + Var('lss_revision'),

'src/third_party/requests/src':
Var('chromium_git') + '/external/github.com/kennethreitz/requests.git' + '@' + 'f172b30356d821d180fa4ecfa3e71c7274a32de4',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ def _Worker():
break

binary_info = GetBinaryInfoFromHeaderInfo(
GetCommandOutput([dump_syms, '-i', binary]))
GetCommandOutput([dump_syms, '-i', binary]).splitlines()[0])
if not binary_info:
should_dump_syms = False
reason = "Could not obtain binary information."
Expand Down

0 comments on commit 051962e

Please sign in to comment.