From 064792ea9aa1864fad96841c7bffd206478b6b9e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Hajdan=2C=20Jr?= Date: Mon, 13 Nov 2017 16:24:51 +0000 Subject: [PATCH] Remove references to phajdan.jr Bug: 783662 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If14081b9b17a3502435d2f2c4fcccfbbe51ae813 Reviewed-on: https://chromium-review.googlesource.com/763447 Reviewed-by: Jochen Eisinger Cr-Commit-Position: refs/heads/master@{#515954} --- OWNERS | 2 -- WATCHLISTS | 4 ---- base/test/OWNERS | 2 -- build/linux/OWNERS | 1 - chrome/installer/linux/OWNERS | 1 - chrome/test/OWNERS | 1 - chromecast/browser/test/OWNERS | 2 -- components/keyed_service/OWNERS | 1 - content/public/test/OWNERS | 1 - content/test/OWNERS | 1 - docs/adding_to_third_party.md | 33 ---------------------------- infra/OWNERS | 1 - infra/config/OWNERS | 1 - net/tools/testserver/OWNERS | 3 --- testing/OWNERS | 1 - testing/buildbot/OWNERS | 1 - testing/scripts/OWNERS | 1 - third_party/devscripts/OWNERS | 1 - third_party/googletest/OWNERS | 1 - third_party/pyftpdlib/OWNERS | 1 - tools/OWNERS | 1 - tools/checklicenses/OWNERS | 2 -- tools/generate_library_loader/OWNERS | 1 - tools/mb/OWNERS | 1 - tools/tests/OWNERS | 1 - 25 files changed, 66 deletions(-) delete mode 100644 chromecast/browser/test/OWNERS delete mode 100644 net/tools/testserver/OWNERS delete mode 100644 third_party/pyftpdlib/OWNERS diff --git a/OWNERS b/OWNERS index c160cb0472da55..db7e31dcd90796 100644 --- a/OWNERS +++ b/OWNERS @@ -14,13 +14,11 @@ per-file .vpython=dpranke@chromium.org per-file .vpython=iannucci@chromium.org per-file .vpython=jbudorick@chromium.org per-file .vpython=nednguyen@chromium.org -per-file .vpython=phajdan.jr@chromium.org per-file AUTHORS=* per-file BUILD.gn=file://build/OWNERS per-file codereview.settings=agable@chromium.org per-file DEPS=* per-file PRESUBMIT*.py=dcheng@chromium.org per-file PRESUBMIT*.py=jochen@chromium.org -per-file PRESUBMIT*.py=phajdan.jr@chromium.org per-file README.md=* per-file WATCHLISTS=* diff --git a/WATCHLISTS b/WATCHLISTS index 8d84518c4807e5..fb9dbe5d802091 100644 --- a/WATCHLISTS +++ b/WATCHLISTS @@ -855,9 +855,6 @@ 'filesapp_ui': { 'filepath': 'ui/file_manager' }, - 'ftp': { - 'filepath': 'ftp', - }, 'fuchsia': { 'filepath': 'fuchsia', }, @@ -2013,7 +2010,6 @@ 'oka+watch@chromium.org', 'yamaguchi+watch@chromium.org'], 'filesapp_ui': ['mtomasz+watch@chromium.org'], - 'ftp': ['phajdan.jr@chromium.org'], 'fuchsia': ['sergeyu@chromium.org', 'wez@chromium.org'], 'fuzzing': ['fuzzing@chromium.org'], 'gamepad': ['cco3+watch@chromium.org', diff --git a/base/test/OWNERS b/base/test/OWNERS index e226fb1a52514c..6f374e681bfef1 100644 --- a/base/test/OWNERS +++ b/base/test/OWNERS @@ -1,5 +1,3 @@ -phajdan.jr@chromium.org - per-file *task_scheduler*=file://base/task_scheduler/OWNERS # Metrics-related test utilties: diff --git a/build/linux/OWNERS b/build/linux/OWNERS index 3ab55d6dd0e88c..8e1cb557290d64 100644 --- a/build/linux/OWNERS +++ b/build/linux/OWNERS @@ -1,4 +1,3 @@ mmoss@chromium.org -phajdan.jr@chromium.org thestig@chromium.org thomasanderson@chromium.org diff --git a/chrome/installer/linux/OWNERS b/chrome/installer/linux/OWNERS index 03bbc162ca33be..f6ce2762a5e3b9 100644 --- a/chrome/installer/linux/OWNERS +++ b/chrome/installer/linux/OWNERS @@ -1,5 +1,4 @@ set noparent mmoss@chromium.org -phajdan.jr@chromium.org thestig@chromium.org thomasanderson@chromium.org diff --git a/chrome/test/OWNERS b/chrome/test/OWNERS index 8d35a051fb0022..a641b611d3ea54 100644 --- a/chrome/test/OWNERS +++ b/chrome/test/OWNERS @@ -1,4 +1,3 @@ -phajdan.jr@chromium.org sky@chromium.org # If you're doing structural changes get a review from one of the OWNERS. diff --git a/chromecast/browser/test/OWNERS b/chromecast/browser/test/OWNERS deleted file mode 100644 index e5202e85f4c1f4..00000000000000 --- a/chromecast/browser/test/OWNERS +++ /dev/null @@ -1,2 +0,0 @@ -# content/public/test OWNERS for review of Chromecast browser test code -phajdan.jr@chromium.org diff --git a/components/keyed_service/OWNERS b/components/keyed_service/OWNERS index 6e5450111c844f..4733a4f06bfe46 100644 --- a/components/keyed_service/OWNERS +++ b/components/keyed_service/OWNERS @@ -1,2 +1 @@ erg@chromium.org -phajdan.jr@chromium.org diff --git a/content/public/test/OWNERS b/content/public/test/OWNERS index 1ab83cc30e2f18..b7ed7d1af20bac 100644 --- a/content/public/test/OWNERS +++ b/content/public/test/OWNERS @@ -1,4 +1,3 @@ -phajdan.jr@chromium.org sky@chromium.org # For WebRTC files. diff --git a/content/test/OWNERS b/content/test/OWNERS index b989afd3954324..800f3fba90c726 100644 --- a/content/test/OWNERS +++ b/content/test/OWNERS @@ -1,4 +1,3 @@ -phajdan.jr@chromium.org sky@chromium.org # For WebRTC files. diff --git a/docs/adding_to_third_party.md b/docs/adding_to_third_party.md index 2f5d235a33280f..f091b21d3a75e3 100644 --- a/docs/adding_to_third_party.md +++ b/docs/adding_to_third_party.md @@ -65,11 +65,6 @@ Run the following scripts: * `src/tools/licenses.py scan` - This will complain about incomplete or missing data for third_party checkins. We use 'licenses.py credits' to generate the about:credits page in Google Chrome builds. -* `src/tools/checklicenses/checklicenses.py` - See below for info on how to - handle possible failures. - -See the ["Odds n' Ends"](adding_to_third_party.md#Odds-n_Ends) Section below if -you run into any failures running these. If the library will never be shipped as a part of Chrome (e.g. build-time tools, testing tools), make sure to set "License File" as "NOT_SHIPPED" so that the @@ -155,31 +150,3 @@ ticket](https://bugs.chromium.org/p/chromium/issues/entry?template=Infra-Git) for infra and ask the infra team what needs to be done. Note that you'll need unlimited quota for at least two role accounts. See the quota status of `boringssl` as an example. - -## Odds n' Ends - -### Handling `licenses_check (checklicenses.py)` failures - -This is needed for [Issue -28291](http://code.google.com/p/chromium/issues/detail?id=28291): Pass the -Ubuntu license check script: - -__If the failure looks like ... ... the right action is to ... __ - -* 'filename' has non-whitelisted license 'UNKNOWN' - * Ideally make the licensecheck.pl script recognize the license of that - file. Often this requires __adding a license header__. Does it have - license header? If it's third party code, ask the upstream project to make - sure all their files have license headers. If the license header is there - but is not recognized, we should try to patch licensecheck.pl. If in - doubt please contact phajdan.jr@chromium.org -* 'filename' has non-whitelisted license 'X' and X is BSD-compatible - * Add the license X to WHITELISTED_LICENSES in checklicenses.py . Make sure - to respect the OWNERS of that file. You must get an approval before - landing. CLs violating this requirement may be reverted. -* 'filename' has non-whitelisted license 'X' and X is not BSD-compatible (i.e. - GPL) - * Do you really need to add those files? Chromium is BSD-licensed so the - resulting binaries can't use GPL code. Ideally we just shouldn't have - those files at all in the tree. If in doubt, please ask mal@chromium.org - diff --git a/infra/OWNERS b/infra/OWNERS index 52b34348a2a766..35567a542a17d6 100644 --- a/infra/OWNERS +++ b/infra/OWNERS @@ -1,6 +1,5 @@ iannucci@chromium.org nodir@chromium.org -phajdan.jr@chromium.org sergiyb@chromium.org dpranke@chromium.org diff --git a/infra/config/OWNERS b/infra/config/OWNERS index 497050dc4b4a25..a1a0f2f6146366 100644 --- a/infra/config/OWNERS +++ b/infra/config/OWNERS @@ -1,4 +1,3 @@ -phajdan.jr@chromium.org sergiyb@chromium.org smut@google.com tandrii@chromium.org diff --git a/net/tools/testserver/OWNERS b/net/tools/testserver/OWNERS deleted file mode 100644 index 78ad9aa0f3d1ed..00000000000000 --- a/net/tools/testserver/OWNERS +++ /dev/null @@ -1,3 +0,0 @@ -# net/ OWNERS can also review testserver changes -# General reviewer. -phajdan.jr@chromium.org diff --git a/testing/OWNERS b/testing/OWNERS index 43dc478ca16c46..f502654dab6f43 100644 --- a/testing/OWNERS +++ b/testing/OWNERS @@ -1,4 +1,3 @@ -phajdan.jr@chromium.org dpranke@chromium.org # These aren't actually great contact points for this directory, but diff --git a/testing/buildbot/OWNERS b/testing/buildbot/OWNERS index a0f45584dd9e8f..81830ac2f3f524 100644 --- a/testing/buildbot/OWNERS +++ b/testing/buildbot/OWNERS @@ -8,7 +8,6 @@ jochen@chromium.org kbr@chromium.org machenbach@chromium.org maruel@chromium.org -phajdan.jr@chromium.org sky@chromium.org tansell@chromium.org thakis@chromium.org diff --git a/testing/scripts/OWNERS b/testing/scripts/OWNERS index 1491874134a70e..4a51aa0b2586a9 100644 --- a/testing/scripts/OWNERS +++ b/testing/scripts/OWNERS @@ -3,7 +3,6 @@ dpranke@chromium.org iannucci@chromium.org -phajdan.jr@chromium.org # TEAM: infra-dev@chromium.org # COMPONENT: Infra>Client>Chrome diff --git a/third_party/devscripts/OWNERS b/third_party/devscripts/OWNERS index 47e2ae53666f9b..1967bf567e8eb3 100644 --- a/third_party/devscripts/OWNERS +++ b/third_party/devscripts/OWNERS @@ -1,2 +1 @@ -phajdan.jr@chromium.org thestig@chromium.org diff --git a/third_party/googletest/OWNERS b/third_party/googletest/OWNERS index b124ef3ec4f963..21b33d591ae053 100644 --- a/third_party/googletest/OWNERS +++ b/third_party/googletest/OWNERS @@ -1,4 +1,3 @@ thakis@chromium.org pwnall@chromium.org -phajdan.jr@chromium.org dpranke@chromium.org diff --git a/third_party/pyftpdlib/OWNERS b/third_party/pyftpdlib/OWNERS deleted file mode 100644 index 92ecc889fd3c67..00000000000000 --- a/third_party/pyftpdlib/OWNERS +++ /dev/null @@ -1 +0,0 @@ -phajdan.jr@chromium.org diff --git a/tools/OWNERS b/tools/OWNERS index c7709ded97be92..36e45e968bf940 100644 --- a/tools/OWNERS +++ b/tools/OWNERS @@ -39,7 +39,6 @@ per-file include_tracer.py=thakis@chromium.org per-file ipc_messages_log.py=yfriedman@chromium.org -per-file licenses.py=phajdan.jr@chromium.org per-file licenses.py=torne@chromium.org per-file remove_stale_pyc_files.py=dtu@chromium.org diff --git a/tools/checklicenses/OWNERS b/tools/checklicenses/OWNERS index 2abfa66e8a9e10..1967bf567e8eb3 100644 --- a/tools/checklicenses/OWNERS +++ b/tools/checklicenses/OWNERS @@ -1,3 +1 @@ -set noparent -phajdan.jr@chromium.org thestig@chromium.org diff --git a/tools/generate_library_loader/OWNERS b/tools/generate_library_loader/OWNERS index 508f05e86c0669..35a27600f46069 100644 --- a/tools/generate_library_loader/OWNERS +++ b/tools/generate_library_loader/OWNERS @@ -1,2 +1 @@ -phajdan.jr@chromium.org spang@chromium.org diff --git a/tools/mb/OWNERS b/tools/mb/OWNERS index f7dae030d3c1a5..1ae0b4ee00f370 100644 --- a/tools/mb/OWNERS +++ b/tools/mb/OWNERS @@ -1,6 +1,5 @@ dpranke@chromium.org jbudorick@chromium.org -phajdan.jr@chromium.org scottmg@chromium.org tansell@chromium.org diff --git a/tools/tests/OWNERS b/tools/tests/OWNERS index b094cbb9be567c..fe94ff7a66fd17 100644 --- a/tools/tests/OWNERS +++ b/tools/tests/OWNERS @@ -1,2 +1 @@ -per-file licenses_test.py=phajdan.jr@chromium.org per-file licenses_test.py=torne@chromium.org