bluetooth: web: IDL fixes: Inherit EventTarget, SameObject navigator.…

…bluetooth These changes reflect the IDL update made in the spec: WebBluetoothCG/web-bluetooth@8d5ed39 EventTarget is not a mixin, and so 'Implements' should not be used, instead bluetooth should inherit from EventTarget. Also, navigator.bluetooth should use [SameObject]. Review-Url: https://codereview.chromium.org/2616443002 Cr-Commit-Position: refs/heads/master@{#445306}
Denger-Network · Jan 23, 2017 · 09b5874 · 09b5874
1 parent 91b05c8
commit 09b5874
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 4 deletions.
diff --git a/third_party/WebKit/LayoutTests/bluetooth/idl/idl-NavigatorBluetooth.html b/third_party/WebKit/LayoutTests/bluetooth/idl/idl-NavigatorBluetooth.html
@@ -8,4 +8,8 @@
   assert_true('bluetooth' in navigator,
               'navigator.bluetooth exists.');
 }, 'navigator.bluetooth IDL test');
+
+test(() => {
+  assert_equals(navigator.bluetooth, navigator.bluetooth);
+}, '[SameObject] test for navigator.bluetooth');
 </script>
diff --git a/.../LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt b/.../LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
@@ -254,7 +254,7 @@ interface BlobEvent : Event
     getter data
     getter timecode
     method constructor
-interface Bluetooth
+interface Bluetooth : EventTarget
     attribute @@toStringTag
     method constructor
     method requestDevice

diff --git a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt b/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
@@ -354,7 +354,7 @@ interface BlobEvent : Event
     getter data
     getter timecode
     method constructor
-interface Bluetooth
+interface Bluetooth : EventTarget
     attribute @@toStringTag
     method constructor
     method requestDevice

diff --git a/third_party/WebKit/Source/modules/bluetooth/Bluetooth.idl b/third_party/WebKit/Source/modules/bluetooth/Bluetooth.idl
@@ -6,7 +6,7 @@
 
 [
     RuntimeEnabled=WebBluetooth,
-] interface Bluetooth {
+] interface Bluetooth : EventTarget {
     [CallWith=ScriptState, RaisesException, MeasureAs=WebBluetoothRequestDevice] Promise<BluetoothDevice> requestDevice (
         RequestDeviceOptions options
         );

diff --git a/third_party/WebKit/Source/modules/bluetooth/NavigatorBluetooth.idl b/third_party/WebKit/Source/modules/bluetooth/NavigatorBluetooth.idl
@@ -7,5 +7,5 @@
 [
     RuntimeEnabled=WebBluetooth,
 ] partial interface Navigator {
-    readonly attribute Bluetooth bluetooth;
+    [SameObject] readonly attribute Bluetooth bluetooth;
 };