Skip to content

Commit

Permalink
Remove the ad delay throttle
Browse files Browse the repository at this point in the history
This experiment has been disabled for a while. It should be pretty
easy to reland if we decide we want to do it.

Bug: 829042
Change-Id: I273d7a757312f1628ce3878e266311455eb73eb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574281
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Auto-Submit: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652601}
  • Loading branch information
csharrison authored and Commit Bot committed Apr 19, 2019
1 parent 7ff85f3 commit 0c3d1b3
Show file tree
Hide file tree
Showing 12 changed files with 0 additions and 1,312 deletions.
222 changes: 0 additions & 222 deletions chrome/browser/subresource_filter/ad_delay_browsertest.cc

This file was deleted.

14 changes: 0 additions & 14 deletions chrome/renderer/url_loader_throttle_provider_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
#include "components/data_reduction_proxy/core/common/data_reduction_proxy_throttle_manager.h"
#include "components/safe_browsing/features.h"
#include "components/safe_browsing/renderer/renderer_url_loader_throttle.h"
#include "components/subresource_filter/content/renderer/ad_delay_renderer_metadata_provider.h"
#include "content/public/common/content_features.h"
#include "content/public/common/service_names.mojom.h"
#include "content/public/renderer/render_frame.h"
Expand Down Expand Up @@ -260,19 +259,6 @@ URLLoaderThrottleProviderImpl::CreateThrottles(
}
#endif

// Initialize the factory here rather than in the constructor, since metrics
// does not support registering field trials (as opposed to Features) before
// Blink is initialized (after this class).
if (!ad_delay_factory_) {
ad_delay_factory_ =
std::make_unique<subresource_filter::AdDelayThrottle::Factory>();
}
if (auto ad_throttle = ad_delay_factory_->MaybeCreate(
std::make_unique<subresource_filter::AdDelayRendererMetadataProvider>(
request, type_, render_frame_id))) {
throttles.push_back(std::move(ad_throttle));
}

throttles.push_back(std::make_unique<GoogleURLLoaderThrottle>(
ChromeRenderThreadObserver::is_incognito_process(),
ChromeRenderThreadObserver::GetDynamicParams()));
Expand Down
4 changes: 0 additions & 4 deletions chrome/renderer/url_loader_throttle_provider_impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

#include "base/threading/thread_checker.h"
#include "components/safe_browsing/common/safe_browsing.mojom.h"
#include "components/subresource_filter/content/common/ad_delay_throttle.h"
#include "content/public/renderer/url_loader_throttle_provider.h"
#include "extensions/buildflags/buildflags.h"

Expand Down Expand Up @@ -48,9 +47,6 @@ class URLLoaderThrottleProviderImpl
// general use.
URLLoaderThrottleProviderImpl(const URLLoaderThrottleProviderImpl& other);

std::unique_ptr<subresource_filter::AdDelayThrottle::Factory>
ad_delay_factory_;

content::URLLoaderThrottleProviderType type_;
ChromeContentRendererClient* const chrome_content_renderer_client_;

Expand Down
1 change: 0 additions & 1 deletion chrome/test/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -914,7 +914,6 @@ test("browser_tests") {
"../browser/ssl/ssl_client_certificate_selector_test.h",
"../browser/ssl/typed_navigation_timing_throttle_browsertest.cc",
"../browser/storage/durable_storage_browsertest.cc",
"../browser/subresource_filter/ad_delay_browsertest.cc",
"../browser/subresource_filter/ad_tagging_browsertest.cc",
"../browser/subresource_filter/ruleset_browsertest.cc",
"../browser/subresource_filter/subresource_filter_browser_test_harness.cc",
Expand Down
3 changes: 0 additions & 3 deletions components/subresource_filter/content/common/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

static_library("common") {
sources = [
"ad_delay_throttle.cc",
"ad_delay_throttle.h",
"ruleset_dealer.cc",
"ruleset_dealer.h",
"subresource_filter_message_generator.cc",
Expand All @@ -27,7 +25,6 @@ static_library("common") {
source_set("unit_tests") {
testonly = true
sources = [
"ad_delay_throttle_unittest.cc",
"ruleset_dealer_unittest.cc",
]
deps = [
Expand Down
Loading

0 comments on commit 0c3d1b3

Please sign in to comment.