Deprecate hpack_table_size flag, remove dead code.

This CL lands server changes 148221046, 148224472, and 148645081 by yasong.

BUG=488484

Review-Url: https://codereview.chromium.org/2716393002
Cr-Commit-Position: refs/heads/master@{#453379}

BUILD.gn

@@ -235,8 +235,6 @@ group("both_gn_and_gyp") {
       "//gpu/khronos_glcts_support:khronos_glcts_test",
       "//jingle:jingle_unittests",
       "//net:hpack_example_generator",
-      "//net:hpack_fuzz_mutator",
-      "//net:hpack_fuzz_wrapper",
       "//ppapi:ppapi_unittests",
       "//ppapi/examples/2d",
       "//ppapi/examples/audio",
@@ -1044,7 +1042,6 @@ if (!is_ios && !is_android && !is_chromecast) {
     if (!is_win) {
       deps += [
         "//net:dns_fuzz_stub",
-        "//net:hpack_fuzz_wrapper",
         "//skia:filter_fuzz_stub",
       ]
     }

net/BUILD.gn

@@ -2699,38 +2699,6 @@ if (!is_ios && !is_android) {
     ]
   }
 
-  executable("hpack_fuzz_mutator") {
-    testonly = true
-    sources = [
-      "spdy/fuzzing/hpack_fuzz_mutator.cc",
-    ]
-
-    # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
-    configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
-    deps = [
-      ":net",
-      "//base",
-      "//build/config/sanitizers:deps",
-      "//build/win:default_exe_manifest",
-    ]
-  }
-
-  executable("hpack_fuzz_wrapper") {
-    testonly = true
-    sources = [
-      "spdy/fuzzing/hpack_fuzz_wrapper.cc",
-    ]
-
-    # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
-    configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
-    deps = [
-      ":net",
-      "//base",
-      "//build/config/sanitizers:deps",
-      "//build/win:default_exe_manifest",
-    ]
-  }
-
   if (use_v8_in_net) {
     executable("net_watcher") {
       testonly = true

net/spdy/hpack/hpack_header_table.cc

@@ -127,13 +127,7 @@ void HpackHeaderTable::SetMaxSize(size_t max_size) {
 
 void HpackHeaderTable::SetSettingsHeaderTableSize(size_t settings_size) {
   settings_size_bound_ = settings_size;
-  if (!FLAGS_chromium_reloadable_flag_increase_hpack_table_size) {
-    if (settings_size_bound_ < max_size_) {
-      SetMaxSize(settings_size_bound_);
-    }
-  } else {
-    SetMaxSize(settings_size_bound_);
-  }
+  SetMaxSize(settings_size_bound_);
 }
 
 void HpackHeaderTable::EvictionSet(StringPiece name,

net/spdy/hpack/hpack_header_table_test.cc

@@ -259,7 +259,6 @@ TEST_F(HpackHeaderTableTest, EntryIndexing) {
 }
 
 TEST_F(HpackHeaderTableTest, SetSizes) {
-  FLAGS_chromium_reloadable_flag_increase_hpack_table_size = true;
   string key = "key", value = "value";
   const HpackEntry* entry1 = table_.TryAddEntry(key, value);
   const HpackEntry* entry2 = table_.TryAddEntry(key, value);
@@ -291,42 +290,6 @@ TEST_F(HpackHeaderTableTest, SetSizes) {
   EXPECT_EQ(0u, peer_.dynamic_entries().size());
 }
 
-TEST_F(HpackHeaderTableTest, SetSizesOld) {
-  FLAGS_chromium_reloadable_flag_increase_hpack_table_size = false;
-
-  string key = "key", value = "value";
-  const HpackEntry* entry1 = table_.TryAddEntry(key, value);
-  const HpackEntry* entry2 = table_.TryAddEntry(key, value);
-  const HpackEntry* entry3 = table_.TryAddEntry(key, value);
-
-  // Set exactly large enough. No Evictions.
-  size_t max_size = entry1->Size() + entry2->Size() + entry3->Size();
-  table_.SetMaxSize(max_size);
-  EXPECT_EQ(3u, peer_.dynamic_entries().size());
-
-  // Set just too small. One eviction.
-  max_size = entry1->Size() + entry2->Size() + entry3->Size() - 1;
-  table_.SetMaxSize(max_size);
-  EXPECT_EQ(2u, peer_.dynamic_entries().size());
-
-  // Changing SETTINGS_HEADER_TABLE_SIZE doesn't affect table_.max_size(),
-  // iff SETTINGS_HEADER_TABLE_SIZE >= |max_size|.
-  EXPECT_EQ(kDefaultHeaderTableSizeSetting, table_.settings_size_bound());
-  table_.SetSettingsHeaderTableSize(kDefaultHeaderTableSizeSetting * 2);
-  EXPECT_EQ(max_size, table_.max_size());
-  table_.SetSettingsHeaderTableSize(max_size + 1);
-  EXPECT_EQ(max_size, table_.max_size());
-  EXPECT_EQ(2u, peer_.dynamic_entries().size());
-
-  // SETTINGS_HEADER_TABLE_SIZE upper-bounds |table_.max_size()|,
-  // and will force evictions.
-  max_size = entry3->Size() - 1;
-  table_.SetSettingsHeaderTableSize(max_size);
-  EXPECT_EQ(max_size, table_.max_size());
-  EXPECT_EQ(max_size, table_.settings_size_bound());
-  EXPECT_EQ(0u, peer_.dynamic_entries().size());
-}
-
 TEST_F(HpackHeaderTableTest, EvictionCountForEntry) {
   string key = "key", value = "value";
   const HpackEntry* entry1 = table_.TryAddEntry(key, value);

net/spdy/spdy_flags.cc

@@ -18,10 +18,6 @@ bool FLAGS_chromium_http2_flag_spdy_use_hpack_decoder2 = false;
 // Use //net/http2/hpack/decoder as complete HPACK decoder.
 bool FLAGS_chromium_http2_flag_spdy_use_hpack_decoder3 = true;
 
-// If true, increase HPACK table size up to optimal size kOptTableSize if
-// clients allow it.
-bool FLAGS_chromium_reloadable_flag_increase_hpack_table_size = false;
-
 // Use Http2FrameDecoderAdapter.
 // TODO(jamessynge): Remove flag once no longer set by scripts.
 bool FLAGS_chromium_http2_flag_spdy_use_http2_frame_decoder_adapter = false;

net/spdy/spdy_flags.h

@@ -15,8 +15,6 @@ NET_EXPORT_PRIVATE extern bool
     FLAGS_chromium_http2_flag_spdy_use_hpack_decoder2;
 NET_EXPORT_PRIVATE extern bool
     FLAGS_chromium_http2_flag_spdy_use_hpack_decoder3;
-NET_EXPORT_PRIVATE extern bool
-    FLAGS_chromium_reloadable_flag_increase_hpack_table_size;
 NET_EXPORT_PRIVATE extern bool FLAGS_use_http2_frame_decoder_adapter;
 NET_EXPORT_PRIVATE extern bool FLAGS_use_nested_spdy_framer_decoder;
 NET_EXPORT_PRIVATE extern bool