Skip to content

Commit

Permalink
Disable MediaRouterDialogControllerViewsTest.OpenCloseMediaRouterDial…
Browse files Browse the repository at this point in the history
…og on Mac

MediaRouterDialogControllerViewsTest.OpenCloseMediaRouterDialog is failing
on the mac bot. The error logs are:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-cocoa-rel/1321
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8935002203177419984/+/steps/browser_tests_on__none__GPU_on_Mac/0/logs/MediaRouterDialogControllerViewsTest.OpenCloseMediaRouterDialog/0

Tbr: mfoltz@chromium.org
Bug: 883976
Change-Id: I9b7e42b65ec44a97a74d236c179e1698ef0c895e
Reviewed-on: https://chromium-review.googlesource.com/1235264
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592695}
  • Loading branch information
tzik authored and Commit Bot committed Sep 20, 2018
1 parent f4ab46c commit 0ec6f90
Showing 1 changed file with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// found in the LICENSE file.

#include "base/macros.h"
#include "build/build_config.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
Expand Down Expand Up @@ -48,9 +49,15 @@ void MediaRouterDialogControllerViewsTest::OpenMediaRouterDialog() {
ASSERT_TRUE(dialog_controller_->IsShowingMediaRouterDialog());
}

// TODO(crbug.com/883976): OpenCloseMediaRouterDialog is failing on mac.
#if defined(OS_MACOSX)
#define MAYBE_OpenCloseMediaRouterDialog DISABLED_OpenCloseMediaRouterDialog
#else
#define MAYBE_OpenCloseMediaRouterDialog OpenCloseMediaRouterDialog
#endif
// Create/Get a media router dialog for initiator.
IN_PROC_BROWSER_TEST_F(MediaRouterDialogControllerViewsTest,
OpenCloseMediaRouterDialog) {
MAYBE_OpenCloseMediaRouterDialog) {
OpenMediaRouterDialog();
views::Widget* widget = CastDialogView::GetCurrentDialogWidget();
ASSERT_TRUE(widget);
Expand Down

0 comments on commit 0ec6f90

Please sign in to comment.