Skip to content

Commit

Permalink
Add UMA to measure impact of an issue with ARCore provider installation
Browse files Browse the repository at this point in the history
Change-Id: I826216ae37c1602081b75fb7f7161a0bfad01951
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125237
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755520}
  • Loading branch information
bialpio authored and Commit Bot committed Apr 1, 2020
1 parent 2454d0b commit 0f82c52
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
7 changes: 6 additions & 1 deletion chrome/browser/vr/service/xr_runtime_manager_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
#include "base/feature_list.h"
#include "base/lazy_instance.h"
#include "base/memory/singleton.h"
#include "base/metrics/user_metrics.h"
#include "base/metrics/user_metrics_action.h"
#include "base/trace_event/common/trace_event_common.h"
#include "build/build_config.h"
#include "chrome/browser/vr/service/browser_xr_runtime_impl.h"
Expand Down Expand Up @@ -107,8 +109,11 @@ XRRuntimeManagerImpl::GetOrCreateInstance() {
if (arcore_device_provider) {
providers.emplace_back(std::move(arcore_device_provider));
} else {
// TODO(crbug.com/1050470): Remove this logging after investigation.
// TODO(https://crbug.com/1050470): Remove this logging after
// investigation.
LOG(ERROR) << "Could not get ARCoreDeviceProviderFactory";
base::RecordAction(base::UserMetricsAction(
"XR.ARCoreDeviceProviderFactory.NotInstalled"));
}
#endif // BUILDFLAG(ENABLE_ARCORE)
#endif // defined(OS_ANDROID)
Expand Down
12 changes: 12 additions & 0 deletions tools/metrics/actions/actions.xml
Original file line number Diff line number Diff line change
Expand Up @@ -24634,6 +24634,18 @@ should be able to be added at any place in this file.
</description>
</action>

<action name="XR.ARCoreDeviceProviderFactory.NotInstalled"
not_user_triggered="true">
<owner>bialpio@chromium.org</owner>
<description>
Raised when XR service was unable to obtain necessary component. The action
is not directly raised by the user's behavior as it should only be logged
when the user navigates to a website that uses WebXR Device API, only in
case the necessary provider was not installed during browser start-up.
Created to assess the impact of the issue causing https://crbug.com/1050470.
</description>
</action>

<action name="ZoomMinus">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<description>Please enter the description of this user action.</description>
Expand Down

0 comments on commit 0f82c52

Please sign in to comment.