Skip to content

Commit

Permalink
Fix TimeTest.FromExploded_MinMax on macOS 10.13.
Browse files Browse the repository at this point in the history
BUG=785341

Change-Id: I23c09aba5b81386c6ebefacd4a51b9e4fc3c4f30
Reviewed-on: https://chromium-review.googlesource.com/774902
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517168}
  • Loading branch information
asvitkine-chromium authored and Commit Bot committed Nov 16, 2017
1 parent 09f2814 commit 0fd7eee
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions base/time/time_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -653,9 +653,10 @@ TEST_F(TimeTest, FromExploded_MinMax) {
EXPECT_FALSE(parsed_time.is_null());
#endif

#if !defined(OS_ANDROID)
#if !defined(OS_ANDROID) && !defined(OS_MACOSX)
// The dates earlier than |kExplodedMinYear| that don't work are OS version
// dependent on Android.
// dependent on Android and Mac (for example, macOS 10.13 seems to support
// dates before 1902).
exploded.year--;
EXPECT_FALSE(Time::FromUTCExploded(exploded, &parsed_time));
EXPECT_TRUE(parsed_time.is_null());
Expand Down

0 comments on commit 0fd7eee

Please sign in to comment.