forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
android: Require exe unittests to have a foo_unittest_stripped target.
This allows the test runner to not depend on the STRIP env var, which is going away. Other approaches considered: 1. Converting the remaining exe-based tests to apk tests. The apk versions were slower, and didn't pass without other changes though. 2. Just don't strip. But that slows down these two tests by over 100% (due to copying data to the device is slow, and stripped size is 0.5MB while unstripped size is on the order of 10MB). 3. Try to get a trip binary from third_party/android_tools/ndk. That's fiddly since it requires getting the right arch. Since there are only two exe-based tests left, just strip them from gyp. Medium-term, maybe gyp/mac's postbuild stuff can be brought to android, it looks like there are various things that could be made simpler with that. BUG=142642 TEST= build/android/test_runner.py gtest -s sandbox_linux_unittests && build/android/test_runner.py gtest -s breakpad_unittests R=bulach@chromium.org, frankf@chromium.org TBR=jln, thestig Review URL: https://codereview.chromium.org/157743004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250035 0039d316-1c4b-4281-b951-d872f2087c98
- Loading branch information
thakis@chromium.org
committed
Feb 10, 2014
1 parent
e666228
commit 100df29
Showing
4 changed files
with
48 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters