Skip to content

Commit

Permalink
fix an instance of bugprone-argument-comment
Browse files Browse the repository at this point in the history
This new clang-tidy check complains when param names /*in_comments=*/
don't match up with the actual parameter name they're being passed to.
Sometimes this is benign, other times, actual bugs are found.

Bug: 1136209
Change-Id: Id29c886835fd9cfd229e768c4dbd410b1eeedf65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458851
Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815704}
  • Loading branch information
George Burgess IV authored and Commit Bot committed Oct 9, 2020
1 parent fa5125e commit 1088b10
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion components/feed/core/v2/feed_store.cc
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ void FeedStore::RemoveActions(std::vector<LocalActionId> ids,
database_->UpdateEntries(
/*entries_to_save=*/std::make_unique<
std::vector<std::pair<std::string, feedstore::Record>>>(),
/*key_to_remove=*/std::move(keys), std::move(callback));
/*keys_to_remove=*/std::move(keys), std::move(callback));
}

void FeedStore::Write(std::vector<feedstore::Record> records,
Expand Down

0 comments on commit 1088b10

Please sign in to comment.