Navigation: Add the per-navigation-mojo-interface flag.

This CL introduces a new flag to enable the use of per navigations mojo interfaces and allow for progressive rollout of the feature. See bug for the feature design doc. * Add content::feature PerNavigationMojoInterface Bug: 784904 Change-Id: I5bb97a9ea0dbec5b34fe3d247d0c40f05a145fd7 Reviewed-on: https://chromium-review.googlesource.com/1057674 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#559029}
Denger-Network · May 16, 2018 · 10e5515 · 10e5515
1 parent f894cc4
commit 10e5515
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 0 deletions.
diff --git a/content/public/common/browser_side_navigation_policy.cc b/content/public/common/browser_side_navigation_policy.cc
@@ -15,4 +15,8 @@ bool IsBrowserSideNavigationEnabled() {
   return true;
 }
 
+bool IsPerNavigationMojoInterfaceEnabled() {
+  return base::FeatureList::IsEnabled(features::kPerNavigationMojoInterface);
+}
+
 }  // namespace content
diff --git a/content/public/common/browser_side_navigation_policy.h b/content/public/common/browser_side_navigation_policy.h
@@ -13,6 +13,7 @@
 namespace content {
 
 CONTENT_EXPORT bool IsBrowserSideNavigationEnabled();
+CONTENT_EXPORT bool IsPerNavigationMojoInterfaceEnabled();
 
 }  // namespace content
 

diff --git a/content/public/common/content_features.cc b/content/public/common/content_features.cc
@@ -266,6 +266,10 @@ const base::Feature kPassiveEventListenersDueToFling{
 const base::Feature kPdfIsolation = {"PdfIsolation",
                                      base::FEATURE_DISABLED_BY_DEFAULT};
 
+// Whether we should use the navigation_client mojo interface for navigations.
+const base::Feature kPerNavigationMojoInterface = {
+    "PerNavigationMojoInterface", base::FEATURE_DISABLED_BY_DEFAULT};
+
 // If Pepper 3D Image Chromium is allowed, this feature controls whether it is
 // enabled.
 const base::Feature kPepper3DImageChromium {

diff --git a/content/public/common/content_features.h b/content/public/common/content_features.h
@@ -68,6 +68,7 @@ CONTENT_EXPORT extern const base::Feature kOriginTrials;
 CONTENT_EXPORT extern const base::Feature kPassiveDocumentEventListeners;
 CONTENT_EXPORT extern const base::Feature kPassiveEventListenersDueToFling;
 CONTENT_EXPORT extern const base::Feature kPdfIsolation;
+CONTENT_EXPORT extern const base::Feature kPerNavigationMojoInterface;
 CONTENT_EXPORT extern const base::Feature kPepper3DImageChromium;
 CONTENT_EXPORT extern const base::Feature kPurgeAndSuspend;
 CONTENT_EXPORT extern const base::Feature kPWAFullCodeCache;

diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
@@ -27667,6 +27667,7 @@ from previous Chrome versions.
   <int value="696600628" label="VibrateRequiresUserGesture:disabled"/>
   <int value="698809951" label="WebRtcHWVP8Encoding:enabled"/>
   <int value="699149897" label="ContentSuggestionsDebugLog:disabled"/>
+  <int value="701766325" label="PerNavigationMojoInterface:enabled"/>
   <int value="705713283" label="EasyUnlockPromotions:disabled"/>
   <int value="709850261" label="disable-touch-editing"/>
   <int value="711424932" label="enable-cloud-print-xps"/>
@@ -28138,6 +28139,7 @@ from previous Chrome versions.
   <int value="1776475705" label="show-composited-layer-borders"/>
   <int value="1777059507" label="trust-autofill-server-name-types"/>
   <int value="1777806335" label="UsePasswordSeparatedSigninFlow:disabled"/>
+  <int value="1782210532" label="PerNavigationMojoInterface:disabled"/>
   <int value="1783293530" label="disallow-autofill-sync-credential"/>
   <int value="1783837132" label="enable-threaded-gpu-rasterization"/>
   <int value="1785093465" label="enable-document-passive-event-listeners"/>