Skip to content

Commit

Permalink
[Cookies] Update upgrade histogram lifetimes
Browse files Browse the repository at this point in the history
Since we commit to supporting every upgrade path *until* the next
version is two years old (at which it becomes the new base version) we
should just have these histograms expire when their own related version
is old enough the upgrade path will be cut anyway. That way, this is a
nice reminder to remove the version from the code.

OBSOLETE_HISTOGRAMS=This upgrade path is no longer possible as of Feb 2024

Change-Id: I04dadb1796af3f8e809f6737beeb3634ef8db227
Fixed: 359221038
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5782994
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Chris Fredrickson <cfredric@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Commit-Queue: Chris Fredrickson <cfredric@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1340494}
  • Loading branch information
arichiv authored and pull[bot] committed Aug 12, 2024
1 parent 5003a03 commit 1180836
Showing 1 changed file with 5 additions and 15 deletions.
20 changes: 5 additions & 15 deletions tools/metrics/histograms/metadata/cookie/histograms.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1115,18 +1115,8 @@ chromium-metrics-reviews@google.com.
</summary>
</histogram>

<histogram name="Cookie.TimeDatabaseMigrationToV18" units="ms"
expires_after="2024-12-01">
<owner>arichiv@chromium.org</owner>
<owner>src/net/cookies/OWNERS</owner>
<summary>
The amount of time (ms) to migrate a v17 cookie database to v18. Migration
occurs upon first startup of a browser version with v17 database code.
</summary>
</histogram>

<histogram name="Cookie.TimeDatabaseMigrationToV19" units="ms"
expires_after="2024-09-22">
expires_after="2025-09-22">
<owner>arichiv@chromium.org</owner>
<owner>src/net/cookies/OWNERS</owner>
<summary>
Expand All @@ -1136,7 +1126,7 @@ chromium-metrics-reviews@google.com.
</histogram>

<histogram name="Cookie.TimeDatabaseMigrationToV20" units="ms"
expires_after="2024-11-13">
expires_after="2025-11-14">
<owner>bingler@chromium.org</owner>
<owner>src/net/cookies/OWNERS</owner>
<summary>
Expand All @@ -1146,7 +1136,7 @@ chromium-metrics-reviews@google.com.
</histogram>

<histogram name="Cookie.TimeDatabaseMigrationToV21" units="ms"
expires_after="2024-11-20">
expires_after="2025-11-22">
<owner>cfredric@chromium.org</owner>
<owner>src/net/cookies/OWNERS</owner>
<summary>
Expand All @@ -1156,7 +1146,7 @@ chromium-metrics-reviews@google.com.
</histogram>

<histogram name="Cookie.TimeDatabaseMigrationToV22" units="ms"
expires_after="2025-03-19">
expires_after="2026-03-22">
<owner>arichiv@chromium.org</owner>
<owner>src/net/cookies/OWNERS</owner>
<summary>
Expand All @@ -1166,7 +1156,7 @@ chromium-metrics-reviews@google.com.
</histogram>

<histogram name="Cookie.TimeDatabaseMigrationToV23" units="ms"
expires_after="2025-04-19">
expires_after="2026-04-10">
<owner>selya@chromium.org</owner>
<owner>src/net/cookies/OWNERS</owner>
<summary>
Expand Down

0 comments on commit 1180836

Please sign in to comment.