Skip to content

Commit

Permalink
Remove base::Value::Equals() use in //google_apis.
Browse files Browse the repository at this point in the history
Bug: 646113
Change-Id: I86d7cee612371b35b90eb5020a7bda03f84f4315
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3759636
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1023642}
  • Loading branch information
zetafunction authored and Chromium LUCI CQ committed Jul 13, 2022
1 parent 642456b commit 132909b
Showing 1 changed file with 5 additions and 8 deletions.
13 changes: 5 additions & 8 deletions google_apis/gaia/gaia_oauth_client_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -447,14 +447,11 @@ TEST_F(GaiaOAuthClientTest, GetUserInfo) {
auth.GetUserInfo("access_token", 1, &delegate);
FlushNetwork();

std::unique_ptr<base::Value> value =
base::JSONReader::ReadDeprecated(kDummyFullUserInfoResult);
DCHECK(value);
ASSERT_TRUE(value->is_dict());
base::DictionaryValue* expected_result;
value->GetAsDictionary(&expected_result);

ASSERT_TRUE(expected_result->Equals(captured_result.get()));
absl::optional<base::Value> expected_value =
base::JSONReader::Read(kDummyFullUserInfoResult);
DCHECK(expected_value);
ASSERT_TRUE(expected_value->is_dict());
EXPECT_EQ(*expected_value, *captured_result);
}

TEST_F(GaiaOAuthClientTest, GetTokenInfo) {
Expand Down

0 comments on commit 132909b

Please sign in to comment.