Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The ultimate goal is to eliminate TOOLKIT_USES_GTK. Once that migration is completed, TOOLKIT_VIEWS + OS_LINUX should be enough. Until this happens, we need a binary that: 1) has both gtk and pure-views 2) can enable pure views components with --use-pure-views when possible (this is default in touchui=1). If we could switch everything with --use-pure-views, that'd be nice, but the world is not perfect and there are things that cannot co-exist (such as message pump). For such component, we'll use GYP_DEFINES to switch. 1) TOOLKIT_USES_PURE_VIEWS is defined with toolkit_pure_views=1. 2) all (or most of) chrome features must be functional with toolkit_pure_views=1 3) both TOOLKIT_USES_GTK and TOOLKIT_USES_PURE_VIEWS are defined. The latter has higher priority (that is, if implementation can't co-exists, TOOLKIT_USE_PURE_VIEWS will take precedence). 4) As the migration proceeds, there will be less TOOLKIT_USES_GTK and more TOOLKIT_USES_PURE_VIEWS. 5) Once the migration is complete (that is, there is no TOOKIT_USES_GTK), we can remove TOOLKIT_USES_PURE_VIEWS or replace it with OS_LINUX when necessary. BUG=none TEST=none Review URL: http://codereview.chromium.org/7273079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91164 0039d316-1c4b-4281-b951-d872f2087c98
- Loading branch information