Skip to content

Commit

Permalink
ipc: Remove a CHECK to fix some memory tests.
Browse files Browse the repository at this point in the history
The affected code isn't used in production yet, so this seems okay as a short
term solution to fix some tests. The problem is that --single_process and
similar flags are causing the supposedly process-wide singleton to be set from
different locations.

BUG=534539

Review URL: https://codereview.chromium.org/1360593003

Cr-Commit-Position: refs/heads/master@{#350045}
  • Loading branch information
erikchen authored and Commit bot committed Sep 21, 2015
1 parent 9f9f5da commit 1baeeb3
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion ipc/attachment_broker.cc
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@ namespace IPC {

// static
void AttachmentBroker::SetGlobal(AttachmentBroker* broker) {
CHECK(!g_attachment_broker);
// TODO(erikchen): There should be a CHECK here to make sure that
// |g_attachment_broker| is nullptr. Right now, this causes problems with
// --single_process and similar testing conditions. I'm temporarily removing
// this CHECK. http://crbug.com/534539.
g_attachment_broker = broker;
}

Expand Down

0 comments on commit 1baeeb3

Please sign in to comment.