Skip to content

Commit

Permalink
[tab_container] Hack-in fix for broken constraint on animation
Browse files Browse the repository at this point in the history
Custom view controller transition animations must be designed
so as not to break constraints on the presented/dismissed VC's view.

This CL addresses a broken constraint due to the zoom animator.
The zoom animator will resize the VC's view to a small rect.
However, that rect is smaller in height than the sum of the
height constraints on the subviews of the tab_container.

This CL simply reduces the subview height constant. Since the
transition animation will likely change, there is no need to modify
the zoom animator at this time.

BUG=

Review-Url: https://codereview.chromium.org/2717133002
Cr-Commit-Position: refs/heads/master@{#453249}
  • Loading branch information
edx246 authored and Commit bot committed Feb 27, 2017
1 parent 393f08e commit 1bcc418
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

namespace {
CGFloat kToolbarHeight = 44.0f;
CGFloat kTabStripHeight = 200.0f;
CGFloat kTabStripHeight = 90.0f;
}

@interface TabContainerViewController ()
Expand Down

0 comments on commit 1bcc418

Please sign in to comment.