From 228c8a161c1ee91177da7c045f17e11ddf463661 Mon Sep 17 00:00:00 2001
From: Jason Hu <hujasonx@google.com>
Date: Wed, 23 Aug 2023 16:31:38 +0000
Subject: [PATCH] [Lens]Add translate onebox entrypoint

Bug: b/295927287
Change-Id: Iaf425359288b25b6ed7a0be3e95483ffc7354f05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4804823
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Jason Hu <hujasonx@google.com>
Cr-Commit-Position: refs/heads/main@{#1187312}
---
 .../chromium/chrome/browser/lens/LensMetrics.java   | 13 +++++++++----
 components/lens/lens_metrics.h                      |  3 ++-
 ios/chrome/browser/ui/lens/lens_entrypoint.h        |  3 ++-
 tools/metrics/histograms/enums.xml                  |  3 +++
 4 files changed, 16 insertions(+), 6 deletions(-)

diff --git a/chrome/browser/lens/java/src/org/chromium/chrome/browser/lens/LensMetrics.java b/chrome/browser/lens/java/src/org/chromium/chrome/browser/lens/LensMetrics.java
index b2f3d6aaff5b76..d73e732db4d0e6 100644
--- a/chrome/browser/lens/java/src/org/chromium/chrome/browser/lens/LensMetrics.java
+++ b/chrome/browser/lens/java/src/org/chromium/chrome/browser/lens/LensMetrics.java
@@ -60,7 +60,8 @@ public class LensMetrics {
             AmbientSearchEntryPoint.QUICK_ACTION_SEARCH_WIDGET, AmbientSearchEntryPoint.KEYBOARD,
             AmbientSearchEntryPoint.SPOTLIGHT, AmbientSearchEntryPoint.APP_ICON_LONG_PRESS,
             AmbientSearchEntryPoint.PLUS_BUTTON, AmbientSearchEntryPoint.WEB_SEARCH_BAR,
-            AmbientSearchEntryPoint.NUM_ENTRIES})
+            AmbientSearchEntryPoint.COMPANION_REGION_SEARCH,
+            AmbientSearchEntryPoint.TRANSLATE_ONEBOX, AmbientSearchEntryPoint.NUM_ENTRIES})
     @Retention(RetentionPolicy.SOURCE)
     public static @interface AmbientSearchEntryPoint {
         int CONTEXT_MENU_SEARCH_IMAGE_WITH_GOOGLE_LENS = 0;
@@ -76,7 +77,9 @@ public class LensMetrics {
         int APP_ICON_LONG_PRESS = 10;
         int PLUS_BUTTON = 11;
         int WEB_SEARCH_BAR = 12;
-        int NUM_ENTRIES = 13;
+        int COMPANION_REGION_SEARCH = 13;
+        int TRANSLATE_ONEBOX = 14;
+        int NUM_ENTRIES = 15;
     }
 
     // Note: These values must match the CameraOpenEntryPoint enum in enums.xml.
@@ -85,7 +88,8 @@ public class LensMetrics {
             CameraOpenEntryPoint.QUICK_ACTION_SEARCH_WIDGET, CameraOpenEntryPoint.TASKS_SURFACE,
             CameraOpenEntryPoint.KEYBOARD, CameraOpenEntryPoint.SPOTLIGHT,
             CameraOpenEntryPoint.APP_ICON_LONG_PRESS, CameraOpenEntryPoint.PLUS_BUTTON,
-            CameraOpenEntryPoint.WEB_SEARCH_BAR, CameraOpenEntryPoint.NUM_ENTRIES})
+            CameraOpenEntryPoint.WEB_SEARCH_BAR, CameraOpenEntryPoint.TRANSLATE_ONEBOX,
+            CameraOpenEntryPoint.NUM_ENTRIES})
     @Retention(RetentionPolicy.SOURCE)
     public static @interface CameraOpenEntryPoint {
         int OMNIBOX = 0;
@@ -97,7 +101,8 @@ public class LensMetrics {
         int APP_ICON_LONG_PRESS = 6;
         int PLUS_BUTTON = 7;
         int WEB_SEARCH_BAR = 8;
-        int NUM_ENTRIES = 9;
+        int TRANSLATE_ONEBOX = 9;
+        int NUM_ENTRIES = 10;
     }
 
     /**
diff --git a/components/lens/lens_metrics.h b/components/lens/lens_metrics.h
index 67e131382dd7ea..b0619829c9f4d1 100644
--- a/components/lens/lens_metrics.h
+++ b/components/lens/lens_metrics.h
@@ -70,7 +70,8 @@ enum class AmbientSearchEntryPoint {
   PLUS_BUTTON = 11,
   WEB_SEARCH_BAR = 12,
   COMPANION_REGION_SEARCH = 13,
-  kMaxValue = COMPANION_REGION_SEARCH
+  TRANSLATE_ONEBOX = 14,
+  kMaxValue = TRANSLATE_ONEBOX
 };
 
 // This should be kept in sync with the LensRegionSearchAspectRatio enum
diff --git a/ios/chrome/browser/ui/lens/lens_entrypoint.h b/ios/chrome/browser/ui/lens/lens_entrypoint.h
index ef8914fdadbb21..562efbf8d6c088 100644
--- a/ios/chrome/browser/ui/lens/lens_entrypoint.h
+++ b/ios/chrome/browser/ui/lens/lens_entrypoint.h
@@ -19,7 +19,8 @@ enum class LensEntrypoint {
   AppIconLongPress = 7,
   PlusButton = 8,
   WebSearchBar = 9,
-  kMaxValue = WebSearchBar,
+  TranslateOnebox = 10,
+  kMaxValue = TranslateOnebox,
 };
 
 extern const char kIOSLensEntrypoint[];
diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
index 18669cdb2a1310..053747e589d073 100644
--- a/tools/metrics/histograms/enums.xml
+++ b/tools/metrics/histograms/enums.xml
@@ -1907,6 +1907,7 @@ Unknown properties are collapsed to zero. -->
   <int value="11" label="Plus Button (Camera)"/>
   <int value="12" label="Web Search Bar (Camera)"/>
   <int value="13" label="Companion (Region)"/>
+  <int value="14" label="Translate Onebox (Camera)"/>
 </enum>
 
 <enum name="AmbientUiMode">
@@ -14222,6 +14223,7 @@ Called by update_bad_message_reasons.py.-->
   <int value="6" label="App Icon Long Press"/>
   <int value="7" label="Plus Button"/>
   <int value="8" label="Web Search Bar"/>
+  <int value="9" label="Translate Onebox"/>
 </enum>
 
 <enum name="CameraPreviewSnapPosition">
@@ -55633,6 +55635,7 @@ Unsupported non-ascii characters will cause issues with xml presubmits.
     plus button.
   </int>
   <int value="9" label="Web Search Bar"/>
+  <int value="10" label="Translate Onebox"/>
 </enum>
 
 <enum name="IOSLensSupportStatus">