[base] Relocate isolate support inclusion to test.gni.

Moves the data dependency on testing:test_scripts_shared to
the platform-specific implementations of the test() template.

Previously, //base:test_support was including test_scripts_shared,
which caused the Python scripts to be bundled in Android APKs and
Fuchsia FAR files *in addition* to isolated data.

Bug: 1293574
Change-Id: I61783e278c3f537ad56362ffdc1f22512baee6d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3481076
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Benoit Lize <lizeb@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/main@{#974217}

base/test/BUILD.gn

@@ -145,12 +145,6 @@ static_library("test_support") {
 
   configs += [ "//build/config:precompiled_headers" ]
 
-  data_deps = [
-    # The isolate needs this script for setting up the test. It's not actually
-    # needed to run this target locally.
-    "//testing:test_scripts_shared",
-  ]
-
   public_deps = [
     ":test_config",
     "//base",

testing/test.gni

@@ -330,6 +330,9 @@ template("test") {
       } else {
         data_deps = []
       }
+
+      data_deps += [ "//testing:test_scripts_shared" ]
+
       if (tests_have_location_tags) {
         data = [ "//testing/location_tags.json" ]
       }
@@ -487,6 +490,8 @@ template("test") {
         data_deps = []
       }
 
+      data_deps += [ "//testing:test_scripts_shared" ]
+
       # TODO(crbug.com/1199334): Because perfetto unit test is defined outside
       # of chromium, the dependency to the filter file is added here.
       data_deps += [ "//testing/buildbot/filters:perfetto_unittests_filters" ]
@@ -600,6 +605,8 @@ template("test") {
         data_deps = []
       }
 
+      data_deps += [ "//testing:test_scripts_shared" ]
+
       # Include the generate_wrapper as part of data_deps
       data_deps += [ ":${_wrapper_output_name}" ]
       write_runtime_deps = _runtime_deps_file
@@ -667,10 +674,13 @@ template("test") {
       data += [ _runtime_deps_file ]
       deps += [ ":$_gen_runner_target" ]
 
+      if (!defined(data_deps)) {
+        data_deps = []
+      }
+
+      data_deps += [ "//testing:test_scripts_shared" ]
+
       if (use_rts) {
-        if (!defined(data_deps)) {
-          data_deps = []
-        }
         data_deps += [ ":${invoker.target_name}__rts_filters" ]
       }
     }
@@ -755,6 +765,8 @@ template("test") {
         data_deps = []
       }
 
+      data_deps += [ "//testing:test_scripts_shared" ]
+
       write_runtime_deps = _runtime_deps_file
       deps += [ ":$_gen_runner_target" ]
       if (_use_ash_chrome && also_build_ash_chrome) {
@@ -837,10 +849,13 @@ template("test") {
       write_runtime_deps = _runtime_deps_file
       deps += [ ":$_gen_runner_target" ]
 
+      if (!defined(data_deps)) {
+        data_deps = []
+      }
+
+      data_deps += [ "//testing:test_scripts_shared" ]
+
       if (use_rts) {
-        if (!defined(data_deps)) {
-          data_deps = []
-        }
         data_deps += [ ":${invoker.target_name}__rts_filters" ]
       }
     }
@@ -858,10 +873,13 @@ template("test") {
         deps = []
       }
 
+      if (!defined(data_deps)) {
+        data_deps = []
+      }
+
+      data_deps += [ "//testing:test_scripts_shared" ]
+
       if (use_rts) {
-        if (!defined(data_deps)) {
-          data_deps = []
-        }
         data_deps += [ ":${invoker.target_name}__rts_filters" ]
       }
     }