Skip to content

Commit

Permalink
Include-what-you-use related to logging.h (ipc)
Browse files Browse the repository at this point in the history
Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

TBR=kinuko

Bug: 1031540
Change-Id: I11f6bd375b17f0d62f50c960756c07dd20d102e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247895
Commit-Queue: Hans Wennborg <hans@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#779370}
  • Loading branch information
zmodem authored and Commit Bot committed Jun 17, 2020
1 parent 36a58e2 commit 2439759
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions ipc/ipc_message_attachment.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

#include "base/files/scoped_file.h"
#include "base/logging.h"
#include "base/notreached.h"
#include "ipc/ipc_mojo_handle_attachment.h"
#include "mojo/public/cpp/system/platform_handle.h"

Expand Down
1 change: 1 addition & 0 deletions ipc/ipc_message_utils.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

#include "base/files/file_path.h"
#include "base/json/json_writer.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h"
#include "base/strings/nullable_string16.h"
#include "base/strings/string_number_conversions.h"
Expand Down
1 change: 1 addition & 0 deletions ipc/ipc_mojo_message_helper.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

#include <utility>

#include "base/logging.h"
#include "ipc/ipc_mojo_handle_attachment.h"

namespace IPC {
Expand Down
1 change: 1 addition & 0 deletions ipc/ipc_mojo_param_traits.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#include "ipc/ipc_mojo_param_traits.h"

#include "base/logging.h"
#include "ipc/ipc_message_utils.h"
#include "ipc/ipc_mojo_handle_attachment.h"
#include "ipc/ipc_mojo_message_helper.h"
Expand Down
1 change: 1 addition & 0 deletions ipc/message_router.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#include "ipc/message_router.h"

#include "base/logging.h"
#include "ipc/ipc_message.h"

namespace IPC {
Expand Down

0 comments on commit 2439759

Please sign in to comment.